From: Zijun Hu <zijun_hu@icloud.com>
To: Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Maxime Ripard <mripard@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Grant Likely <grant.likely@secretlab.ca>
Cc: Zijun Hu <zijun_hu@icloud.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Zijun Hu <quic_zijuhu@quicinc.com>
Subject: [PATCH v2 7/7] of: Do not expose of_alias_scan() and correct its comments
Date: Mon, 16 Dec 2024 08:40:46 +0800 [thread overview]
Message-ID: <20241216-of_core_fix-v2-7-e69b8f60da63@quicinc.com> (raw)
In-Reply-To: <20241216-of_core_fix-v2-0-e69b8f60da63@quicinc.com>
From: Zijun Hu <quic_zijuhu@quicinc.com>
For of_alias_scan():
- Do not expose it since it has no external callers.
- Correct its comments shown below:
1) Replace /* with /** to start comments since it is not a API.
2) Delete return value descriptions since it is a void function.
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
drivers/of/base.c | 5 ++---
drivers/of/of_private.h | 2 ++
drivers/of/pdt.c | 2 ++
include/linux/of.h | 1 -
4 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 969b99838655534915882abe358814d505c6f748..5485307e2a3a3d3a216d271c60bdfc346dd38460 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1806,14 +1806,13 @@ static void of_alias_add(struct alias_prop *ap, struct device_node *np,
ap->alias, ap->stem, ap->id, np);
}
-/**
+/*
* of_alias_scan - Scan all properties of the 'aliases' node
* @dt_alloc: An allocator that provides a virtual address to memory
* for storing the resulting tree
*
* The function scans all the properties of the 'aliases' node and populates
- * the global lookup table with the properties. It returns the
- * number of alias properties found, or an error code in case of failure.
+ * the global lookup table with the properties.
*/
void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align))
{
diff --git a/drivers/of/of_private.h b/drivers/of/of_private.h
index ea5a0951ec5e107bab265ab5f6c043e2bfb15ecc..3433ccd330e84fd3a4b54638e0e922069757c8f0 100644
--- a/drivers/of/of_private.h
+++ b/drivers/of/of_private.h
@@ -119,6 +119,8 @@ extern void *__unflatten_device_tree(const void *blob,
void *(*dt_alloc)(u64 size, u64 align),
bool detached);
+void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align));
+
/**
* General utilities for working with live trees.
*
diff --git a/drivers/of/pdt.c b/drivers/of/pdt.c
index 7eda43c66c916198b1c2d8fc5043fcb1edaede7a..f961aaa9b96cc4a31c39f42291e87b0007394ec5 100644
--- a/drivers/of/pdt.c
+++ b/drivers/of/pdt.c
@@ -21,6 +21,8 @@
static struct of_pdt_ops *of_pdt_prom_ops __initdata;
+void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align));
+
#if defined(CONFIG_SPARC)
unsigned int of_pdt_unique_id __initdata;
diff --git a/include/linux/of.h b/include/linux/of.h
index 2fcc12de4a9178276a24cd4d6c975495b9eb04a2..b43e8d5561332a10cee006b383d42822f28057e1 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -397,7 +397,6 @@ extern int of_phandle_iterator_args(struct of_phandle_iterator *it,
uint32_t *args,
int size);
-extern void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align));
extern int of_alias_get_id(const struct device_node *np, const char *stem);
extern int of_alias_get_highest_id(const char *stem);
--
2.34.1
prev parent reply other threads:[~2024-12-16 0:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 0:40 [PATCH v2 0/7] of: fix bugs and improve codes Zijun Hu
2024-12-16 0:40 ` [PATCH v2 1/7] of: Fix API of_find_node_opts_by_path() finding OF device node failure Zijun Hu
2024-12-16 0:40 ` [PATCH v2 2/7] of: unittest: Add a test case for API of_find_node_opts_by_path() Zijun Hu
2024-12-16 19:23 ` Rob Herring
2024-12-16 21:29 ` Rob Herring
2024-12-16 0:40 ` [PATCH v2 3/7] of: Correct child specifier used as input of the 2nd nexus node Zijun Hu
2024-12-16 0:40 ` [PATCH v2 4/7] of: Exchange implementation between of_property_present() and of_property_read_bool() Zijun Hu
2024-12-16 0:40 ` [PATCH v2 5/7] of: Fix available buffer size calculating error in API of_device_uevent_modalias() Zijun Hu
2024-12-16 0:40 ` [PATCH v2 6/7] of: Fix potential wrong MODALIAS uevent value Zijun Hu
2024-12-16 3:42 ` kernel test robot
2024-12-16 3:52 ` kernel test robot
2024-12-16 7:02 ` kernel test robot
2024-12-16 0:40 ` Zijun Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216-of_core_fix-v2-7-e69b8f60da63@quicinc.com \
--to=zijun_hu@icloud.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox