public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
	rostedt@goodmis.org, Ankur Arora <ankur.a.arora@oracle.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	"Paul E . McKenney" <paulmck@kernel.org>
Subject: [PATCH rcu v2] 3/9] sched: update __cond_resched comment about RCU quiescent states
Date: Thu, 30 Jan 2025 10:55:16 -0800	[thread overview]
Message-ID: <20250130185522.1652093-3-paulmck@kernel.org> (raw)
In-Reply-To: <9bc6e5fe-d49f-495a-9f55-537ed97a3615@paulmck-laptop>

From: Ankur Arora <ankur.a.arora@oracle.com>

Update comment in __cond_resched() clarifying how urgently needed
quiescent state are provided.

Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
 kernel/sched/core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 95e40895a519..b0f7ffcc46a6 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7281,7 +7281,7 @@ int __sched __cond_resched(void)
 		return 1;
 	}
 	/*
-	 * In preemptible kernels, ->rcu_read_lock_nesting tells the tick
+	 * In PREEMPT_RCU kernels, ->rcu_read_lock_nesting tells the tick
 	 * whether the current CPU is in an RCU read-side critical section,
 	 * so the tick can report quiescent states even for CPUs looping
 	 * in kernel context.  In contrast, in non-preemptible kernels,
@@ -7290,6 +7290,8 @@ int __sched __cond_resched(void)
 	 * RCU quiescent state.  Therefore, the following code causes
 	 * cond_resched() to report a quiescent state, but only when RCU
 	 * is in urgent need of one.
+	 * A third case, preemptible, but non-PREEMPT_RCU provides for
+	 * urgently needed quiescent states via rcu_flavor_sched_clock_irq().
 	 */
 #ifndef CONFIG_PREEMPT_RCU
 	rcu_all_qs();
-- 
2.40.1


  parent reply	other threads:[~2025-01-30 18:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16 20:13 [PATCH rcu 0/9] Lazy-preemption-related updates Paul E. McKenney
2025-01-16 20:13 ` [PATCH rcu 1/9] rcu: fix header guard for rcu_all_qs() Paul E. McKenney
2025-01-16 20:13 ` [PATCH rcu 2/9] rcu: rename PREEMPT_AUTO to PREEMPT_LAZY Paul E. McKenney
2025-01-16 20:13 ` [PATCH rcu 3/9] sched: update __cond_resched comment about RCU quiescent states Paul E. McKenney
2025-01-16 20:13 ` [PATCH rcu 4/9] rcu: handle unstable rdp in rcu_read_unlock_strict() Paul E. McKenney
2025-01-16 20:13 ` [PATCH rcu 5/9] rcu: handle quiescent states for PREEMPT_RCU=n, PREEMPT_COUNT=y Paul E. McKenney
2025-01-16 20:13 ` [PATCH rcu 6/9] osnoise: provide quiescent states Paul E. McKenney
2025-01-16 20:13 ` [PATCH rcu 7/9] rcu: limit PREEMPT_RCU configurations Paul E. McKenney
2025-01-16 20:13 ` [PATCH rcu 8/9] rcutorture: Make scenario TREE10 build CONFIG_PREEMPT_LAZY=y Paul E. McKenney
2025-01-16 20:13 ` [PATCH rcu 9/9] rcutorture: Make scenario TREE07 " Paul E. McKenney
2025-01-30 18:55 ` [PATCH rcu 0/9] Lazy-preemption-related updates Paul E. McKenney
2025-01-30 18:55   ` [PATCH rcu v2] 1/9] rcu: fix header guard for rcu_all_qs() Paul E. McKenney
2025-01-30 18:55   ` [PATCH rcu v2] 2/9] rcu: rename PREEMPT_AUTO to PREEMPT_LAZY Paul E. McKenney
2025-01-30 18:55   ` Paul E. McKenney [this message]
2025-01-30 18:55   ` [PATCH rcu v2] 4/9] rcu: handle unstable rdp in rcu_read_unlock_strict() Paul E. McKenney
2025-01-30 18:55   ` [PATCH rcu v2] 5/9] rcu: handle quiescent states for PREEMPT_RCU=n, PREEMPT_COUNT=y Paul E. McKenney
2025-01-30 18:55   ` [PATCH rcu v2] 6/9] osnoise: provide quiescent states Paul E. McKenney
2025-01-30 18:55   ` [PATCH rcu v2] 7/9] rcu: limit PREEMPT_RCU configurations Paul E. McKenney
2025-01-30 18:55   ` [PATCH rcu v2] 8/9] rcutorture: Make scenario TREE10 build CONFIG_PREEMPT_LAZY=y Paul E. McKenney
2025-01-30 18:55   ` [PATCH rcu v2] 9/9] rcutorture: Make scenario TREE07 " Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250130185522.1652093-3-paulmck@kernel.org \
    --to=paulmck@kernel.org \
    --cc=ankur.a.arora@oracle.com \
    --cc=frederic@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox