From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Li Ming <ming.li@zohomail.com>
Cc: <dave@stgolabs.net>, <dave.jiang@intel.com>,
<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
<ira.weiny@intel.com>, <dan.j.williams@intel.com>,
<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/7] cxl/memdev: cxl_memdev_ioctl() cleanup
Date: Tue, 11 Feb 2025 17:28:39 +0000 [thread overview]
Message-ID: <20250211172839.00005435@huawei.com> (raw)
In-Reply-To: <20250211075727.351895-4-ming.li@zohomail.com>
On Tue, 11 Feb 2025 15:57:23 +0800
Li Ming <ming.li@zohomail.com> wrote:
> In cxl_memdev_ioctl(), the down_read(&cxl_memdev_rwsem) and
> up_read(&cxl_memdev_rwsem) can be replaced by a
> guard(rwsem_read)(&cxl_memdev_rwsem), it helps to remove the open-coded
> up_read(&cxl_memdev_rwsem). Besides, the local var 'rc' can be also
> removed to make the code more cleaner.
>
> Signed-off-by: Li Ming <ming.li@zohomail.com>
Seems reasonable to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
next prev parent reply other threads:[~2025-02-11 17:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 7:57 [PATCH v1 0/7] Use guard() instead of rwsem locking Li Ming
2025-02-11 7:57 ` [PATCH v1 1/7] cxl/core: Use guard() to replace open-coded down_read/write() Li Ming
2025-02-11 17:26 ` Jonathan Cameron
2025-02-12 6:36 ` Li Ming
2025-02-11 7:57 ` [PATCH v1 2/7] cxl/core: cxl_mem_sanitize() cleanup Li Ming
2025-02-11 17:27 ` Jonathan Cameron
2025-02-11 7:57 ` [PATCH v1 3/7] cxl/memdev: cxl_memdev_ioctl() cleanup Li Ming
2025-02-11 17:28 ` Jonathan Cameron [this message]
2025-02-11 7:57 ` [PATCH v1 4/7] cxl/core: Use guard() to drop the goto pattern of cxl_dpa_free() Li Ming
2025-02-11 17:30 ` Jonathan Cameron
2025-02-11 7:57 ` [PATCH v1 5/7] cxl/core: Use guard() to drop goto pattern of cxl_dpa_alloc() Li Ming
2025-02-11 17:32 ` Jonathan Cameron
2025-02-11 7:57 ` [PATCH v1 6/7] cxl/region: Drop goto pattern in cxl_dax_region_alloc() Li Ming
2025-02-11 17:32 ` Jonathan Cameron
2025-02-11 7:57 ` [PATCH v1 7/7] cxl/region: Drop goto pattern of construct_region() Li Ming
2025-02-11 17:36 ` Jonathan Cameron
2025-02-11 21:24 ` Dave Jiang
2025-02-13 4:15 ` Li Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211172839.00005435@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.li@zohomail.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox