From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <leitao@debian.org>
Cc: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<dsahern@kernel.org>, <edumazet@google.com>, <horms@kernel.org>,
<kernel-team@meta.com>, <kuba@kernel.org>, <kuniyu@amazon.co.jp>,
<kuniyu@amazon.com>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<ushankar@purestorage.com>
Subject: Re: [PATCH net-next v3 3/3] arp: switch to dev_getbyhwaddr() in arp_req_set_public()
Date: Thu, 13 Feb 2025 16:45:46 +0900 [thread overview]
Message-ID: <20250213074546.15468-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250212-arm_fix_selftest-v3-3-72596cb77e44@debian.org>
From: Breno Leitao <leitao@debian.org>
Date: Wed, 12 Feb 2025 09:47:26 -0800
> The arp_req_set_public() function is called with the RTNL lock held,
> which provides enough synchronization protection. This makes the RCU
> variant of dev_getbyhwaddr() unnecessary. Switch to using the simpler
> dev_getbyhwaddr() function since we already have the required rtnl
> locking.
>
> This change helps maintain consistency in the networking code by using
> the appropriate helper function for the existing locking context.
>
> Suggested-by: Kuniyuki Iwashima <kuniyu@amazon.com>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Fixes: 941666c2e3e0 ("net: RCU conversion of dev_getbyhwaddr() and arp_ioctl()")
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
I still think patch 2 & 3 should be posted to net separately.
Documentation/process/maintainer-netdev.rst
---8<---
the ``net`` tree is for fixes to existing code already in the
mainline tree from Linus
---8<---
prev parent reply other threads:[~2025-02-13 7:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 17:47 [PATCH net-next v3 0/3] net: core: improvements to device lookup by hardware address Breno Leitao
2025-02-12 17:47 ` [PATCH net-next v3 1/3] net: document return value of dev_getbyhwaddr_rcu() Breno Leitao
2025-02-13 7:36 ` Kuniyuki Iwashima
2025-02-13 7:47 ` Kuniyuki Iwashima
2025-02-13 10:16 ` Breno Leitao
2025-02-13 10:45 ` Kuniyuki Iwashima
2025-02-12 17:47 ` [PATCH net-next v3 2/3] net: Add dev_getbyhwaddr_rtnl() helper Breno Leitao
2025-02-13 7:31 ` Kuniyuki Iwashima
2025-02-13 10:29 ` Breno Leitao
2025-02-13 10:52 ` Kuniyuki Iwashima
2025-02-13 12:29 ` Breno Leitao
2025-02-12 17:47 ` [PATCH net-next v3 3/3] arp: switch to dev_getbyhwaddr() in arp_req_set_public() Breno Leitao
2025-02-13 7:45 ` Kuniyuki Iwashima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213074546.15468-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.co.jp \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox