From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <kuniyu@amazon.com>
Cc: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<dsahern@kernel.org>, <edumazet@google.com>, <horms@kernel.org>,
<kernel-team@meta.com>, <kuba@kernel.org>, <kuniyu@amazon.co.jp>,
<leitao@debian.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<ushankar@purestorage.com>
Subject: Re: [PATCH net-next v3 1/3] net: document return value of dev_getbyhwaddr_rcu()
Date: Thu, 13 Feb 2025 16:47:48 +0900 [thread overview]
Message-ID: <20250213074748.16001-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250213073646.14847-1-kuniyu@amazon.com>
From: Kuniyuki Iwashima <kuniyu@amazon.com>
Date: Thu, 13 Feb 2025 16:36:46 +0900
> From: Breno Leitao <leitao@debian.org>
> Date: Wed, 12 Feb 2025 09:47:24 -0800
> > diff --git a/net/core/dev.c b/net/core/dev.c
> > index d5ab9a4b318ea4926c200ef20dae01eaafa18c6b..0b3480a125fcaa6f036ddf219c29fa362ea0cb29 100644
> > --- a/net/core/dev.c
> > +++ b/net/core/dev.c
> > @@ -1134,8 +1134,8 @@ int netdev_get_name(struct net *net, char *name, int ifindex)
> > * The returned device has not had its ref count increased
> > * and the caller must therefore be careful about locking
> > *
> > + * Return: pointer to the net_device, or NULL if not found
> > */
>
> I noticed here we still mention RTNL and it should be removed.
I missed this part is removed in patch 2, but the Return: part
is still duplicate.
next prev parent reply other threads:[~2025-02-13 7:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 17:47 [PATCH net-next v3 0/3] net: core: improvements to device lookup by hardware address Breno Leitao
2025-02-12 17:47 ` [PATCH net-next v3 1/3] net: document return value of dev_getbyhwaddr_rcu() Breno Leitao
2025-02-13 7:36 ` Kuniyuki Iwashima
2025-02-13 7:47 ` Kuniyuki Iwashima [this message]
2025-02-13 10:16 ` Breno Leitao
2025-02-13 10:45 ` Kuniyuki Iwashima
2025-02-12 17:47 ` [PATCH net-next v3 2/3] net: Add dev_getbyhwaddr_rtnl() helper Breno Leitao
2025-02-13 7:31 ` Kuniyuki Iwashima
2025-02-13 10:29 ` Breno Leitao
2025-02-13 10:52 ` Kuniyuki Iwashima
2025-02-13 12:29 ` Breno Leitao
2025-02-12 17:47 ` [PATCH net-next v3 3/3] arp: switch to dev_getbyhwaddr() in arp_req_set_public() Breno Leitao
2025-02-13 7:45 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213074748.16001-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.co.jp \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox