From: "José Expósito" <jose.exposito89@gmail.com>
To: louis.chauvet@bootlin.com
Cc: hamohammed.sa@gmail.com, simona@ffwll.ch, melissa.srw@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"José Expósito" <jose.exposito89@gmail.com>
Subject: [PATCH v3 00/14] drm/vkms: Allow to configure device
Date: Mon, 17 Feb 2025 11:01:06 +0100 [thread overview]
Message-ID: <20250217100120.7620-1-jose.exposito89@gmail.com> (raw)
Hi everyone,
In preparation for ConfigFS support, a flexible way to configure VKMS device(s)
is required.
This series adds the required APIs to create a configuration, the code changes
required to apply it and KUnit test validating the changes.
Louis Chauvet and I are working on ConfigFS support. In this series I tried to
merge his changes [1] with mine [2].
I kept his Signed-off-by to reflect that, even if I show up as the author of
some/most of the patches, this was a joint effort.
I'll send the ConfigFS code [3] and its IGT tests [4] code this week.
Meanwhile, the IGT tests also exercise this series and can be used for
additional test coverage.
Best wishes,
José Expósito
[1] https://patchwork.kernel.org/project/dri-devel/cover/20250121-google-remove-crtc-index-from-parameter-v3-0-cac00a3c3544@bootlin.com/
[2] https://patchwork.kernel.org/project/dri-devel/cover/20240813105134.17439-1-jose.exposito89@gmail.com/
[3] https://github.com/JoseExposito/linux/commits/patch-vkms-configfs/
[4] https://gitlab.freedesktop.org/jexposit/igt-gpu-tools/-/commits/vkms-configfs
Changes in v3:
- Applied review comments by Louis Chauvet: (thanks!!)
- Moved drm_vblank_init(..., vkms_config_get_num_crtcs()) to a different patch
- Improved error handling in vkms_config_*_attach_*() functions
- Fixed compilation errors when CONFIG_DRM_VKMS_KUNIT_TEST=m
- Used for_each iterators in vkms_config_test_default_config(). A leftover
from the removed connector hot-add code
- Validated that vkms_config.dev wasn't NULL before calling drm_info()
- Kept vkms_device.config as a const pointer (at the cost of casting in
list_count_nodes())
- Renamed "CONFIG_DRM_VKMS_KUNIT_TESTS" to "CONFIG_DRM_VKMS_KUNIT_TEST" for
consistency with other options
- Rebased on top of drm-misc-next
- Link to v2: https://lore.kernel.org/all/20250211110912.15409-1-jose.exposito89@gmail.com/
Changes in v2:
- Applied review comments by Louis Chauvet:
- Added Co-developped-by tags where required
- Split the first patch in 2: vkms_connector.h/c creation and struct
vkms_connector creation
- Fixes a user after free/double free bug. The bug is already present
in drm-misc-next and the fix could be merged independently
- Implemented for_each macros for the config
- Other naming fixes
- Link to v1: https://lore.kernel.org/all/20250129110059.12199-1-jose.exposito89@gmail.com/
José Expósito (13):
drm/vkms: Extract vkms_connector header
drm/vkms: Create vkms_connector struct
drm/vkms: Add KUnit test scaffolding
drm/vkms: Extract vkms_config header
drm/vkms: Move default_config creation to its own function
drm/vkms: Set device name from vkms_config
drm/vkms: Allow to configure multiple planes
drm/vkms: Allow to configure multiple CRTCs
drm/vkms: Allow to attach planes and CRTCs
drm/vkms: Allow to configure multiple encoders
drm/vkms: Allow to attach encoders and CRTCs
drm/vkms: Allow to configure multiple connectors
drm/vkms: Allow to attach connectors and encoders
Louis Chauvet (1):
drm/vkms: Add a validation function for VKMS configuration
.clang-format | 7 +
drivers/gpu/drm/vkms/Kconfig | 15 +
drivers/gpu/drm/vkms/Makefile | 5 +-
drivers/gpu/drm/vkms/tests/.kunitconfig | 4 +
drivers/gpu/drm/vkms/tests/Makefile | 3 +
drivers/gpu/drm/vkms/tests/vkms_config_test.c | 880 ++++++++++++++++++
drivers/gpu/drm/vkms/vkms_config.c | 640 +++++++++++++
drivers/gpu/drm/vkms/vkms_config.h | 437 +++++++++
drivers/gpu/drm/vkms/vkms_connector.c | 61 ++
drivers/gpu/drm/vkms/vkms_connector.h | 26 +
drivers/gpu/drm/vkms/vkms_drv.c | 45 +-
drivers/gpu/drm/vkms/vkms_drv.h | 17 +-
drivers/gpu/drm/vkms/vkms_output.c | 176 ++--
13 files changed, 2175 insertions(+), 141 deletions(-)
create mode 100644 drivers/gpu/drm/vkms/tests/.kunitconfig
create mode 100644 drivers/gpu/drm/vkms/tests/Makefile
create mode 100644 drivers/gpu/drm/vkms/tests/vkms_config_test.c
create mode 100644 drivers/gpu/drm/vkms/vkms_config.c
create mode 100644 drivers/gpu/drm/vkms/vkms_config.h
create mode 100644 drivers/gpu/drm/vkms/vkms_connector.c
create mode 100644 drivers/gpu/drm/vkms/vkms_connector.h
--
2.48.1
next reply other threads:[~2025-02-17 10:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 10:01 José Expósito [this message]
2025-02-17 10:01 ` [PATCH v3 01/14] drm/vkms: Extract vkms_connector header José Expósito
2025-02-17 10:01 ` [PATCH v3 02/14] drm/vkms: Create vkms_connector struct José Expósito
2025-02-17 10:01 ` [PATCH v3 03/14] drm/vkms: Add KUnit test scaffolding José Expósito
2025-02-17 10:01 ` [PATCH v3 04/14] drm/vkms: Extract vkms_config header José Expósito
2025-02-17 10:01 ` [PATCH v3 05/14] drm/vkms: Move default_config creation to its own function José Expósito
2025-02-17 10:01 ` [PATCH v3 06/14] drm/vkms: Set device name from vkms_config José Expósito
2025-02-17 10:01 ` [PATCH v3 07/14] drm/vkms: Add a validation function for VKMS configuration José Expósito
2025-02-17 10:01 ` [PATCH v3 08/14] drm/vkms: Allow to configure multiple planes José Expósito
2025-02-17 15:45 ` Louis Chauvet
2025-02-17 16:34 ` José Expósito
2025-02-17 17:06 ` Louis Chauvet
2025-02-17 10:01 ` [PATCH v3 09/14] drm/vkms: Allow to configure multiple CRTCs José Expósito
2025-02-17 15:45 ` Louis Chauvet
2025-02-17 10:01 ` [PATCH v3 10/14] drm/vkms: Allow to attach planes and CRTCs José Expósito
2025-02-17 15:45 ` Louis Chauvet
2025-02-17 10:01 ` [PATCH v3 11/14] drm/vkms: Allow to configure multiple encoders José Expósito
2025-02-17 15:45 ` Louis Chauvet
2025-02-17 10:01 ` [PATCH v3 12/14] drm/vkms: Allow to attach encoders and CRTCs José Expósito
2025-02-17 15:45 ` Louis Chauvet
2025-02-17 10:01 ` [PATCH v3 13/14] drm/vkms: Allow to configure multiple connectors José Expósito
2025-02-17 15:45 ` Louis Chauvet
2025-02-18 10:11 ` José Expósito
2025-02-17 10:01 ` [PATCH v3 14/14] drm/vkms: Allow to attach connectors and encoders José Expósito
2025-02-17 15:45 ` Louis Chauvet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217100120.7620-1-jose.exposito89@gmail.com \
--to=jose.exposito89@gmail.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=melissa.srw@gmail.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox