Re: [PATCH v3 11/14] drm/vkms: Allow to configure multiple encoders

[Louis Chauvet <louis.chauvet@bootlin.com>]

Le 17/02/2025 à 11:01, José Expósito a écrit :
> Add a list of encoders to vkms_config and helper functions to add and
> remove as many encoders as wanted.
> 
> For backwards compatibility, add one encoder to the default
> configuration.
> 
> A future patch will allow to attach encoders and CRTCs, but for the
> moment there are no changes in the way the output is configured.
> 
> Co-developed-by: Louis Chauvet <louis.chauvet@bootlin.com>
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
> ---
>   .clang-format                                 |  1 +
>   drivers/gpu/drm/vkms/tests/vkms_config_test.c | 73 +++++++++++++++++++
>   drivers/gpu/drm/vkms/vkms_config.c            | 54 ++++++++++++++
>   drivers/gpu/drm/vkms/vkms_config.h            | 46 ++++++++++++
>   4 files changed, 174 insertions(+)
> 
> diff --git a/.clang-format b/.clang-format
> index 6f944fa39841..c355a2f58eed 100644
> --- a/.clang-format
> +++ b/.clang-format
> @@ -691,6 +691,7 @@ ForEachMacros:
>     - 'v4l2_m2m_for_each_src_buf_safe'
>     - 'virtio_device_for_each_vq'
>     - 'vkms_config_for_each_crtc'
> +  - 'vkms_config_for_each_encoder'
>     - 'vkms_config_for_each_plane'
>     - 'vkms_config_plane_for_each_possible_crtc'
>     - 'while_for_each_ftrace_op'
> diff --git a/drivers/gpu/drm/vkms/tests/vkms_config_test.c b/drivers/gpu/drm/vkms/tests/vkms_config_test.c
> index b7a0a8202819..92926972c64c 100644
> --- a/drivers/gpu/drm/vkms/tests/vkms_config_test.c
> +++ b/drivers/gpu/drm/vkms/tests/vkms_config_test.c
> @@ -26,6 +26,7 @@ static void vkms_config_test_empty_config(struct kunit *test)
>   
>   	KUNIT_EXPECT_TRUE(test, list_empty(&config->planes));
>   	KUNIT_EXPECT_TRUE(test, list_empty(&config->crtcs));
> +	KUNIT_EXPECT_TRUE(test, list_empty(&config->encoders));

Ditto, with this modification:
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com