* [PATCH] binder: remove unneeded <linux/export.h> inclusion from binder_internal.h
@ 2025-02-17 11:27 Masahiro Yamada
2025-02-24 23:26 ` Todd Kjos
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2025-02-17 11:27 UTC (permalink / raw)
To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner, Carlos Llamas,
Suren Baghdasaryan
Cc: linux-kernel, Masahiro Yamada, Christian Brauner
binder_internal.h is included only in the following two C files:
$ git grep binder_internal.h
drivers/android/binder.c:#include "binder_internal.h"
drivers/android/binderfs.c:#include "binder_internal.h"
Neither of these files use the EXPORT_SYMBOL macro, so including
<linux/export.h> is unnecessary.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
drivers/android/binder_internal.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/android/binder_internal.h b/drivers/android/binder_internal.h
index e4eb8357989c..6a66c9769c6c 100644
--- a/drivers/android/binder_internal.h
+++ b/drivers/android/binder_internal.h
@@ -3,7 +3,6 @@
#ifndef _LINUX_BINDER_INTERNAL_H
#define _LINUX_BINDER_INTERNAL_H
-#include <linux/export.h>
#include <linux/fs.h>
#include <linux/list.h>
#include <linux/miscdevice.h>
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] binder: remove unneeded <linux/export.h> inclusion from binder_internal.h
2025-02-17 11:27 [PATCH] binder: remove unneeded <linux/export.h> inclusion from binder_internal.h Masahiro Yamada
@ 2025-02-24 23:26 ` Todd Kjos
0 siblings, 0 replies; 2+ messages in thread
From: Todd Kjos @ 2025-02-24 23:26 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner, Carlos Llamas,
Suren Baghdasaryan, linux-kernel, Christian Brauner
On Mon, Feb 17, 2025 at 3:28 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> binder_internal.h is included only in the following two C files:
>
> $ git grep binder_internal.h
> drivers/android/binder.c:#include "binder_internal.h"
> drivers/android/binderfs.c:#include "binder_internal.h"
>
> Neither of these files use the EXPORT_SYMBOL macro, so including
> <linux/export.h> is unnecessary.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Todd Kjos <tkjos@google.com>
> ---
>
> drivers/android/binder_internal.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/android/binder_internal.h b/drivers/android/binder_internal.h
> index e4eb8357989c..6a66c9769c6c 100644
> --- a/drivers/android/binder_internal.h
> +++ b/drivers/android/binder_internal.h
> @@ -3,7 +3,6 @@
> #ifndef _LINUX_BINDER_INTERNAL_H
> #define _LINUX_BINDER_INTERNAL_H
>
> -#include <linux/export.h>
> #include <linux/fs.h>
> #include <linux/list.h>
> #include <linux/miscdevice.h>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-24 23:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-17 11:27 [PATCH] binder: remove unneeded <linux/export.h> inclusion from binder_internal.h Masahiro Yamada
2025-02-24 23:26 ` Todd Kjos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox