[PATCH 0/2] Add TB daughter board support

[PATCH 0/2] Add TB daughter board support

[niravkumar.l.rabara]

From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>

Agilex5 SoCFPGA devkit supports a separate test daughter board(TB).
Document TB daughter board compatible string and add board file.

Niravkumar L Rabara (2):
  dt-bindings: intel: document Agilex5 TB daughter board
  arm64: dts: socfpga: agilex5: add TB daughter board support

 .../bindings/arm/intel,socfpga.yaml           |  1 +
 arch/arm64/boot/dts/intel/Makefile            |  1 +
 .../dts/intel/socfpga_agilex5_socdk_tb.dts    | 27 +++++++++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tb.dts

-- 
2.25.1

[PATCH 1/2] dt-bindings: intel: document Agilex5 TB daughter board

[niravkumar.l.rabara]

From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>

Agilex5 devkit supports a separate daughter board TB.
Document Agilex5 TB board compatible.

Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
---
 Documentation/devicetree/bindings/arm/intel,socfpga.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/intel,socfpga.yaml b/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
index 2ee0c740eb56..c41a6d021a06 100644
--- a/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
+++ b/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
@@ -25,6 +25,7 @@ properties:
         items:
           - enum:
               - intel,socfpga-agilex5-socdk
+              - intel,socfpga-agilex5-socdk-tb
           - const: intel,socfpga-agilex5
 
 additionalProperties: true
-- 
2.25.1

[PATCH 2/2] arm64: dts: socfpga: agilex5: add TB daughter board support

[niravkumar.l.rabara]

From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>

The Agilex5 devkit supports a separate TB daughter board.
This board includes a SPI EEPROM and different LED pin configuration
compared to the default daughter board for the Agilex5 devkit.

Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
---
 arch/arm64/boot/dts/intel/Makefile            |  1 +
 .../dts/intel/socfpga_agilex5_socdk_tb.dts    | 27 +++++++++++++++++++
 2 files changed, 28 insertions(+)
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tb.dts

diff --git a/arch/arm64/boot/dts/intel/Makefile b/arch/arm64/boot/dts/intel/Makefile
index d39cfb723f5b..4c977b0aaf9b 100644
--- a/arch/arm64/boot/dts/intel/Makefile
+++ b/arch/arm64/boot/dts/intel/Makefile
@@ -3,5 +3,6 @@ dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex_n6000.dtb \
 				socfpga_agilex_socdk.dtb \
 				socfpga_agilex_socdk_nand.dtb \
 				socfpga_agilex5_socdk.dtb \
+				socfpga_agilex5_socdk_tb.dtb \
 				socfpga_n5x_socdk.dtb
 dtb-$(CONFIG_ARCH_KEEMBAY) += keembay-evm.dtb
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tb.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tb.dts
new file mode 100644
index 000000000000..3cda73e12f38
--- /dev/null
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tb.dts
@@ -0,0 +1,27 @@
+// SPDX-License-Identifier:     GPL-2.0
+/*
+ * Copyright (C) 2025, Altera Corporation
+ */
+#include "socfpga_agilex5_socdk.dts"
+
+/ {
+	model = "SoCFPGA Agilex5 SoCDK - TB";
+	compatible = "intel,socfpga-agilex5-socdk-tb", "intel,socfpga-agilex5";
+
+	leds {
+		led-0 {
+			label = "hps_led0";
+			gpios = <&portb 12 GPIO_ACTIVE_HIGH>;
+		};
+	};
+};
+
+&spi0 {
+	status = "okay";
+
+	spidev@0{
+		compatible = "rohm,dh2228fv";
+		reg = <0>;
+		spi-max-frequency = <10000000>;
+	};
+};
-- 
2.25.1

Re: [PATCH 2/2] arm64: dts: socfpga: agilex5: add TB daughter board support

[Krzysztof Kozlowski]

On 18/02/2025 10:44, niravkumar.l.rabara@intel.com wrote:
> @@ -0,0 +1,27 @@
> +// SPDX-License-Identifier:     GPL-2.0
> +/*
> + * Copyright (C) 2025, Altera Corporation
> + */
> +#include "socfpga_agilex5_socdk.dts"
> +
> +/ {
> +	model = "SoCFPGA Agilex5 SoCDK - TB";
> +	compatible = "intel,socfpga-agilex5-socdk-tb", "intel,socfpga-agilex5";
> +
> +	leds {
> +		led-0 {
> +			label = "hps_led0";
> +			gpios = <&portb 12 GPIO_ACTIVE_HIGH>;
> +		};
> +	};
> +};
> +
> +&spi0 {
> +	status = "okay";
> +
> +	spidev@0{
> +		compatible = "rohm,dh2228fv";

NAK. You do not have such device there.

Also, follow DTS coding style and fix all white space issues here.

Best regards,
Krzysztof