[PATCH 0/4] platform-x86: Use *-y instead of *-objs in Makefiles

[PATCH 0/4] platform-x86: Use *-y instead of *-objs in Makefiles

[Kurt Borja]

Hi all,

According to documentation, the `-objs` suffix is reserved to user-space
and host programs. The `-y` suffix should be used for composite kernel
modules and drivers.

[1] https://elixir.bootlin.com/linux/v6.14-rc3/source/Documentation/kbuild/makefiles.rst#L153

Based on pdx86/fixes branch.

Kurt Borja (4):
  platform/x86: dell: dell-wmi-sysman: Use *-y instead of *-objs in
    Makefile
  platform/x86: amd: Use *-y instead of *-objs in Makefiles
  platform/x86: hp: Use *-y instead of *-objs in Makefile
  platform/x86: intel: Use *-y instead of *-objs in Makefile

 drivers/platform/x86/amd/Makefile                  | 2 +-
 drivers/platform/x86/amd/hsmp/Makefile             | 6 +++---
 drivers/platform/x86/amd/pmc/Makefile              | 6 +++---
 drivers/platform/x86/amd/pmf/Makefile              | 8 ++++----
 drivers/platform/x86/dell/dell-wmi-sysman/Makefile | 2 +-
 drivers/platform/x86/hp/hp-bioscfg/Makefile        | 2 +-
 drivers/platform/x86/intel/ifs/Makefile            | 2 +-
 7 files changed, 14 insertions(+), 14 deletions(-)


base-commit: a787ab73e2e43c0a3df10bc8d9b9b7a679129d49
-- 
 ~ Kurt

[PATCH 1/4] platform/x86: dell: dell-wmi-sysman: Use *-y instead of *-objs in Makefile

[Kurt Borja]

The `objs` suffix is reserved for user-space tools. Use the `y` suffix
instead, which is usually used for kernel drivers.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
 drivers/platform/x86/dell/dell-wmi-sysman/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/Makefile b/drivers/platform/x86/dell/dell-wmi-sysman/Makefile
index 825fb2fbeea8..0a6df449e222 100644
--- a/drivers/platform/x86/dell/dell-wmi-sysman/Makefile
+++ b/drivers/platform/x86/dell/dell-wmi-sysman/Makefile
@@ -1,5 +1,5 @@
 obj-$(CONFIG_DELL_WMI_SYSMAN)  += dell-wmi-sysman.o
-dell-wmi-sysman-objs := 	sysman.o		\
+dell-wmi-sysman-y :=		sysman.o		\
 				enum-attributes.o	\
 				int-attributes.o	\
 				string-attributes.o	\
-- 
2.48.1

Re: [PATCH 1/4] platform/x86: dell: dell-wmi-sysman: Use *-y instead of *-objs in Makefile

[Andy Shevchenko]

On Tue, Feb 18, 2025 at 02:41:08PM -0500, Kurt Borja wrote:
> The `objs` suffix is reserved for user-space tools. Use the `y` suffix
> instead, which is usually used for kernel drivers.

I haven't received a cover letter. Please, make sure when you send a version of
the few patches under the same thread you add a cover letter. You may consider
using my "smart" (not really) script [1] to send patch series to LKML.

[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/4] platform/x86: dell: dell-wmi-sysman: Use *-y instead of *-objs in Makefile

[Kurt Borja]

On Wed Feb 19, 2025 at 9:35 AM -05, Andy Shevchenko wrote:
> On Tue, Feb 18, 2025 at 02:41:08PM -0500, Kurt Borja wrote:
>> The `objs` suffix is reserved for user-space tools. Use the `y` suffix
>> instead, which is usually used for kernel drivers.
>
> I haven't received a cover letter. Please, make sure when you send a version of
> the few patches under the same thread you add a cover letter. You may consider
> using my "smart" (not really) script [1] to send patch series to LKML.

Hi Andy,

Yes, I messed up the Cc list.

>
> [1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

Thank you very much!! I'm using that from now on :)

-- 
 ~ Kurt

[PATCH 2/4] platform/x86: amd: Use *-y instead of *-objs in Makefiles

[Kurt Borja]

The `objs` suffix is reserved for user-space tools. Use the `y` suffix
instead, which is usually used for kernel drivers.

While at it, fix alignment in AMD PMC and PMF Makefiles.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
 drivers/platform/x86/amd/Makefile      | 2 +-
 drivers/platform/x86/amd/hsmp/Makefile | 6 +++---
 drivers/platform/x86/amd/pmc/Makefile  | 6 +++---
 drivers/platform/x86/amd/pmf/Makefile  | 8 ++++----
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/platform/x86/amd/Makefile b/drivers/platform/x86/amd/Makefile
index 56f62fc9c97b..c6c40bdcbded 100644
--- a/drivers/platform/x86/amd/Makefile
+++ b/drivers/platform/x86/amd/Makefile
@@ -5,7 +5,7 @@
 #
 
 obj-$(CONFIG_AMD_3D_VCACHE)	+= amd_3d_vcache.o
-amd_3d_vcache-objs		:= x3d_vcache.o
+amd_3d_vcache-y			:= x3d_vcache.o
 obj-$(CONFIG_AMD_PMC)		+= pmc/
 obj-$(CONFIG_AMD_HSMP)		+= hsmp/
 obj-$(CONFIG_AMD_PMF)		+= pmf/
diff --git a/drivers/platform/x86/amd/hsmp/Makefile b/drivers/platform/x86/amd/hsmp/Makefile
index 3175d8885e87..0759bbcd13f6 100644
--- a/drivers/platform/x86/amd/hsmp/Makefile
+++ b/drivers/platform/x86/amd/hsmp/Makefile
@@ -5,8 +5,8 @@
 #
 
 obj-$(CONFIG_AMD_HSMP)			+= hsmp_common.o
-hsmp_common-objs			:= hsmp.o
+hsmp_common-y				:= hsmp.o
 obj-$(CONFIG_AMD_HSMP_PLAT)		+= amd_hsmp.o
-amd_hsmp-objs				:= plat.o
+amd_hsmp-y				:= plat.o
 obj-$(CONFIG_AMD_HSMP_ACPI)		+= hsmp_acpi.o
-hsmp_acpi-objs				:= acpi.o
+hsmp_acpi-y				:= acpi.o
diff --git a/drivers/platform/x86/amd/pmc/Makefile b/drivers/platform/x86/amd/pmc/Makefile
index 255d94ddf999..bb6905c4cae9 100644
--- a/drivers/platform/x86/amd/pmc/Makefile
+++ b/drivers/platform/x86/amd/pmc/Makefile
@@ -4,6 +4,6 @@
 # AMD Power Management Controller Driver
 #
 
-amd-pmc-objs := pmc.o pmc-quirks.o mp1_stb.o
-obj-$(CONFIG_AMD_PMC) += amd-pmc.o
-amd-pmc-$(CONFIG_AMD_MP2_STB) += mp2_stb.o
+obj-$(CONFIG_AMD_PMC)			+= amd-pmc.o
+amd-pmc-y				:= pmc.o pmc-quirks.o mp1_stb.o
+amd-pmc-$(CONFIG_AMD_MP2_STB)		+= mp2_stb.o
diff --git a/drivers/platform/x86/amd/pmf/Makefile b/drivers/platform/x86/amd/pmf/Makefile
index 6b26e48ce8ad..5978464e0eb7 100644
--- a/drivers/platform/x86/amd/pmf/Makefile
+++ b/drivers/platform/x86/amd/pmf/Makefile
@@ -4,7 +4,7 @@
 # AMD Platform Management Framework
 #
 
-obj-$(CONFIG_AMD_PMF) += amd-pmf.o
-amd-pmf-objs := core.o acpi.o sps.o \
-		auto-mode.o cnqf.o \
-		tee-if.o spc.o
+obj-$(CONFIG_AMD_PMF)		+= amd-pmf.o
+amd-pmf-y 			:= core.o acpi.o sps.o \
+				   auto-mode.o cnqf.o \
+				   tee-if.o spc.o
-- 
2.48.1

[PATCH 3/4] platform/x86: hp: Use *-y instead of *-objs in Makefile

[Kurt Borja]

The `objs` suffix is reserved for user-space tools. Use the `y` suffix
instead, which is usually used for kernel drivers.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
 drivers/platform/x86/hp/hp-bioscfg/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/hp/hp-bioscfg/Makefile b/drivers/platform/x86/hp/hp-bioscfg/Makefile
index 67be0d917753..7d23649b34dc 100644
--- a/drivers/platform/x86/hp/hp-bioscfg/Makefile
+++ b/drivers/platform/x86/hp/hp-bioscfg/Makefile
@@ -1,6 +1,6 @@
 obj-$(CONFIG_HP_BIOSCFG) := hp-bioscfg.o
 
-hp-bioscfg-objs := bioscfg.o	\
+hp-bioscfg-y := bioscfg.o	\
 	biosattr-interface.o	\
 	enum-attributes.o	\
 	int-attributes.o	\
-- 
2.48.1

[PATCH 4/4] platform/x86: intel: Use *-y instead of *-objs in Makefile

[Kurt Borja]

The `objs` suffix is reserved for user-space tools. Use the `y` suffix
instead, which is usually used for kernel drivers.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
 drivers/platform/x86/intel/ifs/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel/ifs/Makefile b/drivers/platform/x86/intel/ifs/Makefile
index 30f035ef5581..c3e417bce9b6 100644
--- a/drivers/platform/x86/intel/ifs/Makefile
+++ b/drivers/platform/x86/intel/ifs/Makefile
@@ -1,3 +1,3 @@
 obj-$(CONFIG_INTEL_IFS)		+= intel_ifs.o
 
-intel_ifs-objs			:= core.o load.o runtest.o sysfs.o
+intel_ifs-y			:= core.o load.o runtest.o sysfs.o
-- 
2.48.1

Re: [PATCH 4/4] platform/x86: intel: Use *-y instead of *-objs in Makefile

[Joseph, Jithu]

On 2/18/2025 11:41 AM, Kurt Borja wrote:
> The `objs` suffix is reserved for user-space tools. Use the `y` suffix
> instead, which is usually used for kernel drivers.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
>  drivers/platform/x86/intel/ifs/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks good to me (and verified that driver is getting built)

Reviewed-by: Jithu Joseph <jithu.joseph@intel.com>

> 
> diff --git a/drivers/platform/x86/intel/ifs/Makefile b/drivers/platform/x86/intel/ifs/Makefile
> index 30f035ef5581..c3e417bce9b6 100644
> --- a/drivers/platform/x86/intel/ifs/Makefile
> +++ b/drivers/platform/x86/intel/ifs/Makefile
> @@ -1,3 +1,3 @@
>  obj-$(CONFIG_INTEL_IFS)		+= intel_ifs.o
>  
> -intel_ifs-objs			:= core.o load.o runtest.o sysfs.o
> +intel_ifs-y			:= core.o load.o runtest.o sysfs.o


Thanks
Jithu

Re: [PATCH 4/4] platform/x86: intel: Use *-y instead of *-objs in Makefile

[Andy Shevchenko]

On Tue, Feb 18, 2025 at 02:41:11PM -0500, Kurt Borja wrote:
> The `objs` suffix is reserved for user-space tools. Use the `y` suffix
> instead, which is usually used for kernel drivers.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

for all 4.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/4] platform-x86: Use *-y instead of *-objs in Makefiles

[Ilpo Järvinen]

On Tue, 18 Feb 2025 14:41:07 -0500, Kurt Borja wrote:

> According to documentation, the `-objs` suffix is reserved to user-space
> and host programs. The `-y` suffix should be used for composite kernel
> modules and drivers.
> 
> [1] https://elixir.bootlin.com/linux/v6.14-rc3/source/Documentation/kbuild/makefiles.rst#L153
> 
> Based on pdx86/fixes branch.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/4] platform/x86: dell: dell-wmi-sysman: Use *-y instead of *-objs in Makefile
      commit: 363171c96a15f558cd622e10ea100c505132f7b8
[2/4] platform/x86: amd: Use *-y instead of *-objs in Makefiles
      commit: cfba129ad2775b6ed1f209367905ddb8c9964bf5
[3/4] platform/x86: hp: Use *-y instead of *-objs in Makefile
      commit: f0ea699b1816ebed6de9aa013387622b0f73f31b
[4/4] platform/x86: intel: Use *-y instead of *-objs in Makefile
      commit: 677fb7b0699dde2609d93eb57863c8d493e673ee

--
 i.