[PATCH] iio: industrialio-trigger: Fix typos in comments

[PATCH] iio: industrialio-trigger: Fix typos in comments

[Suraj Patil]

Fixed multiple occurrences of 'reenable' to 're-enable' in comments.

Signed-off-by: Suraj Patil <your-email@example.com>
Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
---
 drivers/iio/industrialio-trigger.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
index 54416a384232..21688cd348c6 100644
--- a/drivers/iio/industrialio-trigger.c
+++ b/drivers/iio/industrialio-trigger.c
@@ -162,11 +162,11 @@ static void iio_reenable_work_fn(struct work_struct *work)
 	 * This 'might' occur after the trigger state is set to disabled -
 	 * in that case the driver should skip reenabling.
 	 */
-	trig->ops->reenable(trig);
+	trig->ops->re-enable(trig);
 }
 
 /*
- * In general, reenable callbacks may need to sleep and this path is
+ * In general, re-enable callbacks may need to sleep and this path is
  * not performance sensitive, so just queue up a work item
  * to reneable the trigger for us.
  *
@@ -175,14 +175,14 @@ static void iio_reenable_work_fn(struct work_struct *work)
  *    the final decrement is still in this interrupt.
  * 2) The trigger has been removed, but one last interrupt gets through.
  *
- * For (1) we must call reenable, but not in atomic context.
+ * For (1) we must call re-enable, but not in atomic context.
  * For (2) it should be safe to call reenanble, if drivers never blindly
- * reenable after state is off.
+ * re-enable after state is off.
  */
 static void iio_trigger_notify_done_atomic(struct iio_trigger *trig)
 {
 	if (atomic_dec_and_test(&trig->use_count) && trig->ops &&
-	    trig->ops->reenable)
+	    trig->ops->re-enable)
 		schedule_work(&trig->reenable_work);
 }
 
@@ -243,8 +243,8 @@ EXPORT_SYMBOL(iio_trigger_poll_nested);
 void iio_trigger_notify_done(struct iio_trigger *trig)
 {
 	if (atomic_dec_and_test(&trig->use_count) && trig->ops &&
-	    trig->ops->reenable)
-		trig->ops->reenable(trig);
+	    trig->ops->re-enable)
+		trig->ops->re-enable(trig);
 }
 EXPORT_SYMBOL(iio_trigger_notify_done);
 
-- 
2.43.0

Re: [PATCH] iio: industrialio-trigger: Fix typos in comments

[kernel test robot]

Hi Suraj,

kernel test robot noticed the following build errors:

[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linus/master v6.14-rc6 next-20250312]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Suraj-Patil/iio-industrialio-trigger-Fix-typos-in-comments/20250312-000420
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20250311155927.467523-1-surajpatil522%40gmail.com
patch subject: [PATCH] iio: industrialio-trigger: Fix typos in comments
config: csky-randconfig-002-20250313 (https://download.01.org/0day-ci/archive/20250313/202503130826.WiaC6K1E-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250313/202503130826.WiaC6K1E-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503130826.WiaC6K1E-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/iio/industrialio-trigger.c: In function 'iio_reenable_work_fn':
>> drivers/iio/industrialio-trigger.c:165:18: error: 'const struct iio_trigger_ops' has no member named 're'
     165 |         trig->ops->re-enable(trig);
         |                  ^~
>> drivers/iio/industrialio-trigger.c:165:23: error: implicit declaration of function 'enable'; did you mean 'enable_nmi'? [-Wimplicit-function-declaration]
     165 |         trig->ops->re-enable(trig);
         |                       ^~~~~~
         |                       enable_nmi
   drivers/iio/industrialio-trigger.c: In function 'iio_trigger_notify_done_atomic':
   drivers/iio/industrialio-trigger.c:185:22: error: 'const struct iio_trigger_ops' has no member named 're'
     185 |             trig->ops->re-enable)
         |                      ^~
>> drivers/iio/industrialio-trigger.c:185:27: error: 'enable' undeclared (first use in this function)
     185 |             trig->ops->re-enable)
         |                           ^~~~~~
   drivers/iio/industrialio-trigger.c:185:27: note: each undeclared identifier is reported only once for each function it appears in
   drivers/iio/industrialio-trigger.c: In function 'iio_trigger_notify_done':
   drivers/iio/industrialio-trigger.c:246:22: error: 'const struct iio_trigger_ops' has no member named 're'
     246 |             trig->ops->re-enable)
         |                      ^~
   drivers/iio/industrialio-trigger.c:246:27: error: 'enable' undeclared (first use in this function)
     246 |             trig->ops->re-enable)
         |                           ^~~~~~
   drivers/iio/industrialio-trigger.c:247:26: error: 'const struct iio_trigger_ops' has no member named 're'
     247 |                 trig->ops->re-enable(trig);
         |                          ^~


vim +165 drivers/iio/industrialio-trigger.c

   155	
   156	static void iio_reenable_work_fn(struct work_struct *work)
   157	{
   158		struct iio_trigger *trig = container_of(work, struct iio_trigger,
   159							reenable_work);
   160	
   161		/*
   162		 * This 'might' occur after the trigger state is set to disabled -
   163		 * in that case the driver should skip reenabling.
   164		 */
 > 165		trig->ops->re-enable(trig);
   166	}
   167	
   168	/*
   169	 * In general, re-enable callbacks may need to sleep and this path is
   170	 * not performance sensitive, so just queue up a work item
   171	 * to reneable the trigger for us.
   172	 *
   173	 * Races that can cause this.
   174	 * 1) A handler occurs entirely in interrupt context so the counter
   175	 *    the final decrement is still in this interrupt.
   176	 * 2) The trigger has been removed, but one last interrupt gets through.
   177	 *
   178	 * For (1) we must call re-enable, but not in atomic context.
   179	 * For (2) it should be safe to call reenanble, if drivers never blindly
   180	 * re-enable after state is off.
   181	 */
   182	static void iio_trigger_notify_done_atomic(struct iio_trigger *trig)
   183	{
   184		if (atomic_dec_and_test(&trig->use_count) && trig->ops &&
 > 185		    trig->ops->re-enable)
   186			schedule_work(&trig->reenable_work);
   187	}
   188	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH] iio: industrialio-trigger: Fix typos in comments

[kernel test robot]

Hi Suraj,

kernel test robot noticed the following build errors:

[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linus/master v6.14-rc6 next-20250312]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Suraj-Patil/iio-industrialio-trigger-Fix-typos-in-comments/20250312-000420
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20250311155927.467523-1-surajpatil522%40gmail.com
patch subject: [PATCH] iio: industrialio-trigger: Fix typos in comments
config: hexagon-randconfig-002-20250313 (https://download.01.org/0day-ci/archive/20250313/202503130901.12r9Jl8B-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project e15545cad8297ec7555f26e5ae74a9f0511203e7)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250313/202503130901.12r9Jl8B-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503130901.12r9Jl8B-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/iio/industrialio-trigger.c:165:13: error: no member named 're' in 'struct iio_trigger_ops'
     165 |         trig->ops->re-enable(trig);
         |         ~~~~~~~~~  ^
>> drivers/iio/industrialio-trigger.c:165:16: error: call to undeclared function 'enable'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     165 |         trig->ops->re-enable(trig);
         |                       ^
   drivers/iio/industrialio-trigger.c:185:17: error: no member named 're' in 'struct iio_trigger_ops'
     185 |             trig->ops->re-enable)
         |             ~~~~~~~~~  ^
>> drivers/iio/industrialio-trigger.c:185:20: error: use of undeclared identifier 'enable'
     185 |             trig->ops->re-enable)
         |                           ^
   drivers/iio/industrialio-trigger.c:246:17: error: no member named 're' in 'struct iio_trigger_ops'
     246 |             trig->ops->re-enable)
         |             ~~~~~~~~~  ^
   drivers/iio/industrialio-trigger.c:246:20: error: use of undeclared identifier 'enable'
     246 |             trig->ops->re-enable)
         |                           ^
   drivers/iio/industrialio-trigger.c:247:14: error: no member named 're' in 'struct iio_trigger_ops'
     247 |                 trig->ops->re-enable(trig);
         |                 ~~~~~~~~~  ^
   drivers/iio/industrialio-trigger.c:247:17: error: call to undeclared function 'enable'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     247 |                 trig->ops->re-enable(trig);
         |                               ^
   8 errors generated.


vim +165 drivers/iio/industrialio-trigger.c

   155	
   156	static void iio_reenable_work_fn(struct work_struct *work)
   157	{
   158		struct iio_trigger *trig = container_of(work, struct iio_trigger,
   159							reenable_work);
   160	
   161		/*
   162		 * This 'might' occur after the trigger state is set to disabled -
   163		 * in that case the driver should skip reenabling.
   164		 */
 > 165		trig->ops->re-enable(trig);
   166	}
   167	
   168	/*
   169	 * In general, re-enable callbacks may need to sleep and this path is
   170	 * not performance sensitive, so just queue up a work item
   171	 * to reneable the trigger for us.
   172	 *
   173	 * Races that can cause this.
   174	 * 1) A handler occurs entirely in interrupt context so the counter
   175	 *    the final decrement is still in this interrupt.
   176	 * 2) The trigger has been removed, but one last interrupt gets through.
   177	 *
   178	 * For (1) we must call re-enable, but not in atomic context.
   179	 * For (2) it should be safe to call reenanble, if drivers never blindly
   180	 * re-enable after state is off.
   181	 */
   182	static void iio_trigger_notify_done_atomic(struct iio_trigger *trig)
   183	{
   184		if (atomic_dec_and_test(&trig->use_count) && trig->ops &&
 > 185		    trig->ops->re-enable)
   186			schedule_work(&trig->reenable_work);
   187	}
   188	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH] iio: industrialio-trigger: Fix typos in comments

[Jonathan Cameron]

On Tue, 11 Mar 2025 15:59:27 +0000
Suraj Patil <surajpatil522@gmail.com> wrote:

> Fixed multiple occurrences of 'reenable' to 're-enable' in comments.
> 
> Signed-off-by: Suraj Patil <your-email@example.com>
> Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
Please carefully read what your changes are before sending!
This obviously breaks the code.  

Also don't take a code spell checker to literally.
reenable is fine here.


> ---
>  drivers/iio/industrialio-trigger.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
> index 54416a384232..21688cd348c6 100644
> --- a/drivers/iio/industrialio-trigger.c
> +++ b/drivers/iio/industrialio-trigger.c
> @@ -162,11 +162,11 @@ static void iio_reenable_work_fn(struct work_struct *work)
>  	 * This 'might' occur after the trigger state is set to disabled -
>  	 * in that case the driver should skip reenabling.
>  	 */
> -	trig->ops->reenable(trig);
> +	trig->ops->re-enable(trig);
>  }
>  
>  /*
> - * In general, reenable callbacks may need to sleep and this path is
> + * In general, re-enable callbacks may need to sleep and this path is
>   * not performance sensitive, so just queue up a work item
>   * to reneable the trigger for us.
>   *
> @@ -175,14 +175,14 @@ static void iio_reenable_work_fn(struct work_struct *work)
>   *    the final decrement is still in this interrupt.
>   * 2) The trigger has been removed, but one last interrupt gets through.
>   *
> - * For (1) we must call reenable, but not in atomic context.
> + * For (1) we must call re-enable, but not in atomic context.
>   * For (2) it should be safe to call reenanble, if drivers never blindly
> - * reenable after state is off.
> + * re-enable after state is off.
>   */
>  static void iio_trigger_notify_done_atomic(struct iio_trigger *trig)
>  {
>  	if (atomic_dec_and_test(&trig->use_count) && trig->ops &&
> -	    trig->ops->reenable)
> +	    trig->ops->re-enable)
>  		schedule_work(&trig->reenable_work);
>  }
>  
> @@ -243,8 +243,8 @@ EXPORT_SYMBOL(iio_trigger_poll_nested);
>  void iio_trigger_notify_done(struct iio_trigger *trig)
>  {
>  	if (atomic_dec_and_test(&trig->use_count) && trig->ops &&
> -	    trig->ops->reenable)
> -		trig->ops->reenable(trig);
> +	    trig->ops->re-enable)
> +		trig->ops->re-enable(trig);
>  }
>  EXPORT_SYMBOL(iio_trigger_notify_done);
>