* [PATCH] perf: annotate asm_pure_loop.S
@ 2025-03-23 8:53 Marcus Meissner
2025-03-24 11:34 ` Leo Yan
2025-03-25 19:49 ` Namhyung Kim
0 siblings, 2 replies; 3+ messages in thread
From: Marcus Meissner @ 2025-03-23 8:53 UTC (permalink / raw)
To: peterz, mingo, acme, namhyung, mark.rutland, alexander.shishkin,
jolsa, irogers, adrian.hunter, kan.liang, carsten.haitzler,
james.clark, linux-perf-users, linux-kernel
Cc: Marcus Meissner
Annotate so it is built with non-executable stack.
Fixes: 8b97519711c3a0f9eb8274a227dff3fe4f0f72a2
Signed-off-by: Marcus Meissner <meissner@suse.de>
---
tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S b/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
index 75cf084a927d..577760046772 100644
--- a/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
+++ b/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
@@ -26,3 +26,5 @@ skip:
mov x0, #0
mov x8, #93 // __NR_exit syscall
svc #0
+
+.section .note.GNU-stack, "", @progbits
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf: annotate asm_pure_loop.S
2025-03-23 8:53 [PATCH] perf: annotate asm_pure_loop.S Marcus Meissner
@ 2025-03-24 11:34 ` Leo Yan
2025-03-25 19:49 ` Namhyung Kim
1 sibling, 0 replies; 3+ messages in thread
From: Leo Yan @ 2025-03-24 11:34 UTC (permalink / raw)
To: Marcus Meissner
Cc: peterz, mingo, acme, namhyung, mark.rutland, alexander.shishkin,
jolsa, irogers, adrian.hunter, kan.liang, carsten.haitzler,
james.clark, linux-perf-users, linux-kernel
On Sun, Mar 23, 2025 at 09:53:45AM +0100, Marcus Meissner wrote:
> Annotate so it is built with non-executable stack.
>
> Fixes: 8b97519711c3a0f9eb8274a227dff3fe4f0f72a2
Fixes: 8b97519711c3 ("perf test: Add asm pureloop test tool")
> Signed-off-by: Marcus Meissner <meissner@suse.de>
> ---
> tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S b/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
> index 75cf084a927d..577760046772 100644
> --- a/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
> +++ b/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
> @@ -26,3 +26,5 @@ skip:
> mov x0, #0
> mov x8, #93 // __NR_exit syscall
> svc #0
> +
> +.section .note.GNU-stack, "", @progbits
With the fix tag change:
Reviewed-by: Leo Yan <leo.yan@arm.com>
I found actually Jan Stancek has submitted a similiar patch [1]
~2 years ago but we missed, sorry for that.
[1] https://lore.kernel.org/linux-perf-users/e79288922fbd0bad6facf06488735ec74f811d1b.1689588798.git.jstancek@redhat.com/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf: annotate asm_pure_loop.S
2025-03-23 8:53 [PATCH] perf: annotate asm_pure_loop.S Marcus Meissner
2025-03-24 11:34 ` Leo Yan
@ 2025-03-25 19:49 ` Namhyung Kim
1 sibling, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2025-03-25 19:49 UTC (permalink / raw)
To: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
irogers, adrian.hunter, kan.liang, carsten.haitzler, james.clark,
linux-perf-users, linux-kernel, Marcus Meissner
On Sun, 23 Mar 2025 09:53:45 +0100, Marcus Meissner wrote:
> Annotate so it is built with non-executable stack.
>
>
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-25 19:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-23 8:53 [PATCH] perf: annotate asm_pure_loop.S Marcus Meissner
2025-03-24 11:34 ` Leo Yan
2025-03-25 19:49 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox