From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, jasowang@redhat.com, mst@redhat.com,
michael.christie@oracle.com, sgarzare@redhat.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: [PATCH v8 0/8] vhost: Add support of kthread API
Date: Fri, 28 Mar 2025 18:02:44 +0800 [thread overview]
Message-ID: <20250328100359.1306072-1-lulu@redhat.com> (raw)
In commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads"),
the vhost now uses vhost_task and operates as a child of the
owner thread. This aligns with containerization principles.
However, this change has caused confusion for some legacy
userspace applications. Therefore, we are reintroducing
support for the kthread API.
In this series, a new UAPI is implemented to allow
userspace applications to configure their thread mode.
Changelog v2:
1. Change the module_param's name to enforce_inherit_owner, and the default value is true.
2. Change the UAPI's name to VHOST_SET_INHERIT_FROM_OWNER.
Changelog v3:
1. Change the module_param's name to inherit_owner_default, and the default value is true.
2. Add a structure for task function; the worker will select a different mode based on the value inherit_owner.
3. device will have their own inherit_owner in struct vhost_dev
4. Address other comments
Changelog v4:
1. remove the module_param, only keep the UAPI
2. remove the structure for task function; change to use the function pointer in vhost_worker
3. fix the issue in vhost_worker_create and vhost_dev_ioctl
4. Address other comments
Changelog v5:
1. Change wakeup and stop function pointers in struct vhost_worker to void.
2. merging patches 4, 5, 6 in a single patch
3. Fix spelling issues and address other comments.
Changelog v6:
1. move the check of VHOST_NEW_WORKER from vhost_scsi to vhost
2. Change the ioctl name VHOST_SET_INHERIT_FROM_OWNER to VHOST_FORK_FROM_OWNER
3. reuse the function __vhost_worker_flush
4. use a ops sturct to support worker relates function
5. reset the value of inherit_owner in vhost_dev_reset_owner.
Changelog v7:
1. add a KConfig knob to disable legacy app support
2. Split the changes into two patches to separately introduce the ops and add kthread support.
3. Utilized INX_MAX to avoid modifications in __vhost_worker_flush
4. Rebased on the latest kernel
5. Address other comments
Changelog v8:
1. Rebased on the latest kernel
2. Address some other comments
Tested with QEMU with kthread mode/task mode/kthread+task mode
Cindy Lu (8):
vhost: Add a new parameter in vhost_dev to allow user select kthread
vhost: Reintroduce vhost_worker to support kthread
vhost: Add the cgroup related function
vhost: Introduce vhost_worker_ops in vhost_worker
vhost: Reintroduce kthread mode support in vhost
vhost: uapi to control task mode (owner vs kthread)
vhost: Add check for inherit_owner status
vhost: Add a KConfig knob to enable IOCTL VHOST_FORK_FROM_OWNER
drivers/vhost/Kconfig | 15 +++
drivers/vhost/vhost.c | 219 +++++++++++++++++++++++++++++++++----
drivers/vhost/vhost.h | 21 ++++
include/uapi/linux/vhost.h | 16 +++
4 files changed, 252 insertions(+), 19 deletions(-)
--
2.45.0
next reply other threads:[~2025-03-28 10:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 10:02 Cindy Lu [this message]
2025-03-28 10:02 ` [PATCH v8 1/8] vhost: Add a new parameter in vhost_dev to allow user select kthread Cindy Lu
2025-04-01 13:30 ` Stefano Garzarella
2025-04-03 5:52 ` Cindy Lu
2025-03-28 10:02 ` [PATCH v8 2/8] vhost: Reintroduce vhost_worker to support kthread Cindy Lu
2025-04-01 13:38 ` Stefano Garzarella
2025-03-28 10:02 ` [PATCH v8 3/8] vhost: Add the cgroup related function Cindy Lu
2025-04-01 13:41 ` Stefano Garzarella
2025-04-08 11:11 ` Markus Elfring
2025-03-28 10:02 ` [PATCH v8 4/8] vhost: Introduce vhost_worker_ops in vhost_worker Cindy Lu
2025-04-01 13:48 ` Stefano Garzarella
2025-04-07 3:13 ` Cindy Lu
2025-04-07 8:09 ` Stefano Garzarella
2025-04-07 8:17 ` Michael S. Tsirkin
2025-04-07 16:06 ` Mike Christie
2025-04-08 9:45 ` Cindy Lu
2025-04-08 16:11 ` Mike Christie
2025-03-28 10:02 ` [PATCH v8 5/8] vhost: Reintroduce kthread mode support in vhost Cindy Lu
2025-04-01 13:51 ` Stefano Garzarella
2025-04-07 3:14 ` Cindy Lu
2025-04-07 16:03 ` Mike Christie
2025-04-08 7:54 ` Cindy Lu
2025-03-28 10:02 ` [PATCH v8 6/8] vhost: uapi to control task mode (owner vs kthread) Cindy Lu
2025-04-01 13:57 ` Stefano Garzarella
2025-04-07 3:19 ` Cindy Lu
2025-03-28 10:02 ` [PATCH v8 7/8] vhost: Add check for inherit_owner status Cindy Lu
2025-04-01 13:59 ` Stefano Garzarella
2025-04-07 3:15 ` Cindy Lu
2025-03-28 10:02 ` [PATCH v8 8/8] vhost: Add a KConfig knob to enable IOCTL VHOST_FORK_FROM_OWNER Cindy Lu
2025-04-01 13:21 ` Stefano Garzarella
2025-04-03 5:49 ` Cindy Lu
2025-04-08 11:56 ` Michael S. Tsirkin
2025-04-09 8:37 ` Cindy Lu
2025-03-31 11:59 ` [PATCH v8 0/8] vhost: Add support of kthread API Lei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328100359.1306072-1-lulu@redhat.com \
--to=lulu@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox