From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, jasowang@redhat.com, mst@redhat.com,
michael.christie@oracle.com, sgarzare@redhat.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: [PATCH v8 6/8] vhost: uapi to control task mode (owner vs kthread)
Date: Fri, 28 Mar 2025 18:02:50 +0800 [thread overview]
Message-ID: <20250328100359.1306072-7-lulu@redhat.com> (raw)
In-Reply-To: <20250328100359.1306072-1-lulu@redhat.com>
Add a new UAPI to configure the vhost device to use the kthread mode
The userspace application can use IOCTL VHOST_FORK_FROM_OWNER
to choose between owner and kthread mode if necessary
This setting must be applied before VHOST_SET_OWNER, as the worker
will be created in the VHOST_SET_OWNER function
Signed-off-by: Cindy Lu <lulu@redhat.com>
---
drivers/vhost/vhost.c | 22 ++++++++++++++++++++--
include/uapi/linux/vhost.h | 16 ++++++++++++++++
2 files changed, 36 insertions(+), 2 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index be97028a8baf..ff930c2e5b78 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1134,7 +1134,7 @@ void vhost_dev_reset_owner(struct vhost_dev *dev, struct vhost_iotlb *umem)
int i;
vhost_dev_cleanup(dev);
-
+ dev->inherit_owner = true;
dev->umem = umem;
/* We don't need VQ locks below since vhost_dev_cleanup makes sure
* VQs aren't running.
@@ -2287,7 +2287,25 @@ long vhost_dev_ioctl(struct vhost_dev *d, unsigned int ioctl, void __user *argp)
r = vhost_dev_set_owner(d);
goto done;
}
-
+ if (ioctl == VHOST_FORK_FROM_OWNER) {
+ u8 inherit_owner;
+ /*inherit_owner can only be modified before owner is set*/
+ if (vhost_dev_has_owner(d)) {
+ r = -EBUSY;
+ goto done;
+ }
+ if (copy_from_user(&inherit_owner, argp, sizeof(u8))) {
+ r = -EFAULT;
+ goto done;
+ }
+ if (inherit_owner > 1) {
+ r = -EINVAL;
+ goto done;
+ }
+ d->inherit_owner = (bool)inherit_owner;
+ r = 0;
+ goto done;
+ }
/* You must be the owner to do anything else */
r = vhost_dev_check_owner(d);
if (r)
diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
index b95dd84eef2d..1ae0917bfeca 100644
--- a/include/uapi/linux/vhost.h
+++ b/include/uapi/linux/vhost.h
@@ -235,4 +235,20 @@
*/
#define VHOST_VDPA_GET_VRING_SIZE _IOWR(VHOST_VIRTIO, 0x82, \
struct vhost_vring_state)
+
+/**
+ * VHOST_FORK_FROM_OWNER - Set the inherit_owner flag for the vhost device,
+ * This ioctl must called before VHOST_SET_OWNER.
+ *
+ * @param inherit_owner: An 8-bit value that determines the vhost thread mode
+ *
+ * When inherit_owner is set to 1(default value):
+ * - Vhost will create tasks similar to processes forked from the owner,
+ * inheriting all of the owner's attributes.
+ *
+ * When inherit_owner is set to 0:
+ * - Vhost will create tasks as kernel thread.
+ */
+#define VHOST_FORK_FROM_OWNER _IOW(VHOST_VIRTIO, 0x83, __u8)
+
#endif
--
2.45.0
next prev parent reply other threads:[~2025-03-28 10:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 10:02 [PATCH v8 0/8] vhost: Add support of kthread API Cindy Lu
2025-03-28 10:02 ` [PATCH v8 1/8] vhost: Add a new parameter in vhost_dev to allow user select kthread Cindy Lu
2025-04-01 13:30 ` Stefano Garzarella
2025-04-03 5:52 ` Cindy Lu
2025-03-28 10:02 ` [PATCH v8 2/8] vhost: Reintroduce vhost_worker to support kthread Cindy Lu
2025-04-01 13:38 ` Stefano Garzarella
2025-03-28 10:02 ` [PATCH v8 3/8] vhost: Add the cgroup related function Cindy Lu
2025-04-01 13:41 ` Stefano Garzarella
2025-04-08 11:11 ` Markus Elfring
2025-03-28 10:02 ` [PATCH v8 4/8] vhost: Introduce vhost_worker_ops in vhost_worker Cindy Lu
2025-04-01 13:48 ` Stefano Garzarella
2025-04-07 3:13 ` Cindy Lu
2025-04-07 8:09 ` Stefano Garzarella
2025-04-07 8:17 ` Michael S. Tsirkin
2025-04-07 16:06 ` Mike Christie
2025-04-08 9:45 ` Cindy Lu
2025-04-08 16:11 ` Mike Christie
2025-03-28 10:02 ` [PATCH v8 5/8] vhost: Reintroduce kthread mode support in vhost Cindy Lu
2025-04-01 13:51 ` Stefano Garzarella
2025-04-07 3:14 ` Cindy Lu
2025-04-07 16:03 ` Mike Christie
2025-04-08 7:54 ` Cindy Lu
2025-03-28 10:02 ` Cindy Lu [this message]
2025-04-01 13:57 ` [PATCH v8 6/8] vhost: uapi to control task mode (owner vs kthread) Stefano Garzarella
2025-04-07 3:19 ` Cindy Lu
2025-03-28 10:02 ` [PATCH v8 7/8] vhost: Add check for inherit_owner status Cindy Lu
2025-04-01 13:59 ` Stefano Garzarella
2025-04-07 3:15 ` Cindy Lu
2025-03-28 10:02 ` [PATCH v8 8/8] vhost: Add a KConfig knob to enable IOCTL VHOST_FORK_FROM_OWNER Cindy Lu
2025-04-01 13:21 ` Stefano Garzarella
2025-04-03 5:49 ` Cindy Lu
2025-04-08 11:56 ` Michael S. Tsirkin
2025-04-09 8:37 ` Cindy Lu
2025-03-31 11:59 ` [PATCH v8 0/8] vhost: Add support of kthread API Lei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328100359.1306072-7-lulu@redhat.com \
--to=lulu@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox