public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, jasowang@redhat.com, mst@redhat.com,
	michael.christie@oracle.com, sgarzare@redhat.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: [PATCH v8 7/8] vhost: Add check for inherit_owner status
Date: Fri, 28 Mar 2025 18:02:51 +0800	[thread overview]
Message-ID: <20250328100359.1306072-8-lulu@redhat.com> (raw)
In-Reply-To: <20250328100359.1306072-1-lulu@redhat.com>

The VHOST_NEW_WORKER requires the inherit_owner
setting to be true. So we need to add a check for this.

Signed-off-by: Cindy Lu <lulu@redhat.com>
---
 drivers/vhost/vhost.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index ff930c2e5b78..fb0c7fb43f78 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1018,6 +1018,13 @@ long vhost_worker_ioctl(struct vhost_dev *dev, unsigned int ioctl,
 	switch (ioctl) {
 	/* dev worker ioctls */
 	case VHOST_NEW_WORKER:
+		/*
+		 * vhost_tasks will account for worker threads under the parent's
+		 * NPROC value but kthreads do not. To avoid userspace overflowing
+		 * the system with worker threads inherit_owner must be true.
+		 */
+		if (!dev->inherit_owner)
+			return -EFAULT;
 		ret = vhost_new_worker(dev, &state);
 		if (!ret && copy_to_user(argp, &state, sizeof(state)))
 			ret = -EFAULT;
-- 
2.45.0


  parent reply	other threads:[~2025-03-28 10:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28 10:02 [PATCH v8 0/8] vhost: Add support of kthread API Cindy Lu
2025-03-28 10:02 ` [PATCH v8 1/8] vhost: Add a new parameter in vhost_dev to allow user select kthread Cindy Lu
2025-04-01 13:30   ` Stefano Garzarella
2025-04-03  5:52     ` Cindy Lu
2025-03-28 10:02 ` [PATCH v8 2/8] vhost: Reintroduce vhost_worker to support kthread Cindy Lu
2025-04-01 13:38   ` Stefano Garzarella
2025-03-28 10:02 ` [PATCH v8 3/8] vhost: Add the cgroup related function Cindy Lu
2025-04-01 13:41   ` Stefano Garzarella
2025-04-08 11:11   ` Markus Elfring
2025-03-28 10:02 ` [PATCH v8 4/8] vhost: Introduce vhost_worker_ops in vhost_worker Cindy Lu
2025-04-01 13:48   ` Stefano Garzarella
2025-04-07  3:13     ` Cindy Lu
2025-04-07  8:09       ` Stefano Garzarella
2025-04-07  8:17   ` Michael S. Tsirkin
2025-04-07 16:06     ` Mike Christie
2025-04-08  9:45       ` Cindy Lu
2025-04-08 16:11         ` Mike Christie
2025-03-28 10:02 ` [PATCH v8 5/8] vhost: Reintroduce kthread mode support in vhost Cindy Lu
2025-04-01 13:51   ` Stefano Garzarella
2025-04-07  3:14     ` Cindy Lu
2025-04-07 16:03   ` Mike Christie
2025-04-08  7:54     ` Cindy Lu
2025-03-28 10:02 ` [PATCH v8 6/8] vhost: uapi to control task mode (owner vs kthread) Cindy Lu
2025-04-01 13:57   ` Stefano Garzarella
2025-04-07  3:19     ` Cindy Lu
2025-03-28 10:02 ` Cindy Lu [this message]
2025-04-01 13:59   ` [PATCH v8 7/8] vhost: Add check for inherit_owner status Stefano Garzarella
2025-04-07  3:15     ` Cindy Lu
2025-03-28 10:02 ` [PATCH v8 8/8] vhost: Add a KConfig knob to enable IOCTL VHOST_FORK_FROM_OWNER Cindy Lu
2025-04-01 13:21   ` Stefano Garzarella
2025-04-03  5:49     ` Cindy Lu
2025-04-08 11:56   ` Michael S. Tsirkin
2025-04-09  8:37     ` Cindy Lu
2025-03-31 11:59 ` [PATCH v8 0/8] vhost: Add support of kthread API Lei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250328100359.1306072-8-lulu@redhat.com \
    --to=lulu@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sgarzare@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox