public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Gabriele Monaco <gmonaco@redhat.com>
To: linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-trace-kernel@vger.kernel.org
Cc: Gabriele Monaco <gmonaco@redhat.com>,
	Tomas Glozar <tglozar@redhat.com>, Juri Lelli <jlelli@redhat.com>
Subject: [RFC PATCH 1/9] tools/rv: Do not skip idle in trace
Date: Fri,  4 Apr 2025 10:45:14 +0200	[thread overview]
Message-ID: <20250404084512.98552-12-gmonaco@redhat.com> (raw)
In-Reply-To: <20250404084512.98552-11-gmonaco@redhat.com>

Currently, the userspace RV tool skips trace events triggered by the RV
tool itself, this can be changed by passing the parameter -s, which sets
the variable config_my_pid to 0 (instead of the tool's PID).
The current condition for per-task monitors (config_has_id) does not
check that config_my_pid isn't 0 to skip. In case we pass -s, we show
events triggered by RV but don't show those triggered by idle (PID 0).

Fix the condition to account this scenario.

Fixes: 6d60f89691fc ("tools/rv: Add in-kernel monitor interface")
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
 tools/verification/rv/src/in_kernel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/verification/rv/src/in_kernel.c b/tools/verification/rv/src/in_kernel.c
index c0dcee795c0de..72b03bae021cd 100644
--- a/tools/verification/rv/src/in_kernel.c
+++ b/tools/verification/rv/src/in_kernel.c
@@ -429,7 +429,7 @@ ikm_event_handler(struct trace_seq *s, struct tep_record *record,
 
 	tep_get_common_field_val(s, trace_event, "common_pid", record, &pid, 1);
 
-	if (config_has_id && (config_my_pid == id))
+	if (config_my_pid && config_has_id && (config_my_pid == id))
 		return 0;
 	else if (config_my_pid && (config_my_pid == pid))
 		return 0;
-- 
2.49.0


  reply	other threads:[~2025-04-04  8:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04  8:45 [RFC PATCH 0/9] rv: Add monitors to validate task switch Gabriele Monaco
2025-04-04  8:45 ` Gabriele Monaco [this message]
2025-04-04  8:45 ` [RFC PATCH 2/9] tools/rv: Stop gracefully also on SIGTERM Gabriele Monaco
2025-04-04  8:45 ` [RFC PATCH 3/9] rv: Add da_handle_start_run_event_ to per-task monitors Gabriele Monaco
2025-04-04  8:45 ` [RFC PATCH 4/9] rv: Remove trailing whitespace from tracepoint string Gabriele Monaco
2025-04-04  8:45 ` [RFC PATCH 5/9] sched: Add sched tracepoints for RV task model Gabriele Monaco
2025-04-04  8:45 ` [RFC PATCH 6/9] sched: Treat try_to_block_task with pending signal as wakeup Gabriele Monaco
2025-04-13 15:05   ` Nam Cao
2025-04-14 10:31     ` Gabriele Monaco
2025-04-15 11:04       ` Nam Cao
2025-04-15 11:30         ` Gabriele Monaco
2025-04-16  9:20           ` Nam Cao
2025-04-16 11:42             ` Gabriele Monaco
2025-04-04  8:45 ` [RFC PATCH 7/9] rv: Retry when da monitor detects race conditions Gabriele Monaco
2025-04-11  4:52   ` Nam Cao
2025-04-11  6:09     ` Gabriele Monaco
2025-04-04  8:45 ` [RFC PATCH 8/9] rv: Replace tss monitor with more complete sts Gabriele Monaco
2025-04-04  8:45 ` [RFC PATCH 9/9] rv: Add srs per-task monitor Gabriele Monaco
2025-04-10  8:53   ` Juri Lelli
2025-04-11  6:12     ` Gabriele Monaco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250404084512.98552-12-gmonaco@redhat.com \
    --to=gmonaco@redhat.com \
    --cc=jlelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglozar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox