From: Gabriele Monaco <gmonaco@redhat.com>
To: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: Gabriele Monaco <gmonaco@redhat.com>,
Tomas Glozar <tglozar@redhat.com>, Juri Lelli <jlelli@redhat.com>
Subject: [RFC PATCH 6/9] sched: Treat try_to_block_task with pending signal as wakeup
Date: Fri, 4 Apr 2025 10:45:19 +0200 [thread overview]
Message-ID: <20250404084512.98552-17-gmonaco@redhat.com> (raw)
In-Reply-To: <20250404084512.98552-11-gmonaco@redhat.com>
If a task sets itself to interruptible and schedules, the __schedule
function checks whether there's a pending signal and, if that's the
case, updates the state of the task to runnable instead of dequeuing.
By looking at the tracepoints, we see the task enters the scheduler
while sleepable but exits as runnable. From a modelling perspective,
this is equivalent to a wakeup and the tracepoints should reflect that.
Add the waking/wakeup tracepoints in the try_to_block_task function and
set the prev_state used by the sched_switch tracepoint to TASK_RUNNING
if the task had a pending signal and was not blocked.
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
kernel/sched/core.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index f2f79236d5811..48cb32abce01a 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6584,7 +6584,12 @@ static bool try_to_block_task(struct rq *rq, struct task_struct *p,
int flags = DEQUEUE_NOCLOCK;
if (signal_pending_state(task_state, p)) {
- WRITE_ONCE(p->__state, TASK_RUNNING);
+ /*
+ * From a modelling perspective, this is equivalent to a wakeup
+ * before dequeuing the task: trace accordingly.
+ */
+ trace_sched_waking(p);
+ ttwu_do_wakeup(p);
return false;
}
@@ -6721,7 +6726,9 @@ static void __sched notrace __schedule(int sched_mode)
goto picked;
}
} else if (!preempt && prev_state) {
- try_to_block_task(rq, prev, prev_state);
+ /* Task was not blocked due to a signal and is again runnable */
+ if (!try_to_block_task(rq, prev, prev_state))
+ prev_state = TASK_RUNNING;
switch_count = &prev->nvcsw;
}
--
2.49.0
next prev parent reply other threads:[~2025-04-04 8:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 8:45 [RFC PATCH 0/9] rv: Add monitors to validate task switch Gabriele Monaco
2025-04-04 8:45 ` [RFC PATCH 1/9] tools/rv: Do not skip idle in trace Gabriele Monaco
2025-04-04 8:45 ` [RFC PATCH 2/9] tools/rv: Stop gracefully also on SIGTERM Gabriele Monaco
2025-04-04 8:45 ` [RFC PATCH 3/9] rv: Add da_handle_start_run_event_ to per-task monitors Gabriele Monaco
2025-04-04 8:45 ` [RFC PATCH 4/9] rv: Remove trailing whitespace from tracepoint string Gabriele Monaco
2025-04-04 8:45 ` [RFC PATCH 5/9] sched: Add sched tracepoints for RV task model Gabriele Monaco
2025-04-04 8:45 ` Gabriele Monaco [this message]
2025-04-13 15:05 ` [RFC PATCH 6/9] sched: Treat try_to_block_task with pending signal as wakeup Nam Cao
2025-04-14 10:31 ` Gabriele Monaco
2025-04-15 11:04 ` Nam Cao
2025-04-15 11:30 ` Gabriele Monaco
2025-04-16 9:20 ` Nam Cao
2025-04-16 11:42 ` Gabriele Monaco
2025-04-04 8:45 ` [RFC PATCH 7/9] rv: Retry when da monitor detects race conditions Gabriele Monaco
2025-04-11 4:52 ` Nam Cao
2025-04-11 6:09 ` Gabriele Monaco
2025-04-04 8:45 ` [RFC PATCH 8/9] rv: Replace tss monitor with more complete sts Gabriele Monaco
2025-04-04 8:45 ` [RFC PATCH 9/9] rv: Add srs per-task monitor Gabriele Monaco
2025-04-10 8:53 ` Juri Lelli
2025-04-11 6:12 ` Gabriele Monaco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404084512.98552-17-gmonaco@redhat.com \
--to=gmonaco@redhat.com \
--cc=jlelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglozar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox