From: Rishikesh Donadkar <r-donadkar@ti.com>
To: <jai.luthra@linux.dev>, <mripard@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>, <r-donadkar@ti.com>,
<devarsht@ti.com>, <y-abhilashchandra@ti.com>,
<mchehab@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <vaishnav.a@ti.com>, <s-jain1@ti.com>,
<vigneshr@ti.com>, <sakari.ailus@linux.intel.com>,
<hverkuil-cisco@xs4all.nl>, <tomi.valkeinen@ideasonboard.com>,
<jai.luthra@ideasonboard.com>,
<changhuang.liang@starfivetech.com>, <jack.zhu@starfivetech.com>,
<laurent.pinchart@ideasonboard.com>
Subject: [PATCH v3 09/13] media: cadence: csi2rx: Use new enable stream APIs
Date: Thu, 17 Apr 2025 12:25:50 +0530 [thread overview]
Message-ID: <20250417065554.437541-10-r-donadkar@ti.com> (raw)
In-Reply-To: <20250417065554.437541-1-r-donadkar@ti.com>
From: Jai Luthra <j-luthra@ti.com>
The enable_streams() API in v4l2 supports passing a bitmask to enable
each pad/stream combination individually on any media subdev instead of
doing s_stream(1) to start all streams on the subdev at once.
This API is implemented by ds90ub960 driver (FPDLink deser) and thus the
caller (cdns-csi2x) is required to use it. For now we only enable
stream0.
Signed-off-by: Jai Luthra <j-luthra@ti.com>
Signed-off-by: Rishikesh Donadkar <r-donadkar@ti.com>
---
drivers/media/platform/cadence/cdns-csi2rx.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c
index b7e9225f66a41..df05d278df379 100644
--- a/drivers/media/platform/cadence/cdns-csi2rx.c
+++ b/drivers/media/platform/cadence/cdns-csi2rx.c
@@ -224,10 +224,18 @@ static int csi2rx_configure_ext_dphy(struct csi2rx_priv *csi2rx)
static int csi2rx_start(struct csi2rx_priv *csi2rx)
{
unsigned int i;
+ struct media_pad *remote_pad;
unsigned long lanes_used = 0;
u32 reg;
int ret;
+ remote_pad = media_pad_remote_pad_first(&csi2rx->pads[CSI2RX_PAD_SINK]);
+ if (!remote_pad) {
+ dev_err(csi2rx->dev,
+ "Failed to find connected source\n");
+ return -ENODEV;
+ }
+
ret = clk_prepare_enable(csi2rx->p_clk);
if (ret)
return ret;
@@ -311,7 +319,8 @@ static int csi2rx_start(struct csi2rx_priv *csi2rx)
reset_control_deassert(csi2rx->sys_rst);
- ret = v4l2_subdev_call(csi2rx->source_subdev, video, s_stream, true);
+ ret = v4l2_subdev_enable_streams(csi2rx->source_subdev,
+ remote_pad->index, BIT(0));
if (ret)
goto err_disable_sysclk;
@@ -339,6 +348,7 @@ static int csi2rx_start(struct csi2rx_priv *csi2rx)
static void csi2rx_stop(struct csi2rx_priv *csi2rx)
{
+ struct media_pad *remote_pad;
unsigned int i;
u32 val;
int ret;
@@ -367,8 +377,12 @@ static void csi2rx_stop(struct csi2rx_priv *csi2rx)
reset_control_assert(csi2rx->p_rst);
clk_disable_unprepare(csi2rx->p_clk);
- if (v4l2_subdev_call(csi2rx->source_subdev, video, s_stream, false))
+ remote_pad = media_pad_remote_pad_first(&csi2rx->pads[CSI2RX_PAD_SINK]);
+ if (!remote_pad ||
+ v4l2_subdev_disable_streams(csi2rx->source_subdev,
+ remote_pad->index, BIT(0))) {
dev_warn(csi2rx->dev, "Couldn't disable our subdev\n");
+ }
if (csi2rx->dphy) {
writel(0, csi2rx->base + CSI2RX_DPHY_LANE_CTRL_REG);
--
2.34.1
next prev parent reply other threads:[~2025-04-17 6:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 6:55 [PATCH v3 00/13] media: cadence,ti: CSI2RX Multistream Support Rishikesh Donadkar
2025-04-17 6:55 ` [PATCH v3 01/13] dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans Rishikesh Donadkar
2025-04-21 11:15 ` Laurent Pinchart
2025-04-21 22:26 ` Rob Herring (Arm)
2025-04-17 6:55 ` [PATCH v3 02/13] media: ti: j721e-csi2rx: separate out device and context Rishikesh Donadkar
2025-04-21 11:32 ` Laurent Pinchart
2025-04-30 11:01 ` Rishikesh Donadkar
2025-05-09 8:15 ` Rishikesh Donadkar
2025-04-17 6:55 ` [PATCH v3 03/13] media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts Rishikesh Donadkar
2025-04-21 11:33 ` Laurent Pinchart
2025-04-17 6:55 ` [PATCH v3 04/13] media: ti: j721e-csi2rx: allocate DMA channel based on context index Rishikesh Donadkar
2025-04-21 11:36 ` Laurent Pinchart
2025-04-17 6:55 ` [PATCH v3 05/13] media: ti: j721e-csi2rx: add a subdev for the core device Rishikesh Donadkar
2025-04-21 13:12 ` Laurent Pinchart
2025-05-03 5:54 ` Rishikesh Donadkar
2025-04-17 6:55 ` [PATCH v3 06/13] media: ti: j721e-csi2rx: get number of contexts from device tree Rishikesh Donadkar
2025-04-21 13:20 ` Laurent Pinchart
2025-05-03 5:59 ` Rishikesh Donadkar
2025-04-17 6:55 ` [PATCH v3 07/13] media: cadence: csi2rx: add get_frame_desc wrapper Rishikesh Donadkar
2025-04-21 7:00 ` 回复: " Changhuang Liang
2025-04-21 13:22 ` Laurent Pinchart
2025-04-17 6:55 ` [PATCH v3 08/13] media: ti: j721e-csi2rx: add support for processing virtual channels Rishikesh Donadkar
2025-04-21 13:34 ` Laurent Pinchart
2025-05-05 7:06 ` Rishikesh Donadkar
2025-04-17 6:55 ` Rishikesh Donadkar [this message]
2025-04-21 7:01 ` 回复: [PATCH v3 09/13] media: cadence: csi2rx: Use new enable stream APIs Changhuang Liang
2025-04-21 13:25 ` Laurent Pinchart
2025-04-17 6:55 ` [PATCH v3 10/13] media: cadence: csi2rx: Enable multi-stream support Rishikesh Donadkar
2025-04-21 7:02 ` 回复: " Changhuang Liang
2025-04-21 13:57 ` Laurent Pinchart
2025-05-06 11:06 ` Rishikesh Donadkar
2025-05-09 8:47 ` Laurent Pinchart
2025-04-17 6:55 ` [PATCH v3 11/13] media: ti: j721e-csi2rx: add multistream support Rishikesh Donadkar
2025-04-17 6:55 ` [PATCH v3 12/13] media: ti: j721e-csi2rx: Submit all available buffers Rishikesh Donadkar
2025-04-17 6:55 ` [PATCH v3 13/13] media: ti: j721e-csi2rx: Change the drain architecture for multistream Rishikesh Donadkar
2025-04-25 11:35 ` Jai Luthra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417065554.437541-10-r-donadkar@ti.com \
--to=r-donadkar@ti.com \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jack.zhu@starfivetech.com \
--cc=jai.luthra@ideasonboard.com \
--cc=jai.luthra@linux.dev \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=s-jain1@ti.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=vaishnav.a@ti.com \
--cc=vigneshr@ti.com \
--cc=y-abhilashchandra@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox