The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Rishikesh Donadkar <r-donadkar@ti.com>
To: <jai.luthra@linux.dev>, <mripard@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <r-donadkar@ti.com>,
	<devarsht@ti.com>, <y-abhilashchandra@ti.com>,
	<mchehab@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <vaishnav.a@ti.com>, <s-jain1@ti.com>,
	<vigneshr@ti.com>, <sakari.ailus@linux.intel.com>,
	<hverkuil-cisco@xs4all.nl>, <tomi.valkeinen@ideasonboard.com>,
	<jai.luthra@ideasonboard.com>,
	<changhuang.liang@starfivetech.com>, <jack.zhu@starfivetech.com>,
	<laurent.pinchart@ideasonboard.com>
Subject: [PATCH v3 08/13] media: ti: j721e-csi2rx: add support for processing virtual channels
Date: Thu, 17 Apr 2025 12:25:49 +0530	[thread overview]
Message-ID: <20250417065554.437541-9-r-donadkar@ti.com> (raw)
In-Reply-To: <20250417065554.437541-1-r-donadkar@ti.com>

From: Jai Luthra <j-luthra@ti.com>

Use get_frame_desc() to get the frame desc from the connected source,
and use the provided virtual channel instead of hardcoded one.

get_frame_desc() works per stream, but as we don't support multiple
streams yet, we will just always use stream 0. If the source doesn't
support get_frame_desc(), fall back to the previous method of always
capturing virtual channel 0.

Co-developed-by: Pratyush Yadav <p.yadav@ti.com>
Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
Signed-off-by: Jai Luthra <j-luthra@ti.com>
Signed-off-by: Rishikesh Donadkar <r-donadkar@ti.com>
---
 .../platform/ti/j721e-csi2rx/j721e-csi2rx.c   | 39 +++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
index e85d04d7c2ff9..3e2a0517a9096 100644
--- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
+++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
@@ -29,6 +29,7 @@
 #define SHIM_DMACNTX_EN			BIT(31)
 #define SHIM_DMACNTX_YUV422		GENMASK(27, 26)
 #define SHIM_DMACNTX_SIZE		GENMASK(21, 20)
+#define SHIM_DMACNTX_VC			GENMASK(9, 6)
 #define SHIM_DMACNTX_FMT		GENMASK(5, 0)
 #define SHIM_DMACNTX_YUV422_MODE_11	3
 #define SHIM_DMACNTX_SIZE_8		0
@@ -105,6 +106,8 @@ struct ti_csi2rx_ctx {
 	struct media_pad		pad;
 	u32				sequence;
 	u32				idx;
+	u32				vc;
+	u32				stream;
 };
 
 struct ti_csi2rx_dev {
@@ -573,6 +576,7 @@ static void ti_csi2rx_setup_shim(struct ti_csi2rx_ctx *ctx)
 	}
 
 	reg |= FIELD_PREP(SHIM_DMACNTX_SIZE, fmt->size);
+	reg |= FIELD_PREP(SHIM_DMACNTX_VC, ctx->vc);
 
 	writel(reg, csi->shim + SHIM_DMACNTX(ctx->idx));
 
@@ -846,6 +850,33 @@ static void ti_csi2rx_buffer_queue(struct vb2_buffer *vb)
 	}
 }
 
+static int ti_csi2rx_get_vc(struct ti_csi2rx_ctx *ctx)
+{
+	struct ti_csi2rx_dev *csi = ctx->csi;
+	struct v4l2_mbus_frame_desc fd;
+	struct media_pad *pad;
+	int ret, i;
+
+	pad = media_entity_remote_pad_unique(&csi->subdev.entity, MEDIA_PAD_FL_SOURCE);
+	if (!pad)
+		return -ENODEV;
+
+	ret = v4l2_subdev_call(csi->source, pad, get_frame_desc, pad->index,
+			       &fd);
+	if (ret)
+		return ret;
+
+	if (fd.type != V4L2_MBUS_FRAME_DESC_TYPE_CSI2)
+		return -EINVAL;
+
+	for (i = 0; i < fd.num_entries; i++) {
+		if (ctx->stream == fd.entry[i].stream)
+			return fd.entry[i].bus.csi2.vc;
+	}
+
+	return -ENODEV;
+}
+
 static int ti_csi2rx_start_streaming(struct vb2_queue *vq, unsigned int count)
 {
 	struct ti_csi2rx_ctx *ctx = vb2_get_drv_priv(vq);
@@ -866,6 +897,14 @@ static int ti_csi2rx_start_streaming(struct vb2_queue *vq, unsigned int count)
 	if (ret)
 		goto err;
 
+	ret = ti_csi2rx_get_vc(ctx);
+	if (ret == -ENOIOCTLCMD)
+		ctx->vc = 0;
+	else if (ret < 0)
+		goto err;
+	else
+		ctx->vc = ret;
+
 	ti_csi2rx_setup_shim(ctx);
 
 	ctx->sequence = 0;
-- 
2.34.1


  parent reply	other threads:[~2025-04-17  6:57 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-17  6:55 [PATCH v3 00/13] media: cadence,ti: CSI2RX Multistream Support Rishikesh Donadkar
2025-04-17  6:55 ` [PATCH v3 01/13] dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans Rishikesh Donadkar
2025-04-21 11:15   ` Laurent Pinchart
2025-04-21 22:26   ` Rob Herring (Arm)
2025-04-17  6:55 ` [PATCH v3 02/13] media: ti: j721e-csi2rx: separate out device and context Rishikesh Donadkar
2025-04-21 11:32   ` Laurent Pinchart
2025-04-30 11:01     ` Rishikesh Donadkar
2025-05-09  8:15     ` Rishikesh Donadkar
2025-04-17  6:55 ` [PATCH v3 03/13] media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts Rishikesh Donadkar
2025-04-21 11:33   ` Laurent Pinchart
2025-04-17  6:55 ` [PATCH v3 04/13] media: ti: j721e-csi2rx: allocate DMA channel based on context index Rishikesh Donadkar
2025-04-21 11:36   ` Laurent Pinchart
2025-04-17  6:55 ` [PATCH v3 05/13] media: ti: j721e-csi2rx: add a subdev for the core device Rishikesh Donadkar
2025-04-21 13:12   ` Laurent Pinchart
2025-05-03  5:54     ` Rishikesh Donadkar
2025-04-17  6:55 ` [PATCH v3 06/13] media: ti: j721e-csi2rx: get number of contexts from device tree Rishikesh Donadkar
2025-04-21 13:20   ` Laurent Pinchart
2025-05-03  5:59     ` Rishikesh Donadkar
2025-04-17  6:55 ` [PATCH v3 07/13] media: cadence: csi2rx: add get_frame_desc wrapper Rishikesh Donadkar
2025-04-21  7:00   ` 回复: " Changhuang Liang
2025-04-21 13:22   ` Laurent Pinchart
2025-04-17  6:55 ` Rishikesh Donadkar [this message]
2025-04-21 13:34   ` [PATCH v3 08/13] media: ti: j721e-csi2rx: add support for processing virtual channels Laurent Pinchart
2025-05-05  7:06     ` Rishikesh Donadkar
2025-04-17  6:55 ` [PATCH v3 09/13] media: cadence: csi2rx: Use new enable stream APIs Rishikesh Donadkar
2025-04-21  7:01   ` 回复: " Changhuang Liang
2025-04-21 13:25   ` Laurent Pinchart
2025-04-17  6:55 ` [PATCH v3 10/13] media: cadence: csi2rx: Enable multi-stream support Rishikesh Donadkar
2025-04-21  7:02   ` 回复: " Changhuang Liang
2025-04-21 13:57   ` Laurent Pinchart
2025-05-06 11:06     ` Rishikesh Donadkar
2025-05-09  8:47       ` Laurent Pinchart
2025-04-17  6:55 ` [PATCH v3 11/13] media: ti: j721e-csi2rx: add multistream support Rishikesh Donadkar
2025-04-17  6:55 ` [PATCH v3 12/13] media: ti: j721e-csi2rx: Submit all available buffers Rishikesh Donadkar
2025-04-17  6:55 ` [PATCH v3 13/13] media: ti: j721e-csi2rx: Change the drain architecture for multistream Rishikesh Donadkar
2025-04-25 11:35   ` Jai Luthra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250417065554.437541-9-r-donadkar@ti.com \
    --to=r-donadkar@ti.com \
    --cc=changhuang.liang@starfivetech.com \
    --cc=conor+dt@kernel.org \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=jack.zhu@starfivetech.com \
    --cc=jai.luthra@ideasonboard.com \
    --cc=jai.luthra@linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=s-jain1@ti.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=vaishnav.a@ti.com \
    --cc=vigneshr@ti.com \
    --cc=y-abhilashchandra@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox