* Re: [PATCH v2] PCI: fix the printed delay amount in info print
2025-04-14 0:15 [PATCH v2] PCI: fix the printed delay amount in info print Wilfred Mallawa
@ 2025-04-14 0:46 ` Sathyanarayanan Kuppuswamy
2025-04-14 4:40 ` Mika Westerberg
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Sathyanarayanan Kuppuswamy @ 2025-04-14 0:46 UTC (permalink / raw)
To: Wilfred Mallawa, bhelgaas, mika.westerberg, lukas, linux-pci,
linux-kernel
Cc: alistair.francis, wilfred.mallawa, dlemoal, cassel
On 4/13/25 5:15 PM, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> Print the delay amount that pcie_wait_for_link_delay() is invoked with
> instead of the hardcoded 1000ms value in the debug info print.
>
> Fixes: 7b3ba09febf4 ("PCI/PM: Shorten pci_bridge_wait_for_secondary_bus() wait time for slow links")
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> ---
Reviewed-by: Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>
> drivers/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 869d204a70a3..8139b70cafa9 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4935,7 +4935,7 @@ int pci_bridge_wait_for_secondary_bus(struct pci_dev *dev, char *reset_type)
> delay);
> if (!pcie_wait_for_link_delay(dev, true, delay)) {
> /* Did not train, no need to wait any further */
> - pci_info(dev, "Data Link Layer Link Active not set in 1000 msec\n");
> + pci_info(dev, "Data Link Layer Link Active not set in %d msec\n", delay);
> return -ENOTTY;
> }
>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] PCI: fix the printed delay amount in info print
2025-04-14 0:15 [PATCH v2] PCI: fix the printed delay amount in info print Wilfred Mallawa
2025-04-14 0:46 ` Sathyanarayanan Kuppuswamy
@ 2025-04-14 4:40 ` Mika Westerberg
2025-04-14 13:01 ` Ilpo Järvinen
2025-04-17 20:26 ` Bjorn Helgaas
3 siblings, 0 replies; 5+ messages in thread
From: Mika Westerberg @ 2025-04-14 4:40 UTC (permalink / raw)
To: Wilfred Mallawa
Cc: bhelgaas, sathyanarayanan.kuppuswamy, lukas, linux-pci,
linux-kernel, alistair.francis, wilfred.mallawa, dlemoal, cassel
On Mon, Apr 14, 2025 at 10:15:06AM +1000, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> Print the delay amount that pcie_wait_for_link_delay() is invoked with
> instead of the hardcoded 1000ms value in the debug info print.
>
> Fixes: 7b3ba09febf4 ("PCI/PM: Shorten pci_bridge_wait_for_secondary_bus() wait time for slow links")
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] PCI: fix the printed delay amount in info print
2025-04-14 0:15 [PATCH v2] PCI: fix the printed delay amount in info print Wilfred Mallawa
2025-04-14 0:46 ` Sathyanarayanan Kuppuswamy
2025-04-14 4:40 ` Mika Westerberg
@ 2025-04-14 13:01 ` Ilpo Järvinen
2025-04-17 20:26 ` Bjorn Helgaas
3 siblings, 0 replies; 5+ messages in thread
From: Ilpo Järvinen @ 2025-04-14 13:01 UTC (permalink / raw)
To: Wilfred Mallawa
Cc: bhelgaas, Mika Westerberg, sathyanarayanan.kuppuswamy,
Lukas Wunner, linux-pci, LKML, alistair.francis, wilfred.mallawa,
dlemoal, cassel
[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]
On Mon, 14 Apr 2025, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> Print the delay amount that pcie_wait_for_link_delay() is invoked with
> instead of the hardcoded 1000ms value in the debug info print.
>
> Fixes: 7b3ba09febf4 ("PCI/PM: Shorten pci_bridge_wait_for_secondary_bus() wait time for slow links")
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> ---
> drivers/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 869d204a70a3..8139b70cafa9 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4935,7 +4935,7 @@ int pci_bridge_wait_for_secondary_bus(struct pci_dev *dev, char *reset_type)
> delay);
> if (!pcie_wait_for_link_delay(dev, true, delay)) {
> /* Did not train, no need to wait any further */
> - pci_info(dev, "Data Link Layer Link Active not set in 1000 msec\n");
> + pci_info(dev, "Data Link Layer Link Active not set in %d msec\n", delay);
> return -ENOTTY;
> }
>
>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] PCI: fix the printed delay amount in info print
2025-04-14 0:15 [PATCH v2] PCI: fix the printed delay amount in info print Wilfred Mallawa
` (2 preceding siblings ...)
2025-04-14 13:01 ` Ilpo Järvinen
@ 2025-04-17 20:26 ` Bjorn Helgaas
3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Helgaas @ 2025-04-17 20:26 UTC (permalink / raw)
To: Wilfred Mallawa
Cc: bhelgaas, mika.westerberg, sathyanarayanan.kuppuswamy, lukas,
linux-pci, linux-kernel, alistair.francis, wilfred.mallawa,
dlemoal, cassel
On Mon, Apr 14, 2025 at 10:15:06AM +1000, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> Print the delay amount that pcie_wait_for_link_delay() is invoked with
> instead of the hardcoded 1000ms value in the debug info print.
>
> Fixes: 7b3ba09febf4 ("PCI/PM: Shorten pci_bridge_wait_for_secondary_bus() wait time for slow links")
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Applied to pci/enumeration for v6.16, thanks!
> ---
> drivers/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 869d204a70a3..8139b70cafa9 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4935,7 +4935,7 @@ int pci_bridge_wait_for_secondary_bus(struct pci_dev *dev, char *reset_type)
> delay);
> if (!pcie_wait_for_link_delay(dev, true, delay)) {
> /* Did not train, no need to wait any further */
> - pci_info(dev, "Data Link Layer Link Active not set in 1000 msec\n");
> + pci_info(dev, "Data Link Layer Link Active not set in %d msec\n", delay);
> return -ENOTTY;
> }
>
> --
> 2.49.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread