* [PATCH] dma-mapping: fix direction in dma_alloc direction traces
@ 2025-10-01 6:10 ` Petr Tesarik
2025-10-01 6:16 ` Petr Tesarik
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Petr Tesarik @ 2025-10-01 6:10 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
Sean Anderson, Marek Szyprowski, Robin Murphy
Cc: linux-trace-kernel, iommu, linux-kernel, Petr Tesarik
Set __entry->dir to the actual "dir" parameter of all trace events
in dma_alloc_class. This struct member was left uninitialized by
mistake.
Signed-off-by: Petr Tesarik <ptesarik@suse.com>
Fixes: 3afff779a725 ("dma-mapping: trace dma_alloc/free direction")
---
include/trace/events/dma.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/trace/events/dma.h b/include/trace/events/dma.h
index d8ddc27b6a7c8..945fcbaae77e9 100644
--- a/include/trace/events/dma.h
+++ b/include/trace/events/dma.h
@@ -134,6 +134,7 @@ DECLARE_EVENT_CLASS(dma_alloc_class,
__entry->dma_addr = dma_addr;
__entry->size = size;
__entry->flags = flags;
+ __entry->dir = dir;
__entry->attrs = attrs;
),
--
2.51.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dma-mapping: fix direction in dma_alloc direction traces
2025-10-01 6:10 ` [PATCH] dma-mapping: fix direction in dma_alloc direction traces Petr Tesarik
@ 2025-10-01 6:16 ` Petr Tesarik
2025-10-02 20:34 ` Sean Anderson
2025-10-03 7:00 ` Marek Szyprowski
2 siblings, 0 replies; 5+ messages in thread
From: Petr Tesarik @ 2025-10-01 6:16 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
Sean Anderson, Marek Szyprowski, Robin Murphy
Cc: linux-trace-kernel, iommu, linux-kernel, stable
Cc: stable@vger.kernel.org
(One day, I'll finally remember, I promise.)
Petr T
On Wed, 1 Oct 2025 08:10:28 +0200
Petr Tesarik <ptesarik@suse.com> wrote:
> Set __entry->dir to the actual "dir" parameter of all trace events
> in dma_alloc_class. This struct member was left uninitialized by
> mistake.
>
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> Fixes: 3afff779a725 ("dma-mapping: trace dma_alloc/free direction")
> ---
> include/trace/events/dma.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/events/dma.h b/include/trace/events/dma.h
> index d8ddc27b6a7c8..945fcbaae77e9 100644
> --- a/include/trace/events/dma.h
> +++ b/include/trace/events/dma.h
> @@ -134,6 +134,7 @@ DECLARE_EVENT_CLASS(dma_alloc_class,
> __entry->dma_addr = dma_addr;
> __entry->size = size;
> __entry->flags = flags;
> + __entry->dir = dir;
> __entry->attrs = attrs;
> ),
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dma-mapping: fix direction in dma_alloc direction traces
2025-10-01 6:10 ` [PATCH] dma-mapping: fix direction in dma_alloc direction traces Petr Tesarik
2025-10-01 6:16 ` Petr Tesarik
@ 2025-10-02 20:34 ` Sean Anderson
2025-10-03 7:00 ` Marek Szyprowski
2 siblings, 0 replies; 5+ messages in thread
From: Sean Anderson @ 2025-10-02 20:34 UTC (permalink / raw)
To: Petr Tesarik, Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
Marek Szyprowski, Robin Murphy
Cc: linux-trace-kernel, iommu, linux-kernel
On 10/1/25 02:10, Petr Tesarik wrote:
> Set __entry->dir to the actual "dir" parameter of all trace events
> in dma_alloc_class. This struct member was left uninitialized by
> mistake.
>
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> Fixes: 3afff779a725 ("dma-mapping: trace dma_alloc/free direction")
> ---
> include/trace/events/dma.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/events/dma.h b/include/trace/events/dma.h
> index d8ddc27b6a7c8..945fcbaae77e9 100644
> --- a/include/trace/events/dma.h
> +++ b/include/trace/events/dma.h
> @@ -134,6 +134,7 @@ DECLARE_EVENT_CLASS(dma_alloc_class,
> __entry->dma_addr = dma_addr;
> __entry->size = size;
> __entry->flags = flags;
> + __entry->dir = dir;
> __entry->attrs = attrs;
> ),
>
Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dma-mapping: fix direction in dma_alloc direction traces
2025-10-01 6:10 ` [PATCH] dma-mapping: fix direction in dma_alloc direction traces Petr Tesarik
2025-10-01 6:16 ` Petr Tesarik
2025-10-02 20:34 ` Sean Anderson
@ 2025-10-03 7:00 ` Marek Szyprowski
2025-10-03 7:07 ` Petr Tesarik
2 siblings, 1 reply; 5+ messages in thread
From: Marek Szyprowski @ 2025-10-03 7:00 UTC (permalink / raw)
To: Petr Tesarik, Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
Sean Anderson, Robin Murphy
Cc: linux-trace-kernel, iommu, linux-kernel
On 01.10.2025 08:10, Petr Tesarik wrote:
> Set __entry->dir to the actual "dir" parameter of all trace events
> in dma_alloc_class. This struct member was left uninitialized by
> mistake.
>
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> Fixes: 3afff779a725 ("dma-mapping: trace dma_alloc/free direction")
Applied to dma-mapping-for-next (for v6.18-rc1) branch. Thanks!
> ---
> include/trace/events/dma.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/events/dma.h b/include/trace/events/dma.h
> index d8ddc27b6a7c8..945fcbaae77e9 100644
> --- a/include/trace/events/dma.h
> +++ b/include/trace/events/dma.h
> @@ -134,6 +134,7 @@ DECLARE_EVENT_CLASS(dma_alloc_class,
> __entry->dma_addr = dma_addr;
> __entry->size = size;
> __entry->flags = flags;
> + __entry->dir = dir;
> __entry->attrs = attrs;
> ),
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dma-mapping: fix direction in dma_alloc direction traces
2025-10-03 7:00 ` Marek Szyprowski
@ 2025-10-03 7:07 ` Petr Tesarik
0 siblings, 0 replies; 5+ messages in thread
From: Petr Tesarik @ 2025-10-03 7:07 UTC (permalink / raw)
To: Marek Szyprowski
Cc: Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
Sean Anderson, Robin Murphy, linux-trace-kernel, iommu,
linux-kernel
On Fri, 3 Oct 2025 09:00:13 +0200
Marek Szyprowski <m.szyprowski@samsung.com> wrote:
> On 01.10.2025 08:10, Petr Tesarik wrote:
> > Set __entry->dir to the actual "dir" parameter of all trace events
> > in dma_alloc_class. This struct member was left uninitialized by
> > mistake.
> >
> > Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> > Fixes: 3afff779a725 ("dma-mapping: trace dma_alloc/free direction")
>
> Applied to dma-mapping-for-next (for v6.18-rc1) branch. Thanks!
Thank you for maintaining the code!
Petr T
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-10-03 7:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20251001061047eucas1p1f96a848ff2643b48179dd3e55959da7e@eucas1p1.samsung.com>
2025-10-01 6:10 ` [PATCH] dma-mapping: fix direction in dma_alloc direction traces Petr Tesarik
2025-10-01 6:16 ` Petr Tesarik
2025-10-02 20:34 ` Sean Anderson
2025-10-03 7:00 ` Marek Szyprowski
2025-10-03 7:07 ` Petr Tesarik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox