From: "Theodore Ts'o" <tytso@mit.edu>
To: Pankaj Raghav <kernel@pankajraghav.com>
Cc: libaokun@huaweicloud.com, linux-ext4@vger.kernel.org,
adilger.kernel@dilger.ca, jack@suse.cz,
linux-kernel@vger.kernel.org, mcgrof@kernel.org,
ebiggers@kernel.org, willy@infradead.org, yi.zhang@huawei.com,
yangerkun@huawei.com, chengzhihao1@huawei.com,
libaokun1@huawei.com
Subject: Re: [PATCH v2 00/24] ext4: enable block size larger than page size
Date: Mon, 10 Nov 2025 12:40:33 -0500 [thread overview]
Message-ID: <20251110174033.GG2988753@mit.edu> (raw)
In-Reply-To: <4bbea425-e896-4047-b30d-6598ff7e9165@pankajraghav.com>
On Mon, Nov 10, 2025 at 04:34:47PM +0100, Pankaj Raghav wrote:
>
> I added something similar for block devices[1]. Probably we might need something
> here as well as a stop gap.
>
> [1] https://lore.kernel.org/all/20250704092134.289491-1-p.raghav@samsung.com/
Yeah, this is the precisely code that I ran into; it's good that we're
not triggering a panic if we try mounting a file system with a large
block size, but when trying to mount file system with a large
blocksize w/o CONFIG_TRANSPARENT_HUGEPAGE, we get:
[ 33.211382] XFS (vdc): block size (65536 bytes) not supported; Only block size (4096) or less is supported
mount: /vdc: fsconfig() failed: Function not implemented.
dmesg(1) may have more information after failed mount system call.
or
[ 78.537420] EXT4-fs (vdc): bad block size 65536
Pity the poor user who is trying to use large block sizes, and who
didn't bother to enabl transparent hugepages because they didn't need
it. Fortunately most distributions tend to enable THP.
> Funny that you mention this because I have talk about this topic:
> Decoupling Large Folios from Transparent Huge Pages in LPC under MM MC [2].
> You are more than welcome to come to the talk :)
Cool! So if we're going to change it, perhaps we should have an
explicit CONFIG option, say, CONFIG_FS_LARGE_BLOCKSIZE which enables
bs > ps. This might allow us to remove smount of code for those
embedded applications who don't need large block sizes, but more
importantly, we can have it automatically enable whatever depedencies
that are needed --- and if it changes later, we can have the kernel
config DTRT automatically.
- Ted
next prev parent reply other threads:[~2025-11-10 17:41 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 14:42 [PATCH v2 00/24] ext4: enable block size larger than page size libaokun
2025-11-07 14:42 ` [PATCH v2 01/24] ext4: remove page offset calculation in ext4_block_zero_page_range() libaokun
2025-11-07 14:42 ` [PATCH v2 02/24] ext4: remove page offset calculation in ext4_block_truncate_page() libaokun
2025-11-07 14:42 ` [PATCH v2 03/24] ext4: remove PAGE_SIZE checks for rec_len conversion libaokun
2025-11-07 14:42 ` [PATCH v2 04/24] ext4: make ext4_punch_hole() support large block size libaokun
2025-11-10 9:35 ` Jan Kara
2025-11-07 14:42 ` [PATCH v2 05/24] ext4: enable DIOREAD_NOLOCK by default for BS > PS as well libaokun
2025-11-07 14:42 ` [PATCH v2 06/24] ext4: introduce s_min_folio_order for future BS > PS support libaokun
2025-11-10 12:09 ` Pankaj Raghav
2025-11-07 14:42 ` [PATCH v2 07/24] ext4: support large block size in ext4_calculate_overhead() libaokun
2025-11-10 9:36 ` Jan Kara
2025-11-07 14:42 ` [PATCH v2 08/24] ext4: support large block size in ext4_readdir() libaokun
2025-11-10 12:26 ` Pankaj Raghav
2025-11-10 13:53 ` Baokun Li
2025-11-07 14:42 ` [PATCH v2 09/24] ext4: add EXT4_LBLK_TO_B macro for logical block to bytes conversion libaokun
2025-11-07 14:42 ` [PATCH v2 10/24] ext4: add EXT4_LBLK_TO_PG and EXT4_PG_TO_LBLK for block/page conversion libaokun
2025-11-10 9:37 ` Jan Kara
2025-11-07 14:42 ` [PATCH v2 11/24] ext4: support large block size in ext4_mb_load_buddy_gfp() libaokun
2025-11-07 14:42 ` [PATCH v2 12/24] ext4: support large block size in ext4_mb_get_buddy_page_lock() libaokun
2025-11-07 14:42 ` [PATCH v2 13/24] ext4: support large block size in ext4_mb_init_cache() libaokun
2025-11-07 14:42 ` [PATCH v2 14/24] ext4: prepare buddy cache inode for BS > PS with large folios libaokun
2025-11-07 14:42 ` [PATCH v2 15/24] ext4: rename 'page' references to 'folio' in multi-block allocator libaokun
2025-11-07 14:42 ` [PATCH v2 16/24] ext4: support large block size in ext4_mpage_readpages() libaokun
2025-11-07 14:42 ` [PATCH v2 17/24] ext4: support large block size in ext4_block_write_begin() libaokun
2025-11-07 14:42 ` [PATCH v2 18/24] ext4: support large block size in mpage_map_and_submit_buffers() libaokun
2025-11-07 14:42 ` [PATCH v2 19/24] ext4: support large block size in mpage_prepare_extent_to_map() libaokun
2025-11-07 14:42 ` [PATCH v2 20/24] ext4: support large block size in __ext4_block_zero_page_range() libaokun
2025-11-07 14:42 ` [PATCH v2 21/24] ext4: make data=journal support large block size libaokun
2025-11-10 9:48 ` Jan Kara
2025-11-10 11:53 ` Baokun Li
2025-11-07 14:42 ` [PATCH v2 22/24] ext4: support verifying data from large folios with fs-verity libaokun
2025-11-10 9:54 ` Jan Kara
2025-11-10 12:08 ` Baokun Li
2025-11-07 14:42 ` [PATCH v2 23/24] ext4: add checks for large folio incompatibilities when BS > PS libaokun
2025-11-10 9:59 ` Jan Kara
2025-11-07 14:42 ` [PATCH v2 24/24] ext4: enable block size larger than page size libaokun
2025-11-10 10:00 ` Jan Kara
2025-11-10 12:51 ` Pankaj Raghav
2025-11-10 15:23 ` Theodore Ts'o
2025-11-11 3:31 ` Baokun Li
2025-11-10 15:16 ` Theodore Ts'o
2025-11-11 3:43 ` Baokun Li
2025-11-10 4:32 ` [PATCH v2 00/24] " Theodore Ts'o
2025-11-10 6:18 ` Baokun Li
2025-11-10 15:34 ` Pankaj Raghav
2025-11-10 17:40 ` Theodore Ts'o [this message]
2025-11-11 23:54 ` Theodore Ts'o
2025-11-12 2:19 ` Baokun Li
2025-11-12 4:02 ` Theodore Ts'o
2025-11-12 5:23 ` Darrick J. Wong
2025-11-12 6:27 ` Baokun Li
2025-11-12 15:29 ` Theodore Ts'o
2025-11-13 9:14 ` Baokun Li
2025-11-12 2:49 ` Baokun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110174033.GG2988753@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=chengzhihao1@huawei.com \
--cc=ebiggers@kernel.org \
--cc=jack@suse.cz \
--cc=kernel@pankajraghav.com \
--cc=libaokun1@huawei.com \
--cc=libaokun@huaweicloud.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=willy@infradead.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox