From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] objtool: Improve code generation for annotation macros
Date: Wed, 26 Nov 2025 11:00:50 +0100 [thread overview]
Message-ID: <20251126100050.GT4067720@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <cover.1764137163.git.jpoimboe@kernel.org>
On Tue, Nov 25, 2025 at 10:06:56PM -0800, Josh Poimboeuf wrote:
> For tip/objtool/core.
>
> As much as possible, undo the code generation damage introduced by
> ANNOTATE_DATA_SPECIAL:
>
> - Remove its usage in favor of SHF_MERGE + sh_entsize, where possible
>
> - Print the annotation on a single line:
>
> 912: .pushsection ".discard.annotate_data", "M", @progbits, 8; .long 912b - .; .long 1; .popsection
>
> - Remove the trailing newline/tab; let the invoking code decide on the
> appropriate separator for the given context
>
> Josh Poimboeuf (4):
> x86/alternative: Remove ANNOTATE_DATA_SPECIAL usage
> x86/asm: Remove ANNOTATE_DATA_SPECIAL usage
> objtool: Consolidate annotation macros
> objtool: Remove newlines and tabs from annotation macros
Durr, this will conflict with tip/core/bugs. Let me ponder this a bit.
next prev parent reply other threads:[~2025-11-26 10:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 6:06 [PATCH 0/4] objtool: Improve code generation for annotation macros Josh Poimboeuf
2025-11-26 6:06 ` [PATCH 1/4] x86/alternative: Remove ANNOTATE_DATA_SPECIAL usage Josh Poimboeuf
2025-11-26 6:06 ` [PATCH 2/4] x86/asm: " Josh Poimboeuf
2025-11-26 6:06 ` [PATCH 3/4] objtool: Consolidate annotation macros Josh Poimboeuf
2025-11-26 6:07 ` [PATCH 4/4] objtool: Remove newlines and tabs from " Josh Poimboeuf
2025-11-26 10:00 ` Peter Zijlstra [this message]
2025-12-03 15:59 ` [PATCH 0/4] objtool: Improve code generation for " Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251126100050.GT4067720@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox