* [PATCH] dt-bindings: display: ti,am65x-dss: Add AM62L DSS support
@ 2025-12-24 13:31 Swamil Jain
2025-12-30 2:27 ` Rob Herring
0 siblings, 1 reply; 7+ messages in thread
From: Swamil Jain @ 2025-12-24 13:31 UTC (permalink / raw)
To: jyri.sarha, tomi.valkeinen, airlied, simona, maarten.lankhorst,
mripard, tzimmermann, robh, krzk+dt, conor+dt, devarsht, praneeth,
bb, vigneshr
Cc: dri-devel, devicetree, linux-kernel, s-jain1
Update the AM65x DSS bindings to support AM62L which has a single video
port. Add conditional constraints for AM62L.
Signed-off-by: Swamil Jain <s-jain1@ti.com>
---
.../bindings/display/ti/ti,am65x-dss.yaml | 95 +++++++++++++++----
1 file changed, 76 insertions(+), 19 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
index 38fcee91211e..ce39690df4e5 100644
--- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
+++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
@@ -36,34 +36,50 @@ properties:
reg:
description:
Addresses to each DSS memory region described in the SoC's TRM.
- items:
- - description: common DSS register area
- - description: VIDL1 light video plane
- - description: VID video plane
- - description: OVR1 overlay manager for vp1
- - description: OVR2 overlay manager for vp2
- - description: VP1 video port 1
- - description: VP2 video port 2
- - description: common1 DSS register area
+ oneOf:
+ - items:
+ - description: common DSS register area
+ - description: VIDL1 light video plane
+ - description: VID video plane
+ - description: OVR1 overlay manager for vp1
+ - description: OVR2 overlay manager for vp2
+ - description: VP1 video port 1
+ - description: VP2 video port 2
+ - description: common1 DSS register area
+ - items:
+ - description: common DSS register area
+ - description: VIDL1 light video plane
+ - description: OVR1 overlay manager for vp1
+ - description: VP1 video port 1
+ - description: common1 DSS register area
reg-names:
- items:
- - const: common
- - const: vidl1
- - const: vid
- - const: ovr1
- - const: ovr2
- - const: vp1
- - const: vp2
- - const: common1
+ oneOf:
+ - items:
+ - const: common
+ - const: vidl1
+ - const: vid
+ - const: ovr1
+ - const: ovr2
+ - const: vp1
+ - const: vp2
+ - const: common1
+ - items:
+ - const: common
+ - const: vidl1
+ - const: ovr1
+ - const: vp1
+ - const: common1
clocks:
+ minItems: 2
items:
- description: fck DSS functional clock
- description: vp1 Video Port 1 pixel clock
- description: vp2 Video Port 2 pixel clock
clock-names:
+ minItems: 2
items:
- const: fck
- const: vp1
@@ -84,7 +100,8 @@ properties:
maxItems: 1
description: phandle to the associated power domain
- dma-coherent: true
+ dma-coherent:
+ type: boolean
ports:
$ref: /schemas/graph.yaml#/properties/ports
@@ -195,6 +212,46 @@ allOf:
port@0:
properties:
endpoint@1: false
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: ti,am62l-dss
+ then:
+ properties:
+ clock-names:
+ maxItems: 2
+ clocks:
+ maxItems: 2
+ reg:
+ maxItems: 5
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: ti,am62l-dss
+ then:
+ properties:
+ reg-names:
+ items:
+ - const: common
+ - const: vidl1
+ - const: ovr1
+ - const: vp1
+ - const: common1
+ else:
+ properties:
+ reg-names:
+ items:
+ - const: common
+ - const: vidl1
+ - const: vid
+ - const: ovr1
+ - const: ovr2
+ - const: vp1
+ - const: vp2
+ - const: common1
required:
- compatible
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] dt-bindings: display: ti,am65x-dss: Add AM62L DSS support
2025-12-24 13:31 [PATCH] dt-bindings: display: ti,am65x-dss: Add AM62L DSS support Swamil Jain
@ 2025-12-30 2:27 ` Rob Herring
2025-12-30 14:22 ` Swamil Jain
0 siblings, 1 reply; 7+ messages in thread
From: Rob Herring @ 2025-12-30 2:27 UTC (permalink / raw)
To: Swamil Jain
Cc: jyri.sarha, tomi.valkeinen, airlied, simona, maarten.lankhorst,
mripard, tzimmermann, krzk+dt, conor+dt, devarsht, praneeth, bb,
vigneshr, dri-devel, devicetree, linux-kernel
On Wed, Dec 24, 2025 at 07:01:50PM +0530, Swamil Jain wrote:
> Update the AM65x DSS bindings to support AM62L which has a single video
> port. Add conditional constraints for AM62L.
>
> Signed-off-by: Swamil Jain <s-jain1@ti.com>
> ---
> .../bindings/display/ti/ti,am65x-dss.yaml | 95 +++++++++++++++----
> 1 file changed, 76 insertions(+), 19 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> index 38fcee91211e..ce39690df4e5 100644
> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> @@ -36,34 +36,50 @@ properties:
> reg:
> description:
> Addresses to each DSS memory region described in the SoC's TRM.
> - items:
> - - description: common DSS register area
> - - description: VIDL1 light video plane
> - - description: VID video plane
> - - description: OVR1 overlay manager for vp1
> - - description: OVR2 overlay manager for vp2
> - - description: VP1 video port 1
> - - description: VP2 video port 2
> - - description: common1 DSS register area
> + oneOf:
> + - items:
> + - description: common DSS register area
> + - description: VIDL1 light video plane
> + - description: VID video plane
> + - description: OVR1 overlay manager for vp1
> + - description: OVR2 overlay manager for vp2
> + - description: VP1 video port 1
> + - description: VP2 video port 2
> + - description: common1 DSS register area
> + - items:
> + - description: common DSS register area
> + - description: VIDL1 light video plane
> + - description: OVR1 overlay manager for vp1
> + - description: VP1 video port 1
> + - description: common1 DSS register area
>
> reg-names:
> - items:
> - - const: common
> - - const: vidl1
> - - const: vid
> - - const: ovr1
> - - const: ovr2
> - - const: vp1
> - - const: vp2
> - - const: common1
> + oneOf:
> + - items:
> + - const: common
> + - const: vidl1
> + - const: vid
> + - const: ovr1
> + - const: ovr2
> + - const: vp1
> + - const: vp2
> + - const: common1
> + - items:
> + - const: common
> + - const: vidl1
> + - const: ovr1
> + - const: vp1
> + - const: common1
>
> clocks:
> + minItems: 2
> items:
> - description: fck DSS functional clock
> - description: vp1 Video Port 1 pixel clock
> - description: vp2 Video Port 2 pixel clock
>
> clock-names:
> + minItems: 2
> items:
> - const: fck
> - const: vp1
> @@ -84,7 +100,8 @@ properties:
> maxItems: 1
> description: phandle to the associated power domain
>
> - dma-coherent: true
> + dma-coherent:
> + type: boolean
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> @@ -195,6 +212,46 @@ allOf:
> port@0:
> properties:
> endpoint@1: false
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,am62l-dss
> + then:
> + properties:
> + clock-names:
> + maxItems: 2
> + clocks:
> + maxItems: 2
> + reg:
> + maxItems: 5
reg-names:
minItems: 8
else:
properties:
reg:
minItems: 8
reg-names:
minItems: 8
clocks needs similar constraints...
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,am62l-dss
> + then:
> + properties:
> + reg-names:
> + items:
> + - const: common
> + - const: vidl1
> + - const: ovr1
> + - const: vp1
> + - const: common1
> + else:
> + properties:
> + reg-names:
> + items:
> + - const: common
> + - const: vidl1
> + - const: vid
> + - const: ovr1
> + - const: ovr2
> + - const: vp1
> + - const: vp2
> + - const: common1
Why are you defining the names twice?
Rob
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] dt-bindings: display: ti,am65x-dss: Add AM62L DSS support
2025-12-30 2:27 ` Rob Herring
@ 2025-12-30 14:22 ` Swamil Jain
2026-01-02 22:34 ` Rob Herring
0 siblings, 1 reply; 7+ messages in thread
From: Swamil Jain @ 2025-12-30 14:22 UTC (permalink / raw)
To: Rob Herring
Cc: jyri.sarha, tomi.valkeinen, airlied, simona, maarten.lankhorst,
mripard, tzimmermann, krzk+dt, conor+dt, devarsht, praneeth, bb,
vigneshr, dri-devel, devicetree, linux-kernel
Hi Rob,
On 12/30/25 07:57, Rob Herring wrote:
> On Wed, Dec 24, 2025 at 07:01:50PM +0530, Swamil Jain wrote:
>> Update the AM65x DSS bindings to support AM62L which has a single video
>> port. Add conditional constraints for AM62L.
>>
>> Signed-off-by: Swamil Jain <s-jain1@ti.com>
>> ---
>> .../bindings/display/ti/ti,am65x-dss.yaml | 95 +++++++++++++++----
>> 1 file changed, 76 insertions(+), 19 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> index 38fcee91211e..ce39690df4e5 100644
>> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> @@ -36,34 +36,50 @@ properties:
>> reg:
>> description:
>> Addresses to each DSS memory region described in the SoC's TRM.
>> - items:
>> - - description: common DSS register area
>> - - description: VIDL1 light video plane
>> - - description: VID video plane
>> - - description: OVR1 overlay manager for vp1
>> - - description: OVR2 overlay manager for vp2
>> - - description: VP1 video port 1
>> - - description: VP2 video port 2
>> - - description: common1 DSS register area
>> + oneOf:
>> + - items:
>> + - description: common DSS register area
>> + - description: VIDL1 light video plane
>> + - description: VID video plane
>> + - description: OVR1 overlay manager for vp1
>> + - description: OVR2 overlay manager for vp2
>> + - description: VP1 video port 1
>> + - description: VP2 video port 2
>> + - description: common1 DSS register area
>> + - items:
>> + - description: common DSS register area
>> + - description: VIDL1 light video plane
>> + - description: OVR1 overlay manager for vp1
>> + - description: VP1 video port 1
>> + - description: common1 DSS register area
>>
>> reg-names:
>> - items:
>> - - const: common
>> - - const: vidl1
>> - - const: vid
>> - - const: ovr1
>> - - const: ovr2
>> - - const: vp1
>> - - const: vp2
>> - - const: common1
>> + oneOf:
>> + - items:
>> + - const: common
>> + - const: vidl1
>> + - const: vid
>> + - const: ovr1
>> + - const: ovr2
>> + - const: vp1
>> + - const: vp2
>> + - const: common1
>> + - items:
>> + - const: common
>> + - const: vidl1
>> + - const: ovr1
>> + - const: vp1
>> + - const: common1
>>
>> clocks:
>> + minItems: 2
>> items:
>> - description: fck DSS functional clock
>> - description: vp1 Video Port 1 pixel clock
>> - description: vp2 Video Port 2 pixel clock
>>
>> clock-names:
>> + minItems: 2
>> items:
>> - const: fck
>> - const: vp1
>> @@ -84,7 +100,8 @@ properties:
>> maxItems: 1
>> description: phandle to the associated power domain
>>
>> - dma-coherent: true
>> + dma-coherent:
>> + type: boolean
>>
>> ports:
>> $ref: /schemas/graph.yaml#/properties/ports
>> @@ -195,6 +212,46 @@ allOf:
>> port@0:
>> properties:
>> endpoint@1: false
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: ti,am62l-dss
>> + then:
>> + properties:
>> + clock-names:
>> + maxItems: 2
>> + clocks:
>> + maxItems: 2
>> + reg:
>> + maxItems: 5
>
> reg-names:
> minItems: 8
> else:
> properties:
> reg:
> minItems: 8
> reg-names:
> minItems: 8
>
> clocks needs similar constraints...
Sure, will add in v2.
>
>> +
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: ti,am62l-dss
>> + then:
>> + properties:
>> + reg-names:
>> + items:
>> + - const: common
>> + - const: vidl1
>> + - const: ovr1
>> + - const: vp1
>> + - const: common1
>> + else:
>> + properties:
>> + reg-names:
>> + items:
>> + - const: common
>> + - const: vidl1
>> + - const: vid
>> + - const: ovr1
>> + - const: ovr2
>> + - const: vp1
>> + - const: vp2
>> + - const: common1
>
> Why are you defining the names twice?
>
For AM62L we don't have "vid", "ovr2" and "vp2", the dtbs_check will fail.
Could you please suggest a better way?
Regards,
Swamil.
> Rob
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: display: ti,am65x-dss: Add AM62L DSS support
2025-12-30 14:22 ` Swamil Jain
@ 2026-01-02 22:34 ` Rob Herring
2026-01-16 5:51 ` Swamil Jain
2026-01-30 6:04 ` Swamil Jain
0 siblings, 2 replies; 7+ messages in thread
From: Rob Herring @ 2026-01-02 22:34 UTC (permalink / raw)
To: Swamil Jain
Cc: jyri.sarha, tomi.valkeinen, airlied, simona, maarten.lankhorst,
mripard, tzimmermann, krzk+dt, conor+dt, devarsht, praneeth, bb,
vigneshr, dri-devel, devicetree, linux-kernel
On Tue, Dec 30, 2025 at 8:23 AM Swamil Jain <s-jain1@ti.com> wrote:
>
> Hi Rob,
>
> On 12/30/25 07:57, Rob Herring wrote:
> > On Wed, Dec 24, 2025 at 07:01:50PM +0530, Swamil Jain wrote:
> >> Update the AM65x DSS bindings to support AM62L which has a single video
> >> port. Add conditional constraints for AM62L.
> >>
> >> Signed-off-by: Swamil Jain <s-jain1@ti.com>
> >> ---
> >> .../bindings/display/ti/ti,am65x-dss.yaml | 95 +++++++++++++++----
> >> 1 file changed, 76 insertions(+), 19 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> >> index 38fcee91211e..ce39690df4e5 100644
> >> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> >> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> >> @@ -36,34 +36,50 @@ properties:
> >> reg:
> >> description:
> >> Addresses to each DSS memory region described in the SoC's TRM.
> >> - items:
> >> - - description: common DSS register area
> >> - - description: VIDL1 light video plane
> >> - - description: VID video plane
> >> - - description: OVR1 overlay manager for vp1
> >> - - description: OVR2 overlay manager for vp2
> >> - - description: VP1 video port 1
> >> - - description: VP2 video port 2
> >> - - description: common1 DSS register area
> >> + oneOf:
> >> + - items:
> >> + - description: common DSS register area
> >> + - description: VIDL1 light video plane
> >> + - description: VID video plane
> >> + - description: OVR1 overlay manager for vp1
> >> + - description: OVR2 overlay manager for vp2
> >> + - description: VP1 video port 1
> >> + - description: VP2 video port 2
> >> + - description: common1 DSS register area
> >> + - items:
> >> + - description: common DSS register area
> >> + - description: VIDL1 light video plane
> >> + - description: OVR1 overlay manager for vp1
> >> + - description: VP1 video port 1
> >> + - description: common1 DSS register area
> >>
> >> reg-names:
> >> - items:
> >> - - const: common
> >> - - const: vidl1
> >> - - const: vid
> >> - - const: ovr1
> >> - - const: ovr2
> >> - - const: vp1
> >> - - const: vp2
> >> - - const: common1
> >> + oneOf:
> >> + - items:
> >> + - const: common
> >> + - const: vidl1
> >> + - const: vid
> >> + - const: ovr1
> >> + - const: ovr2
> >> + - const: vp1
> >> + - const: vp2
> >> + - const: common1
> >> + - items:
> >> + - const: common
> >> + - const: vidl1
> >> + - const: ovr1
> >> + - const: vp1
> >> + - const: common1
> >>
> >> clocks:
> >> + minItems: 2
> >> items:
> >> - description: fck DSS functional clock
> >> - description: vp1 Video Port 1 pixel clock
> >> - description: vp2 Video Port 2 pixel clock
> >>
> >> clock-names:
> >> + minItems: 2
> >> items:
> >> - const: fck
> >> - const: vp1
> >> @@ -84,7 +100,8 @@ properties:
> >> maxItems: 1
> >> description: phandle to the associated power domain
> >>
> >> - dma-coherent: true
> >> + dma-coherent:
> >> + type: boolean
> >>
> >> ports:
> >> $ref: /schemas/graph.yaml#/properties/ports
> >> @@ -195,6 +212,46 @@ allOf:
> >> port@0:
> >> properties:
> >> endpoint@1: false
> >> + - if:
> >> + properties:
> >> + compatible:
> >> + contains:
> >> + const: ti,am62l-dss
> >> + then:
> >> + properties:
> >> + clock-names:
> >> + maxItems: 2
> >> + clocks:
> >> + maxItems: 2
> >> + reg:
> >> + maxItems: 5
> >
> > reg-names:
> > minItems: 8
> > else:
> > properties:
> > reg:
> > minItems: 8
> > reg-names:
> > minItems: 8
> >
> > clocks needs similar constraints...
>
> Sure, will add in v2.
>
> >
> >> +
> >> + - if:
> >> + properties:
> >> + compatible:
> >> + contains:
> >> + const: ti,am62l-dss
> >> + then:
> >> + properties:
> >> + reg-names:
> >> + items:
> >> + - const: common
> >> + - const: vidl1
> >> + - const: ovr1
> >> + - const: vp1
> >> + - const: common1
> >> + else:
> >> + properties:
> >> + reg-names:
> >> + items:
> >> + - const: common
> >> + - const: vidl1
> >> + - const: vid
> >> + - const: ovr1
> >> + - const: ovr2
> >> + - const: vp1
> >> + - const: vp2
> >> + - const: common1
> >
> > Why are you defining the names twice?
> >
>
> For AM62L we don't have "vid", "ovr2" and "vp2", the dtbs_check will fail.
> Could you please suggest a better way?
You already defined them at the top level. Here in the if/then schema,
all you need is 'maxItems: 5' and 'minItems: 8'. But then you already
have that as well.
Rob
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: display: ti,am65x-dss: Add AM62L DSS support
2026-01-02 22:34 ` Rob Herring
@ 2026-01-16 5:51 ` Swamil Jain
2026-01-30 6:04 ` Swamil Jain
1 sibling, 0 replies; 7+ messages in thread
From: Swamil Jain @ 2026-01-16 5:51 UTC (permalink / raw)
To: Rob Herring
Cc: jyri.sarha, tomi.valkeinen, airlied, simona, maarten.lankhorst,
mripard, tzimmermann, krzk+dt, conor+dt, devarsht, praneeth, bb,
vigneshr, dri-devel, devicetree, linux-kernel
Hi Rob,
On 1/3/26 04:04, Rob Herring wrote:
> On Tue, Dec 30, 2025 at 8:23 AM Swamil Jain <s-jain1@ti.com> wrote:
>>
>> Hi Rob,
>>
>> On 12/30/25 07:57, Rob Herring wrote:
>>> On Wed, Dec 24, 2025 at 07:01:50PM +0530, Swamil Jain wrote:
>>>> Update the AM65x DSS bindings to support AM62L which has a single video
>>>> port. Add conditional constraints for AM62L.
>>>>
>>>> Signed-off-by: Swamil Jain <s-jain1@ti.com>
>>>> ---
>>>> .../bindings/display/ti/ti,am65x-dss.yaml | 95 +++++++++++++++----
>>>> 1 file changed, 76 insertions(+), 19 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>>>> index 38fcee91211e..ce39690df4e5 100644
>>>> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>>>> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>>>> @@ -36,34 +36,50 @@ properties:
>>>> reg:
>>>> description:
>>>> Addresses to each DSS memory region described in the SoC's TRM.
>>>> - items:
>>>> - - description: common DSS register area
>>>> - - description: VIDL1 light video plane
>>>> - - description: VID video plane
>>>> - - description: OVR1 overlay manager for vp1
>>>> - - description: OVR2 overlay manager for vp2
>>>> - - description: VP1 video port 1
>>>> - - description: VP2 video port 2
>>>> - - description: common1 DSS register area
>>>> + oneOf:
>>>> + - items:
>>>> + - description: common DSS register area
>>>> + - description: VIDL1 light video plane
>>>> + - description: VID video plane
>>>> + - description: OVR1 overlay manager for vp1
>>>> + - description: OVR2 overlay manager for vp2
>>>> + - description: VP1 video port 1
>>>> + - description: VP2 video port 2
>>>> + - description: common1 DSS register area
>>>> + - items:
>>>> + - description: common DSS register area
>>>> + - description: VIDL1 light video plane
>>>> + - description: OVR1 overlay manager for vp1
>>>> + - description: VP1 video port 1
>>>> + - description: common1 DSS register area
>>>>
>>>> reg-names:
>>>> - items:
>>>> - - const: common
>>>> - - const: vidl1
>>>> - - const: vid
>>>> - - const: ovr1
>>>> - - const: ovr2
>>>> - - const: vp1
>>>> - - const: vp2
>>>> - - const: common1
>>>> + oneOf:
>>>> + - items:
>>>> + - const: common
>>>> + - const: vidl1
>>>> + - const: vid
>>>> + - const: ovr1
>>>> + - const: ovr2
>>>> + - const: vp1
>>>> + - const: vp2
>>>> + - const: common1
>>>> + - items:
>>>> + - const: common
>>>> + - const: vidl1
>>>> + - const: ovr1
>>>> + - const: vp1
>>>> + - const: common1
>>>>
>>>> clocks:
>>>> + minItems: 2
>>>> items:
>>>> - description: fck DSS functional clock
>>>> - description: vp1 Video Port 1 pixel clock
>>>> - description: vp2 Video Port 2 pixel clock
>>>>
>>>> clock-names:
>>>> + minItems: 2
>>>> items:
>>>> - const: fck
>>>> - const: vp1
>>>> @@ -84,7 +100,8 @@ properties:
>>>> maxItems: 1
>>>> description: phandle to the associated power domain
>>>>
>>>> - dma-coherent: true
>>>> + dma-coherent:
>>>> + type: boolean
>>>>
>>>> ports:
>>>> $ref: /schemas/graph.yaml#/properties/ports
>>>> @@ -195,6 +212,46 @@ allOf:
>>>> port@0:
>>>> properties:
>>>> endpoint@1: false
>>>> + - if:
>>>> + properties:
>>>> + compatible:
>>>> + contains:
>>>> + const: ti,am62l-dss
>>>> + then:
>>>> + properties:
>>>> + clock-names:
>>>> + maxItems: 2
>>>> + clocks:
>>>> + maxItems: 2
>>>> + reg:
>>>> + maxItems: 5
>>>
>>> reg-names:
>>> minItems: 8
>>> else:
>>> properties:
>>> reg:
>>> minItems: 8
>>> reg-names:
>>> minItems: 8
>>>
>>> clocks needs similar constraints...
>>
>> Sure, will add in v2.
>>
>>>
>>>> +
>>>> + - if:
>>>> + properties:
>>>> + compatible:
>>>> + contains:
>>>> + const: ti,am62l-dss
>>>> + then:
>>>> + properties:
>>>> + reg-names:
>>>> + items:
>>>> + - const: common
>>>> + - const: vidl1
>>>> + - const: ovr1
>>>> + - const: vp1
>>>> + - const: common1
>>>> + else:
>>>> + properties:
>>>> + reg-names:
>>>> + items:
>>>> + - const: common
>>>> + - const: vidl1
>>>> + - const: vid
>>>> + - const: ovr1
>>>> + - const: ovr2
>>>> + - const: vp1
>>>> + - const: vp2
>>>> + - const: common1
>>>
>>> Why are you defining the names twice?
>>>
>>
>> For AM62L we don't have "vid", "ovr2" and "vp2", the dtbs_check will fail.
>> Could you please suggest a better way?
>
> You already defined them at the top level. Here in the if/then schema,
> all you need is 'maxItems: 5' and 'minItems: 8'. But then you already
> have that as well.
Is this fine or needs some changes?
Regards,
Swamil.
>
> Rob
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: display: ti,am65x-dss: Add AM62L DSS support
2026-01-02 22:34 ` Rob Herring
2026-01-16 5:51 ` Swamil Jain
@ 2026-01-30 6:04 ` Swamil Jain
2026-02-05 13:27 ` Krzysztof Kozlowski
1 sibling, 1 reply; 7+ messages in thread
From: Swamil Jain @ 2026-01-30 6:04 UTC (permalink / raw)
To: Rob Herring
Cc: jyri.sarha, tomi.valkeinen, airlied, simona, maarten.lankhorst,
mripard, tzimmermann, krzk+dt, conor+dt, devarsht, praneeth, bb,
vigneshr, dri-devel, devicetree, linux-kernel
Hi Rob,
On 1/3/26 04:04, Rob Herring wrote:
> On Tue, Dec 30, 2025 at 8:23 AM Swamil Jain <s-jain1@ti.com> wrote:
>>
>> Hi Rob,
>>
>> On 12/30/25 07:57, Rob Herring wrote:
>>> On Wed, Dec 24, 2025 at 07:01:50PM +0530, Swamil Jain wrote:
>>>> Update the AM65x DSS bindings to support AM62L which has a single video
>>>> port. Add conditional constraints for AM62L.
>>>>
>>>> Signed-off-by: Swamil Jain <s-jain1@ti.com>
>>>> ---
>>>> .../bindings/display/ti/ti,am65x-dss.yaml | 95 +++++++++++++++----
>>>> 1 file changed, 76 insertions(+), 19 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>>>> index 38fcee91211e..ce39690df4e5 100644
>>>> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>>>> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>>>> @@ -36,34 +36,50 @@ properties:
>>>> reg:
>>>> description:
>>>> Addresses to each DSS memory region described in the SoC's TRM.
>>>> - items:
>>>> - - description: common DSS register area
>>>> - - description: VIDL1 light video plane
>>>> - - description: VID video plane
>>>> - - description: OVR1 overlay manager for vp1
>>>> - - description: OVR2 overlay manager for vp2
>>>> - - description: VP1 video port 1
>>>> - - description: VP2 video port 2
>>>> - - description: common1 DSS register area
>>>> + oneOf:
>>>> + - items:
>>>> + - description: common DSS register area
>>>> + - description: VIDL1 light video plane
>>>> + - description: VID video plane
>>>> + - description: OVR1 overlay manager for vp1
>>>> + - description: OVR2 overlay manager for vp2
>>>> + - description: VP1 video port 1
>>>> + - description: VP2 video port 2
>>>> + - description: common1 DSS register area
>>>> + - items:
>>>> + - description: common DSS register area
>>>> + - description: VIDL1 light video plane
>>>> + - description: OVR1 overlay manager for vp1
>>>> + - description: VP1 video port 1
>>>> + - description: common1 DSS register area
>>>>
>>>> reg-names:
>>>> - items:
>>>> - - const: common
>>>> - - const: vidl1
>>>> - - const: vid
>>>> - - const: ovr1
>>>> - - const: ovr2
>>>> - - const: vp1
>>>> - - const: vp2
>>>> - - const: common1
>>>> + oneOf:
>>>> + - items:
>>>> + - const: common
>>>> + - const: vidl1
>>>> + - const: vid
>>>> + - const: ovr1
>>>> + - const: ovr2
>>>> + - const: vp1
>>>> + - const: vp2
>>>> + - const: common1
>>>> + - items:
>>>> + - const: common
>>>> + - const: vidl1
>>>> + - const: ovr1
>>>> + - const: vp1
>>>> + - const: common1
>>>>
>>>> clocks:
>>>> + minItems: 2
>>>> items:
>>>> - description: fck DSS functional clock
>>>> - description: vp1 Video Port 1 pixel clock
>>>> - description: vp2 Video Port 2 pixel clock
>>>>
>>>> clock-names:
>>>> + minItems: 2
>>>> items:
>>>> - const: fck
>>>> - const: vp1
>>>> @@ -84,7 +100,8 @@ properties:
>>>> maxItems: 1
>>>> description: phandle to the associated power domain
>>>>
>>>> - dma-coherent: true
>>>> + dma-coherent:
>>>> + type: boolean
>>>>
>>>> ports:
>>>> $ref: /schemas/graph.yaml#/properties/ports
>>>> @@ -195,6 +212,46 @@ allOf:
>>>> port@0:
>>>> properties:
>>>> endpoint@1: false
>>>> + - if:
>>>> + properties:
>>>> + compatible:
>>>> + contains:
>>>> + const: ti,am62l-dss
>>>> + then:
>>>> + properties:
>>>> + clock-names:
>>>> + maxItems: 2
>>>> + clocks:
>>>> + maxItems: 2
>>>> + reg:
>>>> + maxItems: 5
>>>
>>> reg-names:
>>> minItems: 8
>>> else:
>>> properties:
>>> reg:
>>> minItems: 8
>>> reg-names:
>>> minItems: 8
>>>
>>> clocks needs similar constraints...
>>
>> Sure, will add in v2.
>>
>>>
>>>> +
>>>> + - if:
>>>> + properties:
>>>> + compatible:
>>>> + contains:
>>>> + const: ti,am62l-dss
>>>> + then:
>>>> + properties:
>>>> + reg-names:
>>>> + items:
>>>> + - const: common
>>>> + - const: vidl1
>>>> + - const: ovr1
>>>> + - const: vp1
>>>> + - const: common1
>>>> + else:
>>>> + properties:
>>>> + reg-names:
>>>> + items:
>>>> + - const: common
>>>> + - const: vidl1
>>>> + - const: vid
>>>> + - const: ovr1
>>>> + - const: ovr2
>>>> + - const: vp1
>>>> + - const: vp2
>>>> + - const: common1
>>>
>>> Why are you defining the names twice?
>>>
>>
>> For AM62L we don't have "vid", "ovr2" and "vp2", the dtbs_check will fail.
>> Could you please suggest a better way?
>
> You already defined them at the top level. Here in the if/then schema,
> all you need is 'maxItems: 5' and 'minItems: 8'. But then you already
> have that as well.
>
> Rob
Posted a v2[1], could you please review if the patch looks good?
[1]: https://lore.kernel.org/all/20260129150601.185882-1-s-jain1@ti.com/
Regards,
Swamil.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: display: ti,am65x-dss: Add AM62L DSS support
2026-01-30 6:04 ` Swamil Jain
@ 2026-02-05 13:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-05 13:27 UTC (permalink / raw)
To: Swamil Jain, Rob Herring
Cc: jyri.sarha, tomi.valkeinen, airlied, simona, maarten.lankhorst,
mripard, tzimmermann, krzk+dt, conor+dt, devarsht, praneeth, bb,
vigneshr, dri-devel, devicetree, linux-kernel
On 30/01/2026 07:04, Swamil Jain wrote:
>>>>> + properties:
>>>>> + reg-names:
>>>>> + items:
>>>>> + - const: common
>>>>> + - const: vidl1
>>>>> + - const: vid
>>>>> + - const: ovr1
>>>>> + - const: ovr2
>>>>> + - const: vp1
>>>>> + - const: vp2
>>>>> + - const: common1
>>>>
>>>> Why are you defining the names twice?
>>>>
>>>
>>> For AM62L we don't have "vid", "ovr2" and "vp2", the dtbs_check will fail.
>>> Could you please suggest a better way?
>>
>> You already defined them at the top level. Here in the if/then schema,
>> all you need is 'maxItems: 5' and 'minItems: 8'. But then you already
>> have that as well.
>>
>> Rob
>
> Posted a v2[1], could you please review if the patch looks good?
>
> [1]: https://lore.kernel.org/all/20260129150601.185882-1-s-jain1@ti.com/
It is not good. Rob asked you what to do. Read his second sentence. You
posted something completely different ignoring what he asked you. Also
ignoring rules stated in the docs.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-02-05 13:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-24 13:31 [PATCH] dt-bindings: display: ti,am65x-dss: Add AM62L DSS support Swamil Jain
2025-12-30 2:27 ` Rob Herring
2025-12-30 14:22 ` Swamil Jain
2026-01-02 22:34 ` Rob Herring
2026-01-16 5:51 ` Swamil Jain
2026-01-30 6:04 ` Swamil Jain
2026-02-05 13:27 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox