From: Neel Bullywon <neelb2403@gmail.com>
To: apw@canonical.com, joe@perches.com
Cc: dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
andriy.shevchenko@intel.com, linux-kernel@vger.kernel.org,
Neel Bullywon <neelb2403@gmail.com>
Subject: [PATCH] checkpatch: suggest fsleep() for short msleep() calls
Date: Sun, 8 Feb 2026 10:59:35 -0500 [thread overview]
Message-ID: <20260208155935.72687-1-neelb2403@gmail.com> (raw)
Update the MSLEEP warning to suggest fsleep() as a duration based
sleep API. fsleep() autoselects the best sleep mechanism (udelay,
usleep_range, or msleep) based on the requested duration, making
it the preferred replacement for short msleep() calls.
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Neel Bullywon <neelb2403@gmail.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c0250244cf7a..c27045f9f13d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6636,7 +6636,7 @@ sub process {
if ($line =~ /\bmsleep\s*\((\d+)\);/) {
if ($1 < 20) {
WARN("MSLEEP",
- "msleep < 20ms can sleep for up to 20ms; see function description of msleep().\n" . $herecurr);
+ "msleep < 20ms can sleep for up to 20ms; see function description of fsleep().\n" . $herecurr);
}
}
base-commit: e7aa57247700733e52a8e2e4dee6a52c2a76de02
--
2.44.0
next reply other threads:[~2026-02-08 15:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 15:59 Neel Bullywon [this message]
2026-02-08 16:36 ` [PATCH] checkpatch: suggest fsleep() for short msleep() calls Joe Perches
2026-02-08 18:41 ` Neel Bullywon
2026-02-08 18:44 ` Joe Perches
2026-02-09 8:32 ` Andy Shevchenko
2026-02-09 8:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260208155935.72687-1-neelb2403@gmail.com \
--to=neelb2403@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox