From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Neel Bullywon <neelb2403@gmail.com>
Cc: apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com,
lukas.bulwahn@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: suggest fsleep() for short msleep() calls
Date: Mon, 9 Feb 2026 10:32:39 +0200 [thread overview]
Message-ID: <aYmbp4VL7X9QTx9P@smile.fi.intel.com> (raw)
In-Reply-To: <20260208155935.72687-1-neelb2403@gmail.com>
On Sun, Feb 08, 2026 at 10:59:35AM -0500, Neel Bullywon wrote:
> Update the MSLEEP warning to suggest fsleep() as a duration based
> sleep API. fsleep() autoselects the best sleep mechanism (udelay,
> usleep_range, or msleep) based on the requested duration, making
> it the preferred replacement for short msleep() calls.
Hmm... My understanding was that the warning itself has a mention of
usleep_range(). Looking at the patch I think the current wording is
okay, but it may be expanded to suggest fsleep().
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-09 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 15:59 [PATCH] checkpatch: suggest fsleep() for short msleep() calls Neel Bullywon
2026-02-08 16:36 ` Joe Perches
2026-02-08 18:41 ` Neel Bullywon
2026-02-08 18:44 ` Joe Perches
2026-02-09 8:32 ` Andy Shevchenko [this message]
2026-02-09 8:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYmbp4VL7X9QTx9P@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=neelb2403@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox