The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Neel Bullywon <neelb2403@gmail.com>
To: joe@perches.com
Cc: apw@canonical.com, dwaipayanray1@gmail.com,
	lukas.bulwahn@gmail.com, andriy.shevchenko@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: suggest fsleep() for short msleep() calls
Date: Sun,  8 Feb 2026 13:41:19 -0500	[thread overview]
Message-ID: <20260208184119.74729-1-neelb2403@gmail.com> (raw)
In-Reply-To: <67577c238ead009b3b061a43d443dc69da2aee64.camel@perches.com>

On Sun, 2026-02-08 at 08:36 -0800, Joe Perches wrote:
> maybe change msleep to a #define macro so if the argument is
> constant call fsleep instead

Thanks for the suggestion, I'd like to implement this for a v2 but
want to clarify a few things.

1. fsleep() is static inline and calls msleep() on line 134 of
   delay.h. Since inline functions are expanded at the call site,
   the msleep() macro would expand inside fsleep() at every call
   site even if the macro is defined after fsleep(). I'd need to
   change that call to (msleep)() to suppress expansion. Same for
   ssleep() on line 103. Does that sound right?

2. Should this be a single patch or a small series of patches?

  reply	other threads:[~2026-02-08 18:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-08 15:59 [PATCH] checkpatch: suggest fsleep() for short msleep() calls Neel Bullywon
2026-02-08 16:36 ` Joe Perches
2026-02-08 18:41   ` Neel Bullywon [this message]
2026-02-08 18:44   ` Joe Perches
2026-02-09  8:32 ` Andy Shevchenko
2026-02-09  8:34   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260208184119.74729-1-neelb2403@gmail.com \
    --to=neelb2403@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=apw@canonical.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox