[PATCH v2] staging: rtl8723bs: Clean up unnecessary parentheses and braces

[PATCH v2] staging: rtl8723bs: Clean up unnecessary parentheses and braces

[Eduard Bostina]

Increase code readability and follow Linux kernel coding style by
removing unnecessary parentheses and braces.

This also fixes the following checkpatch.pl issues:
WARNING: Unnecessary parentheses - maybe == should be = ?
WARNING: braces {} are not necessary for any arm of this statement

Signed-off-by: Eduard Bostina <egbostina@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 1a52d3e1d285d..a1c2220ac476b 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1339,11 +1339,10 @@ static signed int validate_recv_data_frame(struct adapter *adapter, union recv_f
 
 	}
 
-	if (ret == _FAIL) {
+	if (ret == _FAIL)
 		goto exit;
-	} else if (ret == RTW_RX_HANDLED) {
+	else if (ret == RTW_RX_HANDLED)
 		goto exit;
-	}
 
 
 	if (!psta) {
@@ -1593,7 +1592,7 @@ static signed int wlanhdr_to_ethhdr(union recv_frame *precvframe)
 	eth_type = ntohs(be_tmp); /* pattrib->ether_type */
 	pattrib->eth_type = eth_type;
 
-	if ((check_fwstate(pmlmepriv, WIFI_MP_STATE) == true)) {
+	if (check_fwstate(pmlmepriv, WIFI_MP_STATE) == true) {
 		ptr += rmv_len;
 		*ptr = 0x87;
 		*(ptr + 1) = 0x12;
-- 
2.43.0

Re: [PATCH v2] staging: rtl8723bs: Clean up unnecessary parentheses and braces

[Greg KH]

On Wed, Mar 04, 2026 at 03:34:26PM +0000, Eduard Bostina wrote:
> Increase code readability and follow Linux kernel coding style by
> removing unnecessary parentheses and braces.
> 
> This also fixes the following checkpatch.pl issues:
> WARNING: Unnecessary parentheses - maybe == should be = ?
> WARNING: braces {} are not necessary for any arm of this statement
> 
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 1a52d3e1d285d..a1c2220ac476b 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1339,11 +1339,10 @@ static signed int validate_recv_data_frame(struct adapter *adapter, union recv_f
>  
>  	}
>  
> -	if (ret == _FAIL) {
> +	if (ret == _FAIL)
>  		goto exit;
> -	} else if (ret == RTW_RX_HANDLED) {
> +	else if (ret == RTW_RX_HANDLED)
>  		goto exit;
> -	}
>  
>  
>  	if (!psta) {
> @@ -1593,7 +1592,7 @@ static signed int wlanhdr_to_ethhdr(union recv_frame *precvframe)
>  	eth_type = ntohs(be_tmp); /* pattrib->ether_type */
>  	pattrib->eth_type = eth_type;
>  
> -	if ((check_fwstate(pmlmepriv, WIFI_MP_STATE) == true)) {
> +	if (check_fwstate(pmlmepriv, WIFI_MP_STATE) == true) {
>  		ptr += rmv_len;
>  		*ptr = 0x87;
>  		*(ptr + 1) = 0x12;
> -- 
> 2.43.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH v2] staging: rtl8723bs: Clean up unnecessary parentheses and braces

[Daniel Baluta]

On 3/4/26 17:34, Eduard Bostina wrote:
> Increase code readability and follow Linux kernel coding style by
> removing unnecessary parentheses and braces.
>
> This also fixes the following checkpatch.pl issues:
> WARNING: Unnecessary parentheses - maybe == should be = ?
> WARNING: braces {} are not necessary for any arm of this statement
>
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
>
Hi Eduard, This looks good to me!

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>

As for the v2 in the subject, you should always start fresh

when sending a patch to the community no matter on how many reviews we did in private.

Community is not aware of that and having [PATCH v2] is confusing.

Greg,

Should Eduard send the patch again and remove v2? Or is this patch still fine.