From: David Laight <david.laight.linux@gmail.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Willy Tarreau <w@1wt.eu>, Daniel Palmer <daniel@thingy.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] tools/nolibc: also handle _llseek system call
Date: Sat, 18 Apr 2026 12:23:40 +0100 [thread overview]
Message-ID: <20260418122340.1dc07834@pumpkin> (raw)
In-Reply-To: <20260418-nolibc-largefile-v1-1-b91f0775bac3@weissschuh.net>
On Sat, 18 Apr 2026 12:19:56 +0200
Thomas Weißschuh <linux@weissschuh.net> wrote:
> On some architectures the llseek system call contains a leading
> underscore. Also check for that one and prefer it over the lseek system
> call as it is necessary for 64-bit offset handling.
>
...
> +#if defined(__NR_llseek)
> + nr_llseek = __NR_llseek;
> +#else
> + nr_llseek = __NR__llseek;
> +#endif
Is that test the right way around?
The commit messages says prefer _llseek, but that seems to prefer llseek.
David
> +
> + ret = __nolibc_syscall5(nr_llseek, fd, offset >> 32, (uint32_t)offset, &loff, whence);
> if (ret < 0)
> result = ret;
> else
>
next prev parent reply other threads:[~2026-04-18 11:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 10:19 [PATCH 0/7] tools/nolibc: large file support Thomas Weißschuh
2026-04-18 10:19 ` [PATCH 1/7] tools/nolibc: also handle _llseek system call Thomas Weißschuh
2026-04-18 11:23 ` David Laight [this message]
2026-04-18 11:56 ` Thomas Weißschuh
2026-04-18 16:03 ` David Laight
2026-04-18 10:19 ` [PATCH 2/7] tools/nolibc: add __nolibc_arg_to_reg() Thomas Weißschuh
2026-04-18 10:19 ` [PATCH 3/7] tools/nolibc: cast pointers returned from system calls through integers Thomas Weißschuh
2026-04-18 10:19 ` [PATCH 4/7] tools/nolibc: handle 64-bit system call arguments on x32 Thomas Weißschuh
2026-04-18 10:20 ` [PATCH 5/7] tools/nolibc: handle 64-bit system call arguments on MIPS N32 Thomas Weißschuh
2026-04-18 11:14 ` David Laight
2026-04-18 11:54 ` Thomas Weißschuh
2026-04-18 16:32 ` David Laight
2026-04-18 10:20 ` [PATCH 6/7] tools/nolibc: open files with O_LARGEFILE Thomas Weißschuh
2026-04-18 10:20 ` [PATCH 7/7] selftests/nolibc: test large file support Thomas Weißschuh
2026-04-18 14:01 ` [PATCH 0/7] tools/nolibc: " Daniel Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260418122340.1dc07834@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=daniel@thingy.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox