* [PATCH] staging: rtl8723bs: remove unused offset in phase 2 _BlockWrite()
@ 2026-04-20 4:46 Robertus Diawan Chris
2026-04-20 23:16 ` Ethan Tidmore
2026-04-21 14:33 ` Luka Gejak
0 siblings, 2 replies; 3+ messages in thread
From: Robertus Diawan Chris @ 2026-04-20 4:46 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, linux-kernel-mentees, skhan, me
Commit c1314fe4d28f ("staging: rtl8723bs: remove all RT_TRACE logs
in hal/ and os_dep/") removed the unnecessary RT_TRACE logs in hal/
and os_dep/ files, but left the variable "offset" in the Phase 2
_BlockWrite() function unused, so delete it.
This is reported by Coverity Scan with CID 1408950 as UNUSED_VALUE.
Signed-off-by: Robertus Diawan Chris <robertusdchris@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index e794fe3caf9d..988829d5f3c3 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -68,8 +68,6 @@ static int _BlockWrite(struct adapter *padapter, void *buffer, u32 buffSize)
/* 3 Phase #2 */
if (remainSize_p1) {
- offset = blockCount_p1 * blockSize_p1;
-
blockCount_p2 = remainSize_p1/blockSize_p2;
remainSize_p2 = remainSize_p1%blockSize_p2;
}
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: rtl8723bs: remove unused offset in phase 2 _BlockWrite()
2026-04-20 4:46 [PATCH] staging: rtl8723bs: remove unused offset in phase 2 _BlockWrite() Robertus Diawan Chris
@ 2026-04-20 23:16 ` Ethan Tidmore
2026-04-21 14:33 ` Luka Gejak
1 sibling, 0 replies; 3+ messages in thread
From: Ethan Tidmore @ 2026-04-20 23:16 UTC (permalink / raw)
To: Robertus Diawan Chris, gregkh
Cc: linux-staging, linux-kernel, linux-kernel-mentees, skhan, me
On Sun Apr 19, 2026 at 11:46 PM CDT, Robertus Diawan Chris wrote:
> Commit c1314fe4d28f ("staging: rtl8723bs: remove all RT_TRACE logs
> in hal/ and os_dep/") removed the unnecessary RT_TRACE logs in hal/
> and os_dep/ files, but left the variable "offset" in the Phase 2
> _BlockWrite() function unused, so delete it.
>
> This is reported by Coverity Scan with CID 1408950 as UNUSED_VALUE.
>
> Signed-off-by: Robertus Diawan Chris <robertusdchris@gmail.com>
> ---
LGTM.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: rtl8723bs: remove unused offset in phase 2 _BlockWrite()
2026-04-20 4:46 [PATCH] staging: rtl8723bs: remove unused offset in phase 2 _BlockWrite() Robertus Diawan Chris
2026-04-20 23:16 ` Ethan Tidmore
@ 2026-04-21 14:33 ` Luka Gejak
1 sibling, 0 replies; 3+ messages in thread
From: Luka Gejak @ 2026-04-21 14:33 UTC (permalink / raw)
To: Robertus Diawan Chris, gregkh
Cc: linux-staging, linux-kernel, linux-kernel-mentees, skhan, me
On Mon Apr 20, 2026 at 6:46 AM CEST, Robertus Diawan Chris wrote:
> Commit c1314fe4d28f ("staging: rtl8723bs: remove all RT_TRACE logs
> in hal/ and os_dep/") removed the unnecessary RT_TRACE logs in hal/
> and os_dep/ files, but left the variable "offset" in the Phase 2
> _BlockWrite() function unused, so delete it.
>
> This is reported by Coverity Scan with CID 1408950 as UNUSED_VALUE.
>
> Signed-off-by: Robertus Diawan Chris <robertusdchris@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> index e794fe3caf9d..988829d5f3c3 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> @@ -68,8 +68,6 @@ static int _BlockWrite(struct adapter *padapter, void *buffer, u32 buffSize)
>
> /* 3 Phase #2 */
> if (remainSize_p1) {
> - offset = blockCount_p1 * blockSize_p1;
> -
> blockCount_p2 = remainSize_p1/blockSize_p2;
> remainSize_p2 = remainSize_p1%blockSize_p2;
> }
LGTM.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-21 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-20 4:46 [PATCH] staging: rtl8723bs: remove unused offset in phase 2 _BlockWrite() Robertus Diawan Chris
2026-04-20 23:16 ` Ethan Tidmore
2026-04-21 14:33 ` Luka Gejak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox