* [PATCH] drm/panel: feiyang-fy07024di26a30d: return display-on error
@ 2026-04-25 5:39 Christian Van
2026-04-27 7:43 ` Neil Armstrong
2026-05-05 12:51 ` Neil Armstrong
0 siblings, 2 replies; 3+ messages in thread
From: Christian Van @ 2026-04-25 5:39 UTC (permalink / raw)
To: Jagan Teki, Neil Armstrong
Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel, Christian Van
mipi_dsi_dcs_set_display_on() returns an error code, but feiyang_enable()
currently ignores it and always reports success.
Return the DCS command result so callers can observe enable failures.
Signed-off-by: Christian Van <cvan20191@gmail.com>
---
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
index 4f8d6d8c0..dbdb7e3cb 100644
--- a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
+++ b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
@@ -98,9 +98,7 @@ static int feiyang_enable(struct drm_panel *panel)
/* T12 (video & logic signal rise + backlight rise) T12 >= 200ms */
msleep(200);
- mipi_dsi_dcs_set_display_on(ctx->dsi);
-
- return 0;
+ return mipi_dsi_dcs_set_display_on(ctx->dsi);
}
static int feiyang_disable(struct drm_panel *panel)
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: feiyang-fy07024di26a30d: return display-on error
2026-04-25 5:39 [PATCH] drm/panel: feiyang-fy07024di26a30d: return display-on error Christian Van
@ 2026-04-27 7:43 ` Neil Armstrong
2026-05-05 12:51 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2026-04-27 7:43 UTC (permalink / raw)
To: Christian Van, Jagan Teki
Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel
On 4/25/26 07:39, Christian Van wrote:
> mipi_dsi_dcs_set_display_on() returns an error code, but feiyang_enable()
> currently ignores it and always reports success.
>
> Return the DCS command result so callers can observe enable failures.
>
> Signed-off-by: Christian Van <cvan20191@gmail.com>
> ---
> drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
> index 4f8d6d8c0..dbdb7e3cb 100644
> --- a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
> +++ b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
> @@ -98,9 +98,7 @@ static int feiyang_enable(struct drm_panel *panel)
> /* T12 (video & logic signal rise + backlight rise) T12 >= 200ms */
> msleep(200);
>
> - mipi_dsi_dcs_set_display_on(ctx->dsi);
> -
> - return 0;
> + return mipi_dsi_dcs_set_display_on(ctx->dsi);
> }
>
> static int feiyang_disable(struct drm_panel *panel)
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: feiyang-fy07024di26a30d: return display-on error
2026-04-25 5:39 [PATCH] drm/panel: feiyang-fy07024di26a30d: return display-on error Christian Van
2026-04-27 7:43 ` Neil Armstrong
@ 2026-05-05 12:51 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2026-05-05 12:51 UTC (permalink / raw)
To: Jagan Teki, Christian Van
Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel
Hi,
On Sat, 25 Apr 2026 01:39:48 -0400, Christian Van wrote:
> mipi_dsi_dcs_set_display_on() returns an error code, but feiyang_enable()
> currently ignores it and always reports success.
>
> Return the DCS command result so callers can observe enable failures.
Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)
[1/1] drm/panel: feiyang-fy07024di26a30d: return display-on error
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/c67e8787f6743101c90c7a9c4bb7cf6f1f739f83
--
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-05 12:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-25 5:39 [PATCH] drm/panel: feiyang-fy07024di26a30d: return display-on error Christian Van
2026-04-27 7:43 ` Neil Armstrong
2026-05-05 12:51 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox