public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	mingo@kernel.org, christophe.jaillet@wanadoo.fr,
	nabijaczleweli@nabijaczleweli.xyz, kees@kernel.org,
	kyungmin.park@samsung.com, k.wrona@samsung.com,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 3/9] iio: ssp_sensors: cancel delayed work_refresh on remove
Date: Sun, 26 Apr 2026 15:09:12 +0100	[thread overview]
Message-ID: <20260426150912.765d5985@jic23-huawei> (raw)
In-Reply-To: <20260426091710.3722035-4-sanjayembedded@gmail.com>

On Sun, 26 Apr 2026 14:47:04 +0530
Sanjay Chitroda <sanjayembeddedse@gmail.com> wrote:

> From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
> 
> The work_refresh may still be pending or running when the device is
> removed, cancel the delayed work_refresh in remove path.
> 
> Fixes: 50dd64d57eee ("iio: common: ssp_sensors: Add sensorhub driver")

Fixes at start of patch series not after some refactors of unrelated
code.

> Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
> ---
>  drivers/iio/common/ssp_sensors/ssp_dev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
> index 7d07fae295fd..51730dae5871 100644
> --- a/drivers/iio/common/ssp_sensors/ssp_dev.c
> +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
> @@ -590,6 +590,7 @@ static void ssp_remove(struct spi_device *spi)
>  	ssp_clean_pending_list(data);
>  
>  	free_irq(data->spi->irq, data);
> +	cancel_delayed_work_sync(&data->work_refresh);
>  
>  	timer_delete_sync(&data->wdt_timer);
>  	cancel_work_sync(&data->work_wdt);


  reply	other threads:[~2026-04-26 14:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-26  9:17 [PATCH v7 0/9] iio: ssp_sensors: improve resource cleanup Sanjay Chitroda
2026-04-26  9:17 ` [PATCH v7 1/9] iio: ssp_sensors: cleanup codestyle warning Sanjay Chitroda
2026-04-26 13:53   ` Jonathan Cameron
2026-04-29 18:12     ` Sanjay Chitroda
2026-04-26  9:17 ` [PATCH v7 2/9] iio: ssp_sensors: factor out pending list add/remove helper(s) Sanjay Chitroda
2026-04-26 14:08   ` Jonathan Cameron
2026-04-27  8:05     ` Andy Shevchenko
2026-05-03 11:23     ` Sanjay Chitroda
2026-05-05 16:38       ` Jonathan Cameron
2026-04-26  9:17 ` [PATCH v7 3/9] iio: ssp_sensors: cancel delayed work_refresh on remove Sanjay Chitroda
2026-04-26 14:09   ` Jonathan Cameron [this message]
2026-04-29 18:06     ` Sanjay Chitroda
2026-04-29 18:09       ` Jonathan Cameron
2026-04-26  9:17 ` [PATCH v7 4/9] iio: ssp_sensors: factor out mcu enable/disable helper(s) Sanjay Chitroda
2026-04-26 14:13   ` Jonathan Cameron
2026-04-26  9:17 ` [PATCH v7 5/9] iio: ssp_sensors: use local struct device Sanjay Chitroda
2026-04-26 14:16   ` Jonathan Cameron
2026-04-27  8:09     ` Andy Shevchenko
2026-05-03 12:06       ` Sanjay Chitroda
2026-04-26  9:17 ` [PATCH v7 6/9] iio: ssp_sensors: Drop duplicated wdt timer and work cleanup Sanjay Chitroda
2026-04-27  8:17   ` Andy Shevchenko
2026-05-03 13:06     ` Sanjay Chitroda
2026-04-26  9:17 ` [PATCH v7 7/9] iio: ssp_sensors: convert probe and teardown to devm-managed resources Sanjay Chitroda
2026-04-26  9:17 ` [PATCH v7 8/9] iio: ssp_sensors: Use dev_err_probe Sanjay Chitroda
2026-04-26 14:24   ` Jonathan Cameron
2026-04-27  8:20     ` Andy Shevchenko
2026-04-27  8:19   ` Andy Shevchenko
2026-04-26  9:17 ` [PATCH v7 9/9] iio: ssp_sensors: reuse embedded RX buffer for SPI transfers Sanjay Chitroda
2026-04-26 14:31   ` Jonathan Cameron
2026-05-03 15:02     ` Sanjay Chitroda
2026-04-26 14:35   ` Jonathan Cameron
2026-05-03 14:17     ` Sanjay Chitroda
2026-05-04  8:41       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260426150912.765d5985@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dlechner@baylibre.com \
    --cc=k.wrona@samsung.com \
    --cc=kees@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=nabijaczleweli@nabijaczleweli.xyz \
    --cc=nuno.sa@analog.com \
    --cc=sanjayembeddedse@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox