Re: [PATCH v7 1/9] iio: ssp_sensors: cleanup codestyle warning

[David Lechner <dlechner@baylibre.com>]

On 4/26/26 8:53 AM, Jonathan Cameron wrote:
> On Sun, 26 Apr 2026 14:47:02 +0530
> Sanjay Chitroda <sanjayembeddedse@gmail.com> wrote:
> 
>> From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
>>
>> Reported by checkpatch:
>> FILE: drivers/iio/common/ssp_sensors/ssp_dev.c
>>
>> WARNING: Prefer __packed over __attribute__((__packed__))
>> +} __attribute__((__packed__));
>>
>> Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
> Applied to the testing branch of iio.git.
> 
> I'm trying to pick up some of the patches on list just
> to reduce how many are getting sent in new revisions and
> the time it takes people to look at them each time.
> 
> Not sure how far I'll get in your series so look out for
> when I stop saying I've applied them.
> 
> thanks,
> 
> Jonathan
> 
>> ---
>>  drivers/iio/common/ssp_sensors/ssp_dev.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
>> index da09c9f3ceb6..7d07fae295fd 100644
>> --- a/drivers/iio/common/ssp_sensors/ssp_dev.c
>> +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
>> @@ -28,7 +28,7 @@ struct ssp_instruction {
>>  	__le32 a;
>>  	__le32 b;
>>  	u8 c;
>> -} __attribute__((__packed__));
>> +} __packed__;

Too late now, but this isn't the recommended `__packed` as it was
in the first 6 revisions of this patch and there is no changelog
to explain why it was changed.

>>  
>>  static const u8 ssp_magnitude_table[] = {110, 85, 171, 71, 203, 195, 0, 67,
>>  	208, 56, 175, 244, 206, 213, 0, 92, 250, 0, 55, 48, 189, 252, 171,
>