[PATCH] m68k: coldfire: select legacy gpiolib interface for mcfqspi

[PATCH] m68k: coldfire: select legacy gpiolib interface for mcfqspi

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

The common coldfire code uses the old GPIO number based interfaces for
at least the QSPI chipselect lines. Select the required Kconfig symbol
to keep it building when that becomes optional.

Apparently there are no devices attached to a QSPI controller in any of
the coldfire boards, so this is not actually used in upstream kernels.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/m68k/Kconfig.cpu | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
index c9a7e602d8a4..148f8a79d206 100644
--- a/arch/m68k/Kconfig.cpu
+++ b/arch/m68k/Kconfig.cpu
@@ -30,6 +30,7 @@ config COLDFIRE
 	select CPU_HAS_NO_MULDIV64
 	select GENERIC_CSUM
 	select GPIOLIB
+	select GPIOLIB_LEGACY if SPI_COLDFIRE_QSPI
 	select HAVE_LEGACY_CLK
 	select HAVE_PAGE_SIZE_8KB if !MMU
 
-- 
2.39.5

Re: [PATCH] m68k: coldfire: select legacy gpiolib interface for mcfqspi

[Geert Uytterhoeven]

CC Greg

On Tue, 28 Apr 2026 at 17:57, Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The common coldfire code uses the old GPIO number based interfaces for
> at least the QSPI chipselect lines. Select the required Kconfig symbol
> to keep it building when that becomes optional.
>
> Apparently there are no devices attached to a QSPI controller in any of
> the coldfire boards, so this is not actually used in upstream kernels.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/m68k/Kconfig.cpu | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
> index c9a7e602d8a4..148f8a79d206 100644
> --- a/arch/m68k/Kconfig.cpu
> +++ b/arch/m68k/Kconfig.cpu
> @@ -30,6 +30,7 @@ config COLDFIRE
>         select CPU_HAS_NO_MULDIV64
>         select GENERIC_CSUM
>         select GPIOLIB
> +       select GPIOLIB_LEGACY if SPI_COLDFIRE_QSPI
>         select HAVE_LEGACY_CLK
>         select HAVE_PAGE_SIZE_8KB if !MMU
>
> --
> 2.39.5

Re: [PATCH] m68k: coldfire: select legacy gpiolib interface for mcfqspi

[Greg Ungerer]

Hi Arnd,

On 29/4/26 01:57, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The common coldfire code uses the old GPIO number based interfaces for
> at least the QSPI chipselect lines. Select the required Kconfig symbol
> to keep it building when that becomes optional.
> 
> Apparently there are no devices attached to a QSPI controller in any of
> the coldfire boards, so this is not actually used in upstream kernels.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied to m68knommu for-next branch.

Regards
Greg



> ---
>   arch/m68k/Kconfig.cpu | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
> index c9a7e602d8a4..148f8a79d206 100644
> --- a/arch/m68k/Kconfig.cpu
> +++ b/arch/m68k/Kconfig.cpu
> @@ -30,6 +30,7 @@ config COLDFIRE
>   	select CPU_HAS_NO_MULDIV64
>   	select GENERIC_CSUM
>   	select GPIOLIB
> +	select GPIOLIB_LEGACY if SPI_COLDFIRE_QSPI
>   	select HAVE_LEGACY_CLK
>   	select HAVE_PAGE_SIZE_8KB if !MMU
>