* [PATCH] x86/boot: remove commented out code in getchar()
@ 2026-04-29 10:17 Thorsten Blum
2026-04-29 15:57 ` H. Peter Anvin
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2026-04-29 10:17 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86,
H. Peter Anvin
Cc: Thorsten Blum, linux-kernel
The code has been commented out ever since commit df7699c56421 ("x86,
setup: "glove box" BIOS interrupts in the core boot code") - remove it.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/x86/boot/tty.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/boot/tty.c b/arch/x86/boot/tty.c
index f7eb976b0a4b..3ca8115ef5eb 100644
--- a/arch/x86/boot/tty.c
+++ b/arch/x86/boot/tty.c
@@ -88,7 +88,6 @@ int getchar(void)
struct biosregs ireg, oreg;
initregs(&ireg);
- /* ireg.ah = 0x00; */
intcall(0x16, &ireg, &oreg);
return oreg.al;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] x86/boot: remove commented out code in getchar()
2026-04-29 10:17 [PATCH] x86/boot: remove commented out code in getchar() Thorsten Blum
@ 2026-04-29 15:57 ` H. Peter Anvin
0 siblings, 0 replies; 2+ messages in thread
From: H. Peter Anvin @ 2026-04-29 15:57 UTC (permalink / raw)
To: Thorsten Blum, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, x86
Cc: linux-kernel
On April 29, 2026 3:17:09 AM PDT, Thorsten Blum <thorsten.blum@linux.dev> wrote:
>The code has been commented out ever since commit df7699c56421 ("x86,
>setup: "glove box" BIOS interrupts in the core boot code") - remove it.
>
>Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>---
> arch/x86/boot/tty.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/arch/x86/boot/tty.c b/arch/x86/boot/tty.c
>index f7eb976b0a4b..3ca8115ef5eb 100644
>--- a/arch/x86/boot/tty.c
>+++ b/arch/x86/boot/tty.c
>@@ -88,7 +88,6 @@ int getchar(void)
> struct biosregs ireg, oreg;
>
> initregs(&ireg);
>- /* ireg.ah = 0x00; */
> intcall(0x16, &ireg, &oreg);
>
> return oreg.al;
NAK.
It's a comment: it isn't necessary to set ireg.ah to zero there because it is already zero.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-29 15:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-29 10:17 [PATCH] x86/boot: remove commented out code in getchar() Thorsten Blum
2026-04-29 15:57 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox