public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Arnd Bergmann <arnd@kernel.org>, Steve French <sfrench@samba.org>,
	Enzo Matsumiya <ematsumiya@suse.de>
Cc: oe-kbuild-all@lists.linux.dev, Arnd Bergmann <arnd@arndb.de>,
	Paulo Alcantara <pc@manguebit.org>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Shyam Prasad N <sprasad@microsoft.com>,
	Tom Talpey <tom@talpey.com>, Bharath SM <bharathsm@microsoft.com>,
	Stefan Metzmacher <metze@samba.org>,
	Namjae Jeon <linkinjeon@kernel.org>,
	linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops
Date: Thu, 30 Apr 2026 04:37:37 +0800	[thread overview]
Message-ID: <202604300441.heF8QVnl-lkp@intel.com> (raw)
In-Reply-To: <20260423065042.1898971-1-arnd@kernel.org>

Hi Arnd,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20260424]
[also build test WARNING on linus/master v7.1-rc1]
[cannot apply to v7.0 v7.0-rc7 v7.0-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Arnd-Bergmann/smb-client-hide-unused-cifs_debug_dirs_proc_ops/20260426-163431
base:   next-20260424
patch link:    https://lore.kernel.org/r/20260423065042.1898971-1-arnd%40kernel.org
patch subject: [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops
config: microblaze-defconfig (https://download.01.org/0day-ci/archive/20260430/202604300441.heF8QVnl-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260430/202604300441.heF8QVnl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604300441.heF8QVnl-lkp@intel.com/

All warnings (new ones prefixed by >>):

   fs/smb/client/cifs_debug.c: In function 'cifs_proc_init':
   fs/smb/client/cifs_debug.c:937:55: error: 'cifs_debug_dirs_proc_ops' undeclared (first use in this function); did you mean 'cifs_debug_dirs_proc_show'?
     937 |         proc_create("open_dirs", 0600, proc_fs_cifs, &cifs_debug_dirs_proc_ops);
         |                                                       ^~~~~~~~~~~~~~~~~~~~~~~~
         |                                                       cifs_debug_dirs_proc_show
   fs/smb/client/cifs_debug.c:937:55: note: each undeclared identifier is reported only once for each function it appears in
   fs/smb/client/cifs_debug.c: At top level:
>> fs/smb/client/cifs_debug.c:298:12: warning: 'cifs_debug_dirs_proc_show' defined but not used [-Wunused-function]
     298 | static int cifs_debug_dirs_proc_show(struct seq_file *m, void *v)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +/cifs_debug_dirs_proc_show +298 fs/smb/client/cifs_debug.c

dfe33f9abc08997 fs/cifs/cifs_debug.c       Steve French   2018-10-30  297  
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28 @298  static int cifs_debug_dirs_proc_show(struct seq_file *m, void *v)
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  299  {
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  300  	struct list_head *stmp, *tmp, *tmp1;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  301  	struct TCP_Server_Info *server;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  302  	struct cifs_ses *ses;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  303  	struct cifs_tcon *tcon;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  304  	struct cached_fids *cfids;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  305  	struct cached_fid *cfid;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  306  	LIST_HEAD(entry);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  307  
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  308  	seq_puts(m, "# Version:1\n");
d492a4e7d4d64fc fs/smb/client/cifs_debug.c Arnd Bergmann  2026-04-23  309  #ifdef CONFIG_CIFS_DEBUG2
17d912d54f23058 fs/smb/client/cifs_debug.c Enzo Matsumiya 2026-04-22  310  	seq_puts(m, "# Write 0 to this file to drop all cached directory entries\n");
17d912d54f23058 fs/smb/client/cifs_debug.c Enzo Matsumiya 2026-04-22  311  #endif /* CONFIG_CIFS_DEBUG */
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  312  	seq_puts(m, "# Format:\n");
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  313  	seq_puts(m, "# <tree id> <sess id> <persistent fid> <lease-key> <path>\n");
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  314  
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  315  	spin_lock(&cifs_tcp_ses_lock);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  316  	list_for_each(stmp, &cifs_tcp_ses_list) {
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  317  		server = list_entry(stmp, struct TCP_Server_Info,
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  318  				    tcp_ses_list);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  319  		list_for_each(tmp, &server->smb_ses_list) {
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  320  			ses = list_entry(tmp, struct cifs_ses, smb_ses_list);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  321  			list_for_each(tmp1, &ses->tcon_list) {
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  322  				tcon = list_entry(tmp1, struct cifs_tcon, tcon_list);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  323  				cfids = tcon->cfids;
6976c7a69dafbb3 fs/smb/client/cifs_debug.c Wang Zhaolong  2025-08-29  324  				if (!cfids)
6976c7a69dafbb3 fs/smb/client/cifs_debug.c Wang Zhaolong  2025-08-29  325  					continue;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  326  				spin_lock(&cfids->cfid_list_lock); /* check lock ordering */
63eb8bd6c81d84a fs/smb/client/cifs_debug.c Bharath SM     2025-09-29  327  				seq_printf(m, "Num entries: %d, cached_dirents: %lu entries, %llu bytes\n",
63eb8bd6c81d84a fs/smb/client/cifs_debug.c Bharath SM     2025-09-29  328  						cfids->num_entries,
63eb8bd6c81d84a fs/smb/client/cifs_debug.c Bharath SM     2025-09-29  329  						(unsigned long)atomic_long_read(&cfids->total_dirents_entries),
63eb8bd6c81d84a fs/smb/client/cifs_debug.c Bharath SM     2025-09-29  330  						(unsigned long long)atomic64_read(&cfids->total_dirents_bytes));
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  331  				list_for_each_entry(cfid, &cfids->entries, entry) {
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  332  					seq_printf(m, "0x%x 0x%llx 0x%llx ",
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  333  						tcon->tid,
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  334  						ses->Suid,
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  335  						cfid->fid.persistent_fid);
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  336  					if (cfid->has_lease)
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  337  						seq_printf(m, "%pUl ", cfid->fid.lease_key);
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  338  					else
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  339  						seq_puts(m, "- ");
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  340  					seq_printf(m, "%s", cfid->path);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  341  					if (cfid->file_all_info_is_valid)
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  342  						seq_printf(m, "\tvalid file info");
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  343  					if (cfid->dirents.is_valid)
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  344  						seq_printf(m, ", valid dirents");
63eb8bd6c81d84a fs/smb/client/cifs_debug.c Bharath SM     2025-09-29  345  					if (!list_empty(&cfid->dirents.entries))
63eb8bd6c81d84a fs/smb/client/cifs_debug.c Bharath SM     2025-09-29  346  						seq_printf(m, ", dirents: %lu entries, %lu bytes",
63eb8bd6c81d84a fs/smb/client/cifs_debug.c Bharath SM     2025-09-29  347  						cfid->dirents.entries_count, cfid->dirents.bytes_used);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  348  					seq_printf(m, "\n");
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  349  				}
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  350  				spin_unlock(&cfids->cfid_list_lock);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  351  			}
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  352  		}
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  353  	}
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  354  	spin_unlock(&cifs_tcp_ses_lock);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  355  	seq_putc(m, '\n');
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  356  	return 0;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  357  }
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  358  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2026-04-29 20:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23  6:50 [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops Arnd Bergmann
2026-04-23  9:01 ` Enzo Matsumiya
2026-04-29 20:37 ` kernel test robot [this message]
2026-04-29 23:06 ` kernel test robot
2026-04-30 12:11 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202604300441.heF8QVnl-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=bharathsm@microsoft.com \
    --cc=ematsumiya@suse.de \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=metze@samba.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pc@manguebit.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    --cc=sprasad@microsoft.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox