[PATCH] smb: client: hide unused cifs_debug_dirs_proc

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops
@ 2026-04-23  6:50 Arnd Bergmann
  2026-04-23  9:01 ` Enzo Matsumiya
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Arnd Bergmann @ 2026-04-23  6:50 UTC (permalink / raw)
  To: Steve French, Enzo Matsumiya
  Cc: Arnd Bergmann, Paulo Alcantara, Ronnie Sahlberg, Shyam Prasad N,
	Tom Talpey, Bharath SM, Stefan Metzmacher, Namjae Jeon,
	linux-cifs, samba-technical, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

When CONFIG_CIFS_DEBUG2 is disabled, the only reference to this
function is hidden, causing a harmless warning:

fs/smb/client/cifs_debug.c:395:30: error: 'cifs_debug_dirs_proc_ops' defined but not used [-Werror=unused-const-variable=]
  395 | static const struct proc_ops cifs_debug_dirs_proc_ops = {
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~

Make the #ifdef checks around them consistent by always using
the DEBUG2 variant.

Fixes: 63bff18d4aa0 ("smb: client: fix (remove) drop_dir_cache module parameter")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 fs/smb/client/cifs_debug.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/smb/client/cifs_debug.c b/fs/smb/client/cifs_debug.c
index f55e5cabdaee..9a2e796161d0 100644
--- a/fs/smb/client/cifs_debug.c
+++ b/fs/smb/client/cifs_debug.c
@@ -306,7 +306,7 @@ static int cifs_debug_dirs_proc_show(struct seq_file *m, void *v)
 	LIST_HEAD(entry);
 
 	seq_puts(m, "# Version:1\n");
-#ifdef CONFIG_CIFS_DEBUG
+#ifdef CONFIG_CIFS_DEBUG2
 	seq_puts(m, "# Write 0 to this file to drop all cached directory entries\n");
 #endif /* CONFIG_CIFS_DEBUG */
 	seq_puts(m, "# Format:\n");
@@ -356,7 +356,7 @@ static int cifs_debug_dirs_proc_show(struct seq_file *m, void *v)
 	return 0;
 }
 
-#ifdef CONFIG_CIFS_DEBUG
+#ifdef CONFIG_CIFS_DEBUG2
 static int cifs_debug_dirs_proc_open(struct inode *inode, struct file *file)
 {
 	return single_open(file, cifs_debug_dirs_proc_show, NULL);
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops
  2026-04-23  6:50 [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops Arnd Bergmann
@ 2026-04-23  9:01 ` Enzo Matsumiya
  2026-04-29 20:37 ` kernel test robot
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Enzo Matsumiya @ 2026-04-23  9:01 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Steve French, Arnd Bergmann, Paulo Alcantara, Ronnie Sahlberg,
	Shyam Prasad N, Tom Talpey, Bharath SM, Stefan Metzmacher,
	Namjae Jeon, linux-cifs, samba-technical, linux-kernel

On 04/23, Arnd Bergmann wrote:
>From: Arnd Bergmann <arnd@arndb.de>
>
>When CONFIG_CIFS_DEBUG2 is disabled, the only reference to this
>function is hidden, causing a harmless warning:
>
>fs/smb/client/cifs_debug.c:395:30: error: 'cifs_debug_dirs_proc_ops' defined but not used [-Werror=unused-const-variable=]
>  395 | static const struct proc_ops cifs_debug_dirs_proc_ops = {
>      |                              ^~~~~~~~~~~~~~~~~~~~~~~~
>
>Make the #ifdef checks around them consistent by always using
>the DEBUG2 variant.
>
>Fixes: 63bff18d4aa0 ("smb: client: fix (remove) drop_dir_cache module parameter")

Thanks for catching that.

I sent v2/v3 of that patch changing the dependency from
CONFIG_CIFS_DEBUG2 to CONFIG_CIFS_DEBUG, can you adjust to the
latter please?


Cheers,

>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>---
> fs/smb/client/cifs_debug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/fs/smb/client/cifs_debug.c b/fs/smb/client/cifs_debug.c
>index f55e5cabdaee..9a2e796161d0 100644
>--- a/fs/smb/client/cifs_debug.c
>+++ b/fs/smb/client/cifs_debug.c
>@@ -306,7 +306,7 @@ static int cifs_debug_dirs_proc_show(struct seq_file *m, void *v)
> 	LIST_HEAD(entry);
>
> 	seq_puts(m, "# Version:1\n");
>-#ifdef CONFIG_CIFS_DEBUG
>+#ifdef CONFIG_CIFS_DEBUG2
> 	seq_puts(m, "# Write 0 to this file to drop all cached directory entries\n");
> #endif /* CONFIG_CIFS_DEBUG */
> 	seq_puts(m, "# Format:\n");
>@@ -356,7 +356,7 @@ static int cifs_debug_dirs_proc_show(struct seq_file *m, void *v)
> 	return 0;
> }
>
>-#ifdef CONFIG_CIFS_DEBUG
>+#ifdef CONFIG_CIFS_DEBUG2
> static int cifs_debug_dirs_proc_open(struct inode *inode, struct file *file)
> {
> 	return single_open(file, cifs_debug_dirs_proc_show, NULL);
>-- 
>2.39.5
>
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops
  2026-04-23  6:50 [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops Arnd Bergmann
  2026-04-23  9:01 ` Enzo Matsumiya
@ 2026-04-29 20:37 ` kernel test robot
  2026-04-29 23:06 ` kernel test robot
  2026-04-30 12:11 ` kernel test robot
  3 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2026-04-29 20:37 UTC (permalink / raw)
  To: Arnd Bergmann, Steve French, Enzo Matsumiya
  Cc: oe-kbuild-all, Arnd Bergmann, Paulo Alcantara, Ronnie Sahlberg,
	Shyam Prasad N, Tom Talpey, Bharath SM, Stefan Metzmacher,
	Namjae Jeon, linux-cifs, samba-technical, linux-kernel

Hi Arnd,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20260424]
[also build test WARNING on linus/master v7.1-rc1]
[cannot apply to v7.0 v7.0-rc7 v7.0-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Arnd-Bergmann/smb-client-hide-unused-cifs_debug_dirs_proc_ops/20260426-163431
base:   next-20260424
patch link:    https://lore.kernel.org/r/20260423065042.1898971-1-arnd%40kernel.org
patch subject: [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops
config: microblaze-defconfig (https://download.01.org/0day-ci/archive/20260430/202604300441.heF8QVnl-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260430/202604300441.heF8QVnl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604300441.heF8QVnl-lkp@intel.com/

All warnings (new ones prefixed by >>):

   fs/smb/client/cifs_debug.c: In function 'cifs_proc_init':
   fs/smb/client/cifs_debug.c:937:55: error: 'cifs_debug_dirs_proc_ops' undeclared (first use in this function); did you mean 'cifs_debug_dirs_proc_show'?
     937 |         proc_create("open_dirs", 0600, proc_fs_cifs, &cifs_debug_dirs_proc_ops);
         |                                                       ^~~~~~~~~~~~~~~~~~~~~~~~
         |                                                       cifs_debug_dirs_proc_show
   fs/smb/client/cifs_debug.c:937:55: note: each undeclared identifier is reported only once for each function it appears in
   fs/smb/client/cifs_debug.c: At top level:
>> fs/smb/client/cifs_debug.c:298:12: warning: 'cifs_debug_dirs_proc_show' defined but not used [-Wunused-function]
     298 | static int cifs_debug_dirs_proc_show(struct seq_file *m, void *v)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +/cifs_debug_dirs_proc_show +298 fs/smb/client/cifs_debug.c

dfe33f9abc08997 fs/cifs/cifs_debug.c       Steve French   2018-10-30  297  
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28 @298  static int cifs_debug_dirs_proc_show(struct seq_file *m, void *v)
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  299  {
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  300  	struct list_head *stmp, *tmp, *tmp1;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  301  	struct TCP_Server_Info *server;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  302  	struct cifs_ses *ses;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  303  	struct cifs_tcon *tcon;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  304  	struct cached_fids *cfids;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  305  	struct cached_fid *cfid;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  306  	LIST_HEAD(entry);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  307  
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  308  	seq_puts(m, "# Version:1\n");
d492a4e7d4d64fc fs/smb/client/cifs_debug.c Arnd Bergmann  2026-04-23  309  #ifdef CONFIG_CIFS_DEBUG2
17d912d54f23058 fs/smb/client/cifs_debug.c Enzo Matsumiya 2026-04-22  310  	seq_puts(m, "# Write 0 to this file to drop all cached directory entries\n");
17d912d54f23058 fs/smb/client/cifs_debug.c Enzo Matsumiya 2026-04-22  311  #endif /* CONFIG_CIFS_DEBUG */
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  312  	seq_puts(m, "# Format:\n");
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  313  	seq_puts(m, "# <tree id> <sess id> <persistent fid> <lease-key> <path>\n");
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  314  
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  315  	spin_lock(&cifs_tcp_ses_lock);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  316  	list_for_each(stmp, &cifs_tcp_ses_list) {
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  317  		server = list_entry(stmp, struct TCP_Server_Info,
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  318  				    tcp_ses_list);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  319  		list_for_each(tmp, &server->smb_ses_list) {
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  320  			ses = list_entry(tmp, struct cifs_ses, smb_ses_list);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  321  			list_for_each(tmp1, &ses->tcon_list) {
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  322  				tcon = list_entry(tmp1, struct cifs_tcon, tcon_list);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  323  				cfids = tcon->cfids;
6976c7a69dafbb3 fs/smb/client/cifs_debug.c Wang Zhaolong  2025-08-29  324  				if (!cfids)
6976c7a69dafbb3 fs/smb/client/cifs_debug.c Wang Zhaolong  2025-08-29  325  					continue;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  326  				spin_lock(&cfids->cfid_list_lock); /* check lock ordering */
63eb8bd6c81d84a fs/smb/client/cifs_debug.c Bharath SM     2025-09-29  327  				seq_printf(m, "Num entries: %d, cached_dirents: %lu entries, %llu bytes\n",
63eb8bd6c81d84a fs/smb/client/cifs_debug.c Bharath SM     2025-09-29  328  						cfids->num_entries,
63eb8bd6c81d84a fs/smb/client/cifs_debug.c Bharath SM     2025-09-29  329  						(unsigned long)atomic_long_read(&cfids->total_dirents_entries),
63eb8bd6c81d84a fs/smb/client/cifs_debug.c Bharath SM     2025-09-29  330  						(unsigned long long)atomic64_read(&cfids->total_dirents_bytes));
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  331  				list_for_each_entry(cfid, &cfids->entries, entry) {
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  332  					seq_printf(m, "0x%x 0x%llx 0x%llx ",
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  333  						tcon->tid,
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  334  						ses->Suid,
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  335  						cfid->fid.persistent_fid);
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  336  					if (cfid->has_lease)
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  337  						seq_printf(m, "%pUl ", cfid->fid.lease_key);
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  338  					else
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  339  						seq_puts(m, "- ");
f78b83dce273ff2 fs/smb/client/cifs_debug.c Bharath SM     2025-10-30  340  					seq_printf(m, "%s", cfid->path);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  341  					if (cfid->file_all_info_is_valid)
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  342  						seq_printf(m, "\tvalid file info");
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  343  					if (cfid->dirents.is_valid)
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  344  						seq_printf(m, ", valid dirents");
63eb8bd6c81d84a fs/smb/client/cifs_debug.c Bharath SM     2025-09-29  345  					if (!list_empty(&cfid->dirents.entries))
63eb8bd6c81d84a fs/smb/client/cifs_debug.c Bharath SM     2025-09-29  346  						seq_printf(m, ", dirents: %lu entries, %lu bytes",
63eb8bd6c81d84a fs/smb/client/cifs_debug.c Bharath SM     2025-09-29  347  						cfid->dirents.entries_count, cfid->dirents.bytes_used);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  348  					seq_printf(m, "\n");
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  349  				}
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  350  				spin_unlock(&cfids->cfid_list_lock);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  351  			}
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  352  		}
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  353  	}
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  354  	spin_unlock(&cifs_tcp_ses_lock);
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  355  	seq_putc(m, '\n');
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  356  	return 0;
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  357  }
844e5c0eb1767d5 fs/smb/client/cifs_debug.c Steve French   2025-07-28  358  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops
  2026-04-23  6:50 [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops Arnd Bergmann
  2026-04-23  9:01 ` Enzo Matsumiya
  2026-04-29 20:37 ` kernel test robot
@ 2026-04-29 23:06 ` kernel test robot
  2026-04-30 12:11 ` kernel test robot
  3 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2026-04-29 23:06 UTC (permalink / raw)
  To: Arnd Bergmann, Steve French, Enzo Matsumiya
  Cc: oe-kbuild-all, Arnd Bergmann, Paulo Alcantara, Ronnie Sahlberg,
	Shyam Prasad N, Tom Talpey, Bharath SM, Stefan Metzmacher,
	Namjae Jeon, linux-cifs, samba-technical, linux-kernel

Hi Arnd,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20260424]
[also build test ERROR on linus/master v7.1-rc1]
[cannot apply to v7.0 v7.0-rc7 v7.0-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Arnd-Bergmann/smb-client-hide-unused-cifs_debug_dirs_proc_ops/20260426-163431
base:   next-20260424
patch link:    https://lore.kernel.org/r/20260423065042.1898971-1-arnd%40kernel.org
patch subject: [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops
config: microblaze-defconfig (https://download.01.org/0day-ci/archive/20260430/202604300622.95X1Ab1U-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260430/202604300622.95X1Ab1U-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604300622.95X1Ab1U-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/smb/client/cifs_debug.c: In function 'cifs_proc_init':
>> fs/smb/client/cifs_debug.c:937:55: error: 'cifs_debug_dirs_proc_ops' undeclared (first use in this function); did you mean 'cifs_debug_dirs_proc_show'?
     937 |         proc_create("open_dirs", 0600, proc_fs_cifs, &cifs_debug_dirs_proc_ops);
         |                                                       ^~~~~~~~~~~~~~~~~~~~~~~~
         |                                                       cifs_debug_dirs_proc_show
   fs/smb/client/cifs_debug.c:937:55: note: each undeclared identifier is reported only once for each function it appears in
   fs/smb/client/cifs_debug.c: At top level:
   fs/smb/client/cifs_debug.c:298:12: warning: 'cifs_debug_dirs_proc_show' defined but not used [-Wunused-function]
     298 | static int cifs_debug_dirs_proc_show(struct seq_file *m, void *v)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +937 fs/smb/client/cifs_debug.c

^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  922  
^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  923  void
^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  924  cifs_proc_init(void)
^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  925  {
36a5aeb8787fbf fs/cifs/cifs_debug.c       Alexey Dobriyan   2008-04-29  926  	proc_fs_cifs = proc_mkdir("fs/cifs", NULL);
^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  927  	if (proc_fs_cifs == NULL)
^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  928  		return;
^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  929  
3f3942aca6da35 fs/cifs/cifs_debug.c       Christoph Hellwig 2018-05-15  930  	proc_create_single("DebugData", 0, proc_fs_cifs,
3f3942aca6da35 fs/cifs/cifs_debug.c       Christoph Hellwig 2018-05-15  931  			cifs_debug_data_proc_show);
^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  932  
dfe33f9abc0899 fs/cifs/cifs_debug.c       Steve French      2018-10-30  933  	proc_create_single("open_files", 0400, proc_fs_cifs,
dfe33f9abc0899 fs/cifs/cifs_debug.c       Steve French      2018-10-30  934  			cifs_debug_files_proc_show);
dfe33f9abc0899 fs/cifs/cifs_debug.c       Steve French      2018-10-30  935  
17d912d54f2305 fs/smb/client/cifs_debug.c Enzo Matsumiya    2026-04-22  936  #ifdef CONFIG_CIFS_DEBUG
17d912d54f2305 fs/smb/client/cifs_debug.c Enzo Matsumiya    2026-04-22 @937  	proc_create("open_dirs", 0600, proc_fs_cifs, &cifs_debug_dirs_proc_ops);
17d912d54f2305 fs/smb/client/cifs_debug.c Enzo Matsumiya    2026-04-22  938  #else /* CONFIG_CIFS_DEBUG */
17d912d54f2305 fs/smb/client/cifs_debug.c Enzo Matsumiya    2026-04-22  939  	proc_create_single("open_dirs", 0400, proc_fs_cifs, cifs_debug_dirs_proc_show);
17d912d54f2305 fs/smb/client/cifs_debug.c Enzo Matsumiya    2026-04-22  940  #endif /* !CONFIG_CIFS_DEBUG */
97a32539b9568b fs/cifs/cifs_debug.c       Alexey Dobriyan   2020-02-03  941  	proc_create("Stats", 0644, proc_fs_cifs, &cifs_stats_proc_ops);
97a32539b9568b fs/cifs/cifs_debug.c       Alexey Dobriyan   2020-02-03  942  	proc_create("cifsFYI", 0644, proc_fs_cifs, &cifsFYI_proc_ops);
97a32539b9568b fs/cifs/cifs_debug.c       Alexey Dobriyan   2020-02-03  943  	proc_create("traceSMB", 0644, proc_fs_cifs, &traceSMB_proc_ops);
6539e7f3727ab9 fs/cifs/cifs_debug.c       Ronnie Sahlberg   2018-05-24  944  	proc_create("LinuxExtensionsEnabled", 0644, proc_fs_cifs,
97a32539b9568b fs/cifs/cifs_debug.c       Alexey Dobriyan   2020-02-03  945  		    &cifs_linux_ext_proc_ops);
6539e7f3727ab9 fs/cifs/cifs_debug.c       Ronnie Sahlberg   2018-05-24  946  	proc_create("SecurityFlags", 0644, proc_fs_cifs,
97a32539b9568b fs/cifs/cifs_debug.c       Alexey Dobriyan   2020-02-03  947  		    &cifs_security_flags_proc_ops);
6539e7f3727ab9 fs/cifs/cifs_debug.c       Ronnie Sahlberg   2018-05-24  948  	proc_create("LookupCacheEnabled", 0644, proc_fs_cifs,
97a32539b9568b fs/cifs/cifs_debug.c       Alexey Dobriyan   2020-02-03  949  		    &cifs_lookup_cache_proc_ops);
54be1f6c1c3749 fs/cifs/cifs_debug.c       Paulo Alcantara   2018-11-14  950  
94b0595a8e018c fs/cifs/cifs_debug.c       Aurelien Aptel    2021-03-18  951  	proc_create("mount_params", 0444, proc_fs_cifs, &cifs_mount_params_proc_ops);
94b0595a8e018c fs/cifs/cifs_debug.c       Aurelien Aptel    2021-03-18  952  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops
  2026-04-23  6:50 [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops Arnd Bergmann
                   ` (2 preceding siblings ...)
  2026-04-29 23:06 ` kernel test robot
@ 2026-04-30 12:11 ` kernel test robot
  3 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2026-04-30 12:11 UTC (permalink / raw)
  To: Arnd Bergmann, Steve French, Enzo Matsumiya
  Cc: llvm, oe-kbuild-all, Arnd Bergmann, Paulo Alcantara,
	Ronnie Sahlberg, Shyam Prasad N, Tom Talpey, Bharath SM,
	Stefan Metzmacher, Namjae Jeon, linux-cifs, samba-technical,
	linux-kernel

Hi Arnd,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20260424]
[also build test ERROR on linus/master v7.1-rc1]
[cannot apply to v7.0 v7.0-rc7 v7.0-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Arnd-Bergmann/smb-client-hide-unused-cifs_debug_dirs_proc_ops/20260426-163431
base:   next-20260424
patch link:    https://lore.kernel.org/r/20260423065042.1898971-1-arnd%40kernel.org
patch subject: [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops
config: i386-randconfig-017-20260430 (https://download.01.org/0day-ci/archive/20260430/202604302014.zKNhMog5-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260430/202604302014.zKNhMog5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604302014.zKNhMog5-lkp@intel.com/

All errors (new ones prefixed by >>):

>> fs/smb/client/cifs_debug.c:937:48: error: use of undeclared identifier 'cifs_debug_dirs_proc_ops'; did you mean 'cifs_debug_dirs_proc_show'?
     937 |         proc_create("open_dirs", 0600, proc_fs_cifs, &cifs_debug_dirs_proc_ops);
         |                                                       ^~~~~~~~~~~~~~~~~~~~~~~~
         |                                                       cifs_debug_dirs_proc_show
   fs/smb/client/cifs_debug.c:298:12: note: 'cifs_debug_dirs_proc_show' declared here
     298 | static int cifs_debug_dirs_proc_show(struct seq_file *m, void *v)
         |            ^
   1 error generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for MFD_STMFX
   Depends on [n]: HAS_IOMEM [=y] && I2C [=y] && OF [=n]
   Selected by [y]:
   - PINCTRL_STMFX [=y] && PINCTRL [=y] && I2C [=y] && HAS_IOMEM [=y]


vim +937 fs/smb/client/cifs_debug.c

^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  922  
^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  923  void
^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  924  cifs_proc_init(void)
^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  925  {
36a5aeb8787fbf fs/cifs/cifs_debug.c       Alexey Dobriyan   2008-04-29  926  	proc_fs_cifs = proc_mkdir("fs/cifs", NULL);
^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  927  	if (proc_fs_cifs == NULL)
^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  928  		return;
^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  929  
3f3942aca6da35 fs/cifs/cifs_debug.c       Christoph Hellwig 2018-05-15  930  	proc_create_single("DebugData", 0, proc_fs_cifs,
3f3942aca6da35 fs/cifs/cifs_debug.c       Christoph Hellwig 2018-05-15  931  			cifs_debug_data_proc_show);
^1da177e4c3f41 fs/cifs/cifs_debug.c       Linus Torvalds    2005-04-16  932  
dfe33f9abc0899 fs/cifs/cifs_debug.c       Steve French      2018-10-30  933  	proc_create_single("open_files", 0400, proc_fs_cifs,
dfe33f9abc0899 fs/cifs/cifs_debug.c       Steve French      2018-10-30  934  			cifs_debug_files_proc_show);
dfe33f9abc0899 fs/cifs/cifs_debug.c       Steve French      2018-10-30  935  
17d912d54f2305 fs/smb/client/cifs_debug.c Enzo Matsumiya    2026-04-22  936  #ifdef CONFIG_CIFS_DEBUG
17d912d54f2305 fs/smb/client/cifs_debug.c Enzo Matsumiya    2026-04-22 @937  	proc_create("open_dirs", 0600, proc_fs_cifs, &cifs_debug_dirs_proc_ops);
17d912d54f2305 fs/smb/client/cifs_debug.c Enzo Matsumiya    2026-04-22  938  #else /* CONFIG_CIFS_DEBUG */
17d912d54f2305 fs/smb/client/cifs_debug.c Enzo Matsumiya    2026-04-22  939  	proc_create_single("open_dirs", 0400, proc_fs_cifs, cifs_debug_dirs_proc_show);
17d912d54f2305 fs/smb/client/cifs_debug.c Enzo Matsumiya    2026-04-22  940  #endif /* !CONFIG_CIFS_DEBUG */
97a32539b9568b fs/cifs/cifs_debug.c       Alexey Dobriyan   2020-02-03  941  	proc_create("Stats", 0644, proc_fs_cifs, &cifs_stats_proc_ops);
97a32539b9568b fs/cifs/cifs_debug.c       Alexey Dobriyan   2020-02-03  942  	proc_create("cifsFYI", 0644, proc_fs_cifs, &cifsFYI_proc_ops);
97a32539b9568b fs/cifs/cifs_debug.c       Alexey Dobriyan   2020-02-03  943  	proc_create("traceSMB", 0644, proc_fs_cifs, &traceSMB_proc_ops);
6539e7f3727ab9 fs/cifs/cifs_debug.c       Ronnie Sahlberg   2018-05-24  944  	proc_create("LinuxExtensionsEnabled", 0644, proc_fs_cifs,
97a32539b9568b fs/cifs/cifs_debug.c       Alexey Dobriyan   2020-02-03  945  		    &cifs_linux_ext_proc_ops);
6539e7f3727ab9 fs/cifs/cifs_debug.c       Ronnie Sahlberg   2018-05-24  946  	proc_create("SecurityFlags", 0644, proc_fs_cifs,
97a32539b9568b fs/cifs/cifs_debug.c       Alexey Dobriyan   2020-02-03  947  		    &cifs_security_flags_proc_ops);
6539e7f3727ab9 fs/cifs/cifs_debug.c       Ronnie Sahlberg   2018-05-24  948  	proc_create("LookupCacheEnabled", 0644, proc_fs_cifs,
97a32539b9568b fs/cifs/cifs_debug.c       Alexey Dobriyan   2020-02-03  949  		    &cifs_lookup_cache_proc_ops);
54be1f6c1c3749 fs/cifs/cifs_debug.c       Paulo Alcantara   2018-11-14  950  
94b0595a8e018c fs/cifs/cifs_debug.c       Aurelien Aptel    2021-03-18  951  	proc_create("mount_params", 0444, proc_fs_cifs, &cifs_mount_params_proc_ops);
94b0595a8e018c fs/cifs/cifs_debug.c       Aurelien Aptel    2021-03-18  952  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-04-30 12:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-23  6:50 [PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops Arnd Bergmann
2026-04-23  9:01 ` Enzo Matsumiya
2026-04-29 20:37 ` kernel test robot
2026-04-29 23:06 ` kernel test robot
2026-04-30 12:11 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox