[PATCH v2] arm64: dts: qcom: slim7x: Add Embedded Controller node

[PATCH v2] arm64: dts: qcom: slim7x: Add Embedded Controller node

[Daniel J Blueman]

The Lenovo Slim7x uses the same Embedded Controller as the Qualcomm
Hamoa Customer Reference Device (X1). Wire it up for fan control,
thermal sensor and suspend behaviour.

Signed-off-by: Daniel J Blueman <daniel@quora.org>
---
Changes in v2:
- corrected DT compatible node
- v1 link: https://lore.kernel.org/all/20260429103301.17449-1-daniel@quora.org/

Dependencies:
https://lore.kernel.org/all/20260427-add-driver-for-ec-v8-0-702f74e495f7@oss.qualcomm.com/

 .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts  | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
index beb1475d7fa0..1ee2a2296129 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
@@ -951,6 +951,22 @@ retimer_ss0_con_sbu_out: endpoint {
 	};
 };
 
+&i2c5 {
+	clock-frequency = <400000>;
+
+	status = "okay";
+
+	embedded-controller@76 {
+		compatible = "qcom,hamoa-crd-ec";
+		reg = <0x76>;
+
+		interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>;
+
+		pinctrl-0 = <&ec_int_n_default>;
+		pinctrl-names = "default";
+	};
+};
+
 &i2c7 {
 	clock-frequency = <400000>;
 
@@ -1352,6 +1368,12 @@ &tlmm {
 			       <44 4>, /* SPI (TPM) */
 			       <238 1>; /* UFS Reset */
 
+	ec_int_n_default: ec-int-n-state {
+		pins = "gpio66";
+		function = "gpio";
+		bias-disable;
+	};
+
 	edp_reg_en: edp-reg-en-state {
 		pins = "gpio70";
 		function = "gpio";
-- 
2.53.0

Re: [PATCH v2] arm64: dts: qcom: slim7x: Add Embedded Controller node

[Konrad Dybcio]

On 5/2/26 8:35 AM, Daniel J Blueman wrote:
> The Lenovo Slim7x uses the same Embedded Controller as the Qualcomm
> Hamoa Customer Reference Device (X1). Wire it up for fan control,
> thermal sensor and suspend behaviour.
> 
> Signed-off-by: Daniel J Blueman <daniel@quora.org>
> ---
> Changes in v2:
> - corrected DT compatible node

You still need to introduce one specific to your actual hardware,
even if the driver receives no changes at the moment.

This is a measure to enable retroactively enabling quirks for users
that update their kernel but not their DTB, so that if a year from
now it turns out that the yoga EC requires some special handling (but
other users of qcom,hamoa-crd-ec don't), we can easily quirk it out

i.e., the desired outcome here is something like:

compatible = "lenovo,yoga-slim7x-ec",
	     "qcom,hamoa-crd-ec";

(the first compatible is ignored by the driver matching code today,
the other ("fallback") one is matched on)

This will need an accompanying change, adding the new Lenovo
compatible to the dt-bindings file

Konrad