From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 07/17] iio: magnetometer: ak8975: pass conversion timeouts as arguments
Date: Mon, 4 May 2026 16:07:53 +0100 [thread overview]
Message-ID: <20260504160753.42a4c2d7@jic23-huawei> (raw)
In-Reply-To: <CALoEA-yeMbbbS+h2YmJ7sr8CXMkQpDKT2=s0pU7+oh=yt045Cg@mail.gmail.com>
On Mon, 4 May 2026 16:11:47 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> On Mon, 4 May 2026 at 16:06, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > > Okay, this was suggested by Jonathan on your v0 version, but I guess there
> > > is no need now that there are poll and timeout parameters added in the function
> > > (or maybe the suggestions were for the parameters only and I
> > > misinterpreted them).
> >
> > The idea is to see them on an average one page in the text editor, all of them
> > at once. As long as they are quite close to each other, the temporary variables
> > are not needed. Moreover, I found them a nit harmful in terms of readability as
> > one will need to jump over the code to see the values, while with explicit
> > numbers it's all being concentrated in a small code stanza.
>
> You've convinced me :)
>
Also agree given they are so close together and we have that different
timeout nearby.
J
next prev parent reply other threads:[~2026-05-04 15:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 9:48 [PATCH v4 00/17] iio: magnetometer: ak8975: modernize and cleanup driver Joshua Crofts via B4 Relay
2026-05-04 9:48 ` [PATCH v4 01/17] iio: magnetometer: ak8975: sort headers alphabetically Joshua Crofts via B4 Relay
2026-05-04 9:48 ` [PATCH v4 02/17] iio: magnetometer: ak8975: update headers per IWYU principle Joshua Crofts via B4 Relay
2026-05-04 9:48 ` [PATCH v4 03/17] iio: magnetometer: ak8975: replace usleep_range() with fsleep() Joshua Crofts via B4 Relay
2026-05-04 9:48 ` [PATCH v4 04/17] iio: magnetometer: ak8975: change 'u8*' to 'u8 *' in cast Joshua Crofts via B4 Relay
2026-05-04 9:48 ` [PATCH v4 05/17] iio: magnetometer: ak8975: fix wrong errno on return Joshua Crofts via B4 Relay
2026-05-04 9:48 ` [PATCH v4 06/17] iio: magnetometer: ak8975: modernize polling loops with iopoll() macros Joshua Crofts via B4 Relay
2026-05-04 11:18 ` Andy Shevchenko
2026-05-04 15:06 ` Jonathan Cameron
2026-05-05 4:57 ` Andy Shevchenko
2026-05-05 7:07 ` Joshua Crofts
2026-05-05 7:21 ` Andy Shevchenko
2026-05-05 7:26 ` Joshua Crofts
2026-05-05 8:07 ` Joshua Crofts
2026-05-05 8:17 ` Andy Shevchenko
2026-05-04 9:48 ` [PATCH v4 07/17] iio: magnetometer: ak8975: pass conversion timeouts as arguments Joshua Crofts via B4 Relay
2026-05-04 11:10 ` Andy Shevchenko
2026-05-04 11:25 ` Joshua Crofts
2026-05-04 14:06 ` Andy Shevchenko
2026-05-04 14:11 ` Joshua Crofts
2026-05-04 15:07 ` Jonathan Cameron [this message]
2026-05-04 11:33 ` Joshua Crofts
2026-05-04 15:09 ` Jonathan Cameron
2026-05-04 9:48 ` [PATCH v4 08/17] iio: magnetometer: ak8975: avoid using temporary variable Joshua Crofts via B4 Relay
2026-05-04 9:48 ` [PATCH v4 09/17] iio: magnetometer: ak8975: drop duplicate NULL check Joshua Crofts via B4 Relay
2026-05-04 9:48 ` [PATCH v4 10/17] iio: magnetometer: ak8975: remove duplicate error message Joshua Crofts via B4 Relay
2026-05-04 9:48 ` [PATCH v4 11/17] iio: magnetometer: ak8975: reduce usage of magic lengths of the buffer Joshua Crofts via B4 Relay
2026-05-04 9:48 ` [PATCH v4 12/17] iio: magnetometer: ak8975: unify return code variable name Joshua Crofts via B4 Relay
2026-05-04 9:48 ` [PATCH v4 13/17] iio: magnetometer: ak8975: switch to using managed resources Joshua Crofts via B4 Relay
2026-05-04 11:13 ` Andy Shevchenko
2026-05-04 11:28 ` Joshua Crofts
2026-05-04 9:48 ` [PATCH v4 14/17] iio: magnetometer: ak8975: consistently use 'data' parameter Joshua Crofts via B4 Relay
2026-05-04 9:48 ` [PATCH v4 15/17] iio: magnetometer: ak8975: unify messages with help of dev_err_probe() Joshua Crofts via B4 Relay
2026-05-04 9:48 ` [PATCH v4 16/17] iio: magnetometer: ak8975: use temporary variable for struct device Joshua Crofts via B4 Relay
2026-05-04 9:48 ` [PATCH v4 17/17] iio: magnetometer: ak8975: make use of the macros from bits.h Joshua Crofts via B4 Relay
2026-05-04 11:01 ` [PATCH v4 00/17] iio: magnetometer: ak8975: modernize and cleanup driver Andy Shevchenko
2026-05-04 11:13 ` Joshua Crofts
2026-05-04 15:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504160753.42a4c2d7@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox