public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: joshua.crofts1@gmail.com
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 00/17] iio: magnetometer: ak8975: modernize and cleanup driver
Date: Mon, 4 May 2026 14:01:49 +0300	[thread overview]
Message-ID: <afh8nZ8fsyeXYbtz@ashevche-desk.local> (raw)
In-Reply-To: <20260504-magnetometer-fixes-v4-0-a291c2a7c71a@gmail.com>

On Mon, May 04, 2026 at 11:48:12AM +0200, Joshua Crofts via B4 Relay wrote:
> This series modernizes and cleans up the ak8975 driver, migrating to
> more modern kernel APIs and cleaning up legacy code. Patches 7 through
> 17 were provided by Andy Shevchenko.
> 
> The series was compile-tested and ran in QEMU with i2c-stub and
> no issues were found.
> 
> The patch regarding switching to devm_* functions might have to
> go through an additional revision, otherwise everything else seems
> good to go.
> 
> Changes include:
>  - replacing usleep_range() with fsleep() for optimization
>  - migrating to iopoll macros for better device polling
>  - removing unused headers and adding new ones
>  - checkpatch.pl fixes
>  - switching driver to use devm_* functions
> 
> v2:
>  - PATCH 1: reverted alphabetical header ordering per logical change
>    separation
>  - PATCH 2: added newline between fsleep() and return
>  - PATCH 3: fixed open parenthesis formatting
>  - PATCH 4: fixed whitespace issues, added <linux/time.h> for
>    USEC_PER_MSEC macro
> v3:
>  - PATCH 1 & 2: split alphabetical ordering and header removal into two
>    separate patches
>  - PATCH 4: commit message fix
>  - PATCH 5 & 6: split error handling and polling loop replacement into
>    two separate patches
> v4:
>  - PATCH 7-17: am Andy's changes into this series
>  - PATCH 2, 5, 6: fixup Andy's changes to existing patches

Co-developed for those is too strong. Just use your SoB only.
You may use my Reviewed-by though.

Taking this into account, you can wait a day and send a new version with that
and --base fixed. Also it gives me and others a chance to briefly look into
the contents and see if everything looks okay.

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2026-05-04 11:01 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04  9:48 [PATCH v4 00/17] iio: magnetometer: ak8975: modernize and cleanup driver Joshua Crofts via B4 Relay
2026-05-04  9:48 ` [PATCH v4 01/17] iio: magnetometer: ak8975: sort headers alphabetically Joshua Crofts via B4 Relay
2026-05-04  9:48 ` [PATCH v4 02/17] iio: magnetometer: ak8975: update headers per IWYU principle Joshua Crofts via B4 Relay
2026-05-04  9:48 ` [PATCH v4 03/17] iio: magnetometer: ak8975: replace usleep_range() with fsleep() Joshua Crofts via B4 Relay
2026-05-04  9:48 ` [PATCH v4 04/17] iio: magnetometer: ak8975: change 'u8*' to 'u8 *' in cast Joshua Crofts via B4 Relay
2026-05-04  9:48 ` [PATCH v4 05/17] iio: magnetometer: ak8975: fix wrong errno on return Joshua Crofts via B4 Relay
2026-05-04  9:48 ` [PATCH v4 06/17] iio: magnetometer: ak8975: modernize polling loops with iopoll() macros Joshua Crofts via B4 Relay
2026-05-04 11:18   ` Andy Shevchenko
2026-05-04 15:06   ` Jonathan Cameron
2026-05-05  4:57     ` Andy Shevchenko
2026-05-05  7:07       ` Joshua Crofts
2026-05-05  7:21         ` Andy Shevchenko
2026-05-05  7:26           ` Joshua Crofts
2026-05-05  8:07             ` Joshua Crofts
2026-05-05  8:17               ` Andy Shevchenko
2026-05-04  9:48 ` [PATCH v4 07/17] iio: magnetometer: ak8975: pass conversion timeouts as arguments Joshua Crofts via B4 Relay
2026-05-04 11:10   ` Andy Shevchenko
2026-05-04 11:25     ` Joshua Crofts
2026-05-04 14:06       ` Andy Shevchenko
2026-05-04 14:11         ` Joshua Crofts
2026-05-04 15:07           ` Jonathan Cameron
2026-05-04 11:33   ` Joshua Crofts
2026-05-04 15:09     ` Jonathan Cameron
2026-05-04  9:48 ` [PATCH v4 08/17] iio: magnetometer: ak8975: avoid using temporary variable Joshua Crofts via B4 Relay
2026-05-04  9:48 ` [PATCH v4 09/17] iio: magnetometer: ak8975: drop duplicate NULL check Joshua Crofts via B4 Relay
2026-05-04  9:48 ` [PATCH v4 10/17] iio: magnetometer: ak8975: remove duplicate error message Joshua Crofts via B4 Relay
2026-05-04  9:48 ` [PATCH v4 11/17] iio: magnetometer: ak8975: reduce usage of magic lengths of the buffer Joshua Crofts via B4 Relay
2026-05-04  9:48 ` [PATCH v4 12/17] iio: magnetometer: ak8975: unify return code variable name Joshua Crofts via B4 Relay
2026-05-04  9:48 ` [PATCH v4 13/17] iio: magnetometer: ak8975: switch to using managed resources Joshua Crofts via B4 Relay
2026-05-04 11:13   ` Andy Shevchenko
2026-05-04 11:28     ` Joshua Crofts
2026-05-04  9:48 ` [PATCH v4 14/17] iio: magnetometer: ak8975: consistently use 'data' parameter Joshua Crofts via B4 Relay
2026-05-04  9:48 ` [PATCH v4 15/17] iio: magnetometer: ak8975: unify messages with help of dev_err_probe() Joshua Crofts via B4 Relay
2026-05-04  9:48 ` [PATCH v4 16/17] iio: magnetometer: ak8975: use temporary variable for struct device Joshua Crofts via B4 Relay
2026-05-04  9:48 ` [PATCH v4 17/17] iio: magnetometer: ak8975: make use of the macros from bits.h Joshua Crofts via B4 Relay
2026-05-04 11:01 ` Andy Shevchenko [this message]
2026-05-04 11:13   ` [PATCH v4 00/17] iio: magnetometer: ak8975: modernize and cleanup driver Joshua Crofts
2026-05-04 15:15     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afh8nZ8fsyeXYbtz@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox