From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
To: jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com,
christoph.muellner@theobroma-systems.com, martink@posteo.de,
mfuzzey@parkeon.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 03/10] iio: accel: mma8452: cleanup codestyle warning
Date: Tue, 5 May 2026 23:16:33 +0530 [thread overview]
Message-ID: <20260505174640.3998281-4-sanjayembedded@gmail.com> (raw)
In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com>
From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Reported by checkpatch:
FILE: drivers/iio/accel/mma8452.c
CHECK: Alignment should match open parenthesis
Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
---
drivers/iio/accel/mma8452.c | 47 +++++++++++++++++++------------------
1 file changed, 24 insertions(+), 23 deletions(-)
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index 279a9b364886..916631519d3f 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel/mma8452.c
@@ -706,8 +706,8 @@ static int mma8452_set_hp_filter_frequency(struct mma8452_data *data,
}
static int __mma8452_write_raw(struct iio_dev *indio_dev,
- struct iio_chan_spec const *chan,
- int val, int val2, long mask)
+ struct iio_chan_spec const *chan,
+ int val, int val2, long mask)
{
struct mma8452_data *data = iio_priv(indio_dev);
int i, j, ret;
@@ -788,8 +788,9 @@ static int mma8452_write_raw(struct iio_dev *indio_dev,
}
static int mma8452_get_event_regs(struct mma8452_data *data,
- const struct iio_chan_spec *chan, enum iio_event_direction dir,
- const struct mma8452_event_regs **ev_reg)
+ const struct iio_chan_spec *chan,
+ enum iio_event_direction dir,
+ const struct mma8452_event_regs **ev_reg)
{
if (!chan)
return -EINVAL;
@@ -818,11 +819,11 @@ static int mma8452_get_event_regs(struct mma8452_data *data,
}
static int mma8452_read_event_value(struct iio_dev *indio_dev,
- const struct iio_chan_spec *chan,
- enum iio_event_type type,
- enum iio_event_direction dir,
- enum iio_event_info info,
- int *val, int *val2)
+ const struct iio_chan_spec *chan,
+ enum iio_event_type type,
+ enum iio_event_direction dir,
+ enum iio_event_info info,
+ int *val, int *val2)
{
struct mma8452_data *data = iio_priv(indio_dev);
int ret, us, power_mode;
@@ -881,11 +882,11 @@ static int mma8452_read_event_value(struct iio_dev *indio_dev,
}
static int mma8452_write_event_value(struct iio_dev *indio_dev,
- const struct iio_chan_spec *chan,
- enum iio_event_type type,
- enum iio_event_direction dir,
- enum iio_event_info info,
- int val, int val2)
+ const struct iio_chan_spec *chan,
+ enum iio_event_type type,
+ enum iio_event_direction dir,
+ enum iio_event_info info,
+ int val, int val2)
{
struct mma8452_data *data = iio_priv(indio_dev);
int ret, reg, steps;
@@ -955,8 +956,7 @@ static int mma8452_read_event_config(struct iio_dev *indio_dev,
case IIO_EV_DIR_FALLING:
return mma8452_freefall_mode_enabled(data);
case IIO_EV_DIR_RISING:
- ret = i2c_smbus_read_byte_data(data->client,
- ev_regs->ev_cfg);
+ ret = i2c_smbus_read_byte_data(data->client, ev_regs->ev_cfg);
if (ret < 0)
return ret;
@@ -1193,7 +1193,7 @@ static const struct attribute_group mma8452_event_attribute_group = {
static const struct iio_mount_matrix *
mma8452_get_mount_matrix(const struct iio_dev *indio_dev,
- const struct iio_chan_spec *chan)
+ const struct iio_chan_spec *chan)
{
struct mma8452_data *data = iio_priv(indio_dev);
@@ -1516,8 +1516,9 @@ static int mma8452_reset(struct i2c_client *client)
* The following code will read the reset register, and check whether
* this reset works.
*/
- i2c_smbus_write_byte_data(client, MMA8452_CTRL_REG2,
- MMA8452_CTRL_REG2_RST);
+ i2c_smbus_write_byte_data(client,
+ MMA8452_CTRL_REG2,
+ MMA8452_CTRL_REG2_RST);
for (i = 0; i < 10; i++) {
usleep_range(100, 200);
@@ -1647,8 +1648,8 @@ static int mma8452_probe(struct i2c_client *client)
dev_dbg(&client->dev, "using interrupt line INT2\n");
} else {
ret = i2c_smbus_write_byte_data(client,
- MMA8452_CTRL_REG5,
- data->chip_info->all_events);
+ MMA8452_CTRL_REG5,
+ data->chip_info->all_events);
if (ret < 0)
goto disable_regulators;
@@ -1656,8 +1657,8 @@ static int mma8452_probe(struct i2c_client *client)
}
ret = i2c_smbus_write_byte_data(client,
- MMA8452_CTRL_REG4,
- data->chip_info->enabled_events);
+ MMA8452_CTRL_REG4,
+ data->chip_info->enabled_events);
if (ret < 0)
goto disable_regulators;
--
2.34.1
next prev parent reply other threads:[~2026-05-05 17:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 17:46 [PATCH v3 00/10] iio: accel: mma8452: improve coding style, pm and resource cleanup Sanjay Chitroda
2026-05-05 17:46 ` [PATCH v3 01/10] iio: accel: mma8452: handle I2C read error(s) in mma8452_read() Sanjay Chitroda
2026-05-05 17:46 ` [PATCH v3 02/10] iio: accel: mma8452: switch to non-devm request_threaded_irq() Sanjay Chitroda
2026-05-06 17:47 ` Jonathan Cameron
2026-05-05 17:46 ` Sanjay Chitroda [this message]
2026-05-06 9:24 ` [PATCH v3 03/10] iio: accel: mma8452: cleanup codestyle warning Joshua Crofts
2026-05-06 17:53 ` Jonathan Cameron
2026-05-05 17:46 ` [PATCH v3 04/10] iio: accel: mma8452: sort headers alphabetically Sanjay Chitroda
2026-05-06 9:29 ` Joshua Crofts
2026-05-05 17:46 ` [PATCH v3 05/10] iio: accel: mma8452: Use dev_err_probe() Sanjay Chitroda
2026-05-05 18:45 ` Joshua Crofts
2026-05-06 9:22 ` Andy Shevchenko
2026-05-06 9:27 ` Joshua Crofts
2026-05-06 9:37 ` Andy Shevchenko
2026-05-05 17:46 ` [PATCH v3 06/10] iio: accel: mma8452: convert to bulk regulator usage Sanjay Chitroda
2026-05-05 22:34 ` Joshua Crofts
2026-05-06 9:31 ` Andy Shevchenko
2026-05-05 17:46 ` [PATCH v3 07/10] iio: accel: mma8452: use local struct device Sanjay Chitroda
2026-05-06 9:19 ` Joshua Crofts
2026-05-06 9:34 ` Andy Shevchenko
2026-05-05 17:46 ` [PATCH v3 08/10] iio: accel: mma8452: use pm_ptr() and direct runtime PM calls Sanjay Chitroda
2026-05-06 9:42 ` Andy Shevchenko
2026-05-06 18:06 ` Jonathan Cameron
2026-05-05 17:46 ` [PATCH v3 09/10] iio: accel: mma8452: Use IIO cleanup helpers Sanjay Chitroda
2026-05-05 17:46 ` [PATCH v3 10/10] iio: accel: mma8452: use guard() to release mutexes Sanjay Chitroda
2026-05-06 9:46 ` Andy Shevchenko
2026-05-06 9:24 ` [PATCH v3 00/10] iio: accel: mma8452: improve coding style, pm and resource cleanup Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505174640.3998281-4-sanjayembedded@gmail.com \
--to=sanjayembeddedse@gmail.com \
--cc=andy@kernel.org \
--cc=christoph.muellner@theobroma-systems.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=mfuzzey@parkeon.com \
--cc=nuno.sa@analog.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox