From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
To: jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com,
christoph.muellner@theobroma-systems.com, martink@posteo.de,
mfuzzey@parkeon.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 07/10] iio: accel: mma8452: use local struct device
Date: Tue, 5 May 2026 23:16:37 +0530 [thread overview]
Message-ID: <20260505174640.3998281-8-sanjayembedded@gmail.com> (raw)
In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com>
From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Introduce a local struct device pointer derived from &client->dev.
This avoids repeated &client->dev usage and improves readability.
Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
---
drivers/iio/accel/mma8452.c | 37 +++++++++++++++++++------------------
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index 1c984c708ec3..2cd24b1543af 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel/mma8452.c
@@ -222,15 +222,15 @@ static int mma8452_drdy(struct mma8452_data *data)
static int mma8452_set_runtime_pm_state(struct i2c_client *client, bool on)
{
#ifdef CONFIG_PM
+ struct device *dev = &client->dev;
int ret;
if (on)
- ret = pm_runtime_resume_and_get(&client->dev);
+ ret = pm_runtime_resume_and_get(dev);
else
- ret = pm_runtime_put_autosuspend(&client->dev);
+ ret = pm_runtime_put_autosuspend(dev);
if (ret < 0) {
- dev_err(&client->dev,
- "failed to change power state to %d\n", on);
+ dev_err(dev, "failed to change power state to %d\n", on);
return ret;
}
@@ -1552,7 +1552,7 @@ static int mma8452_probe(struct i2c_client *client)
struct iio_dev *indio_dev;
int ret;
- indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));
+ indio_dev = devm_iio_device_alloc(dev, sizeof(*data));
if (!indio_dev)
return -ENOMEM;
@@ -1562,10 +1562,10 @@ static int mma8452_probe(struct i2c_client *client)
data->chip_info = i2c_get_match_data(client);
if (!data->chip_info)
- return dev_err_probe(&client->dev, -ENODEV,
+ return dev_err_probe(dev, -ENODEV,
"unknown device model\n");
- ret = iio_read_mount_matrix(&client->dev, &data->orientation);
+ ret = iio_read_mount_matrix(dev, &data->orientation);
if (ret)
return ret;
@@ -1598,7 +1598,7 @@ static int mma8452_probe(struct i2c_client *client)
goto disable_regulators;
}
- dev_info(&client->dev, "registering %s accelerometer; ID 0x%x\n",
+ dev_info(dev, "registering %s accelerometer; ID 0x%x\n",
data->chip_info->name, data->chip_info->chip_id);
i2c_set_clientdata(client, indio_dev);
@@ -1631,10 +1631,10 @@ static int mma8452_probe(struct i2c_client *client)
if (client->irq) {
int irq2;
- irq2 = fwnode_irq_get_byname(dev_fwnode(&client->dev), "INT2");
+ irq2 = fwnode_irq_get_byname(dev_fwnode(dev), "INT2");
if (irq2 == client->irq) {
- dev_dbg(&client->dev, "using interrupt line INT2\n");
+ dev_dbg(dev, "using interrupt line INT2\n");
} else {
ret = i2c_smbus_write_byte_data(client,
MMA8452_CTRL_REG5,
@@ -1642,7 +1642,7 @@ static int mma8452_probe(struct i2c_client *client)
if (ret < 0)
goto disable_regulators;
- dev_dbg(&client->dev, "using interrupt line INT1\n");
+ dev_dbg(dev, "using interrupt line INT1\n");
}
ret = i2c_smbus_write_byte_data(client,
@@ -1679,14 +1679,14 @@ static int mma8452_probe(struct i2c_client *client)
goto buffer_cleanup;
}
- ret = pm_runtime_set_active(&client->dev);
+ ret = pm_runtime_set_active(dev);
if (ret < 0)
goto free_irq;
- pm_runtime_enable(&client->dev);
- pm_runtime_set_autosuspend_delay(&client->dev,
+ pm_runtime_enable(dev);
+ pm_runtime_set_autosuspend_delay(dev,
MMA8452_AUTO_SUSPEND_DELAY_MS);
- pm_runtime_use_autosuspend(&client->dev);
+ pm_runtime_use_autosuspend(dev);
ret = iio_device_register(indio_dev);
if (ret < 0)
@@ -1721,11 +1721,12 @@ static void mma8452_remove(struct i2c_client *client)
{
struct iio_dev *indio_dev = i2c_get_clientdata(client);
struct mma8452_data *data = iio_priv(indio_dev);
+ struct device *dev = &client->dev;
iio_device_unregister(indio_dev);
- pm_runtime_disable(&client->dev);
- pm_runtime_set_suspended(&client->dev);
+ pm_runtime_disable(dev);
+ pm_runtime_set_suspended(dev);
if (client->irq)
free_irq(client->irq, indio_dev);
@@ -1748,7 +1749,7 @@ static int mma8452_runtime_suspend(struct device *dev)
ret = mma8452_standby(data);
mutex_unlock(&data->lock);
if (ret < 0) {
- dev_err(&data->client->dev, "powering off device failed\n");
+ dev_err(dev, "powering off device failed\n");
return -EAGAIN;
}
--
2.34.1
next prev parent reply other threads:[~2026-05-05 17:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 17:46 [PATCH v3 00/10] iio: accel: mma8452: improve coding style, pm and resource cleanup Sanjay Chitroda
2026-05-05 17:46 ` [PATCH v3 01/10] iio: accel: mma8452: handle I2C read error(s) in mma8452_read() Sanjay Chitroda
2026-05-05 17:46 ` [PATCH v3 02/10] iio: accel: mma8452: switch to non-devm request_threaded_irq() Sanjay Chitroda
2026-05-06 17:47 ` Jonathan Cameron
2026-05-05 17:46 ` [PATCH v3 03/10] iio: accel: mma8452: cleanup codestyle warning Sanjay Chitroda
2026-05-06 9:24 ` Joshua Crofts
2026-05-06 17:53 ` Jonathan Cameron
2026-05-05 17:46 ` [PATCH v3 04/10] iio: accel: mma8452: sort headers alphabetically Sanjay Chitroda
2026-05-06 9:29 ` Joshua Crofts
2026-05-05 17:46 ` [PATCH v3 05/10] iio: accel: mma8452: Use dev_err_probe() Sanjay Chitroda
2026-05-05 18:45 ` Joshua Crofts
2026-05-06 9:22 ` Andy Shevchenko
2026-05-06 9:27 ` Joshua Crofts
2026-05-06 9:37 ` Andy Shevchenko
2026-05-05 17:46 ` [PATCH v3 06/10] iio: accel: mma8452: convert to bulk regulator usage Sanjay Chitroda
2026-05-05 22:34 ` Joshua Crofts
2026-05-06 9:31 ` Andy Shevchenko
2026-05-05 17:46 ` Sanjay Chitroda [this message]
2026-05-06 9:19 ` [PATCH v3 07/10] iio: accel: mma8452: use local struct device Joshua Crofts
2026-05-06 9:34 ` Andy Shevchenko
2026-05-05 17:46 ` [PATCH v3 08/10] iio: accel: mma8452: use pm_ptr() and direct runtime PM calls Sanjay Chitroda
2026-05-06 9:42 ` Andy Shevchenko
2026-05-06 18:06 ` Jonathan Cameron
2026-05-05 17:46 ` [PATCH v3 09/10] iio: accel: mma8452: Use IIO cleanup helpers Sanjay Chitroda
2026-05-05 17:46 ` [PATCH v3 10/10] iio: accel: mma8452: use guard() to release mutexes Sanjay Chitroda
2026-05-06 9:46 ` Andy Shevchenko
2026-05-06 9:24 ` [PATCH v3 00/10] iio: accel: mma8452: improve coding style, pm and resource cleanup Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505174640.3998281-8-sanjayembedded@gmail.com \
--to=sanjayembeddedse@gmail.com \
--cc=andy@kernel.org \
--cc=christoph.muellner@theobroma-systems.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=mfuzzey@parkeon.com \
--cc=nuno.sa@analog.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox