public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
To: jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com,
	christoph.muellner@theobroma-systems.com, martink@posteo.de,
	mfuzzey@parkeon.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 05/10] iio: accel: mma8452: Use dev_err_probe()
Date: Tue,  5 May 2026 23:16:35 +0530	[thread overview]
Message-ID: <20260505174640.3998281-6-sanjayembedded@gmail.com> (raw)
In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com>

From: Sanjay Chitroda <sanjayembeddedse@gmail.com>

dev_err_probe() makes error code handling simpler and handle
deferred probe nicely (avoid spamming logs).

Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
---
 drivers/iio/accel/mma8452.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index d227ce3d5f67..b49949792190 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel/mma8452.c
@@ -1548,6 +1548,7 @@ MODULE_DEVICE_TABLE(of, mma8452_dt_ids);
 
 static int mma8452_probe(struct i2c_client *client)
 {
+	struct device *dev = &client->dev;
 	struct mma8452_data *data;
 	struct iio_dev *indio_dev;
 	int ret;
@@ -1580,14 +1581,12 @@ static int mma8452_probe(struct i2c_client *client)
 				     "failed to get VDDIO regulator!\n");
 
 	ret = regulator_enable(data->vdd_reg);
-	if (ret) {
-		dev_err(&client->dev, "failed to enable VDD regulator!\n");
-		return ret;
-	}
+	if (ret)
+		return dev_err_probe(dev, ret, "failed to enable VDD regulator!\n");
 
 	ret = regulator_enable(data->vddio_reg);
 	if (ret) {
-		dev_err(&client->dev, "failed to enable VDDIO regulator!\n");
+		dev_err_probe(dev, ret, "failed to enable VDDIO regulator!\n");
 		goto disable_regulator_vdd;
 	}
 
-- 
2.34.1


  parent reply	other threads:[~2026-05-05 17:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05 17:46 [PATCH v3 00/10] iio: accel: mma8452: improve coding style, pm and resource cleanup Sanjay Chitroda
2026-05-05 17:46 ` [PATCH v3 01/10] iio: accel: mma8452: handle I2C read error(s) in mma8452_read() Sanjay Chitroda
2026-05-05 17:46 ` [PATCH v3 02/10] iio: accel: mma8452: switch to non-devm request_threaded_irq() Sanjay Chitroda
2026-05-06 17:47   ` Jonathan Cameron
2026-05-05 17:46 ` [PATCH v3 03/10] iio: accel: mma8452: cleanup codestyle warning Sanjay Chitroda
2026-05-06  9:24   ` Joshua Crofts
2026-05-06 17:53     ` Jonathan Cameron
2026-05-05 17:46 ` [PATCH v3 04/10] iio: accel: mma8452: sort headers alphabetically Sanjay Chitroda
2026-05-06  9:29   ` Joshua Crofts
2026-05-05 17:46 ` Sanjay Chitroda [this message]
2026-05-05 18:45   ` [PATCH v3 05/10] iio: accel: mma8452: Use dev_err_probe() Joshua Crofts
2026-05-06  9:22     ` Andy Shevchenko
2026-05-06  9:27       ` Joshua Crofts
2026-05-06  9:37         ` Andy Shevchenko
2026-05-05 17:46 ` [PATCH v3 06/10] iio: accel: mma8452: convert to bulk regulator usage Sanjay Chitroda
2026-05-05 22:34   ` Joshua Crofts
2026-05-06  9:31   ` Andy Shevchenko
2026-05-05 17:46 ` [PATCH v3 07/10] iio: accel: mma8452: use local struct device Sanjay Chitroda
2026-05-06  9:19   ` Joshua Crofts
2026-05-06  9:34   ` Andy Shevchenko
2026-05-05 17:46 ` [PATCH v3 08/10] iio: accel: mma8452: use pm_ptr() and direct runtime PM calls Sanjay Chitroda
2026-05-06  9:42   ` Andy Shevchenko
2026-05-06 18:06   ` Jonathan Cameron
2026-05-05 17:46 ` [PATCH v3 09/10] iio: accel: mma8452: Use IIO cleanup helpers Sanjay Chitroda
2026-05-05 17:46 ` [PATCH v3 10/10] iio: accel: mma8452: use guard() to release mutexes Sanjay Chitroda
2026-05-06  9:46   ` Andy Shevchenko
2026-05-06  9:24 ` [PATCH v3 00/10] iio: accel: mma8452: improve coding style, pm and resource cleanup Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260505174640.3998281-6-sanjayembedded@gmail.com \
    --to=sanjayembeddedse@gmail.com \
    --cc=andy@kernel.org \
    --cc=christoph.muellner@theobroma-systems.com \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martink@posteo.de \
    --cc=mfuzzey@parkeon.com \
    --cc=nuno.sa@analog.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox