[PATCH v3] staging: rtl8723bs: remove unnecessary comparison to true

[PATCH v3] staging: rtl8723bs: remove unnecessary comparison to true

[Ashwin Gundarapu]

Remove explicit comparison to true in check_fwstate() call and
add spacing around the bitwise OR operator to improve code style.

Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
---
v3: Fixed double --- line and corrected whitespace formatting as
requested by Greg KH.

 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
index c70541f95a73..c100a0d70fe2 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
@@ -151,7 +151,8 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid)
	else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) == true)
		goto release_mlme_lock;
 
-	if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) == true) {
+	if (check_fwstate(pmlmepriv,
+		_FW_LINKED | WIFI_ADHOC_MASTER_STATE)) {
		if ((pmlmepriv->assoc_ssid.ssid_length == ssid->ssid_length) &&
		    (!memcmp(&pmlmepriv->assoc_ssid.ssid, ssid->ssid, ssid->ssid_length))) {
			if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) == false) {

base-commit: 26fd6bff2c050196005312d1d306889220952a99
-- 
2.43.0

Re: [PATCH v3] staging: rtl8723bs: remove unnecessary comparison to true

[gregkh]

On Wed, May 06, 2026 at 10:33:02AM +0530, Ashwin Gundarapu wrote:
> Remove explicit comparison to true in check_fwstate() call and
> add spacing around the bitwise OR operator to improve code style.
> 
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
> v3: Fixed double --- line and corrected whitespace formatting as
> requested by Greg KH.
> 

What changed from v1?

thanks,

greg k-h

Re: [PATCH v3] staging: rtl8723bs: remove unnecessary comparison to true

[Ashwin Gundarapu]

On Wed, May 06, 2026 at 10:33:02AM +0530, Ashwin Gundarapu wrote:
> Remove explicit comparison to true in check_fwstate() call and
> add spacing around the bitwise OR operator to improve code style.
>
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
> v3: Fixed double --- line and corrected whitespace formatting as
> requested by Greg KH.

Changes from v1:
- v2: Resent with corrected whitespace via Thunderbird plain text mode
- v3: Fixed double --- line and corrected whitespace formatting

The original v1 was sent from Gmail web client which corrupted tabs
to spaces. v2 attempted Thunderbird plain text. v3 fixes the double
--- separator and uses Zoho webmail plain text which preserved tabs.


From: gregkh <gregkh@linuxfoundation.org>
To: "Ashwin Gundarapu"<linuxuser509@zohomail.in>
Date: Wed, 06 May 2026 10:55:34 +0530
Subject: Re: [PATCH v3] staging: rtl8723bs: remove unnecessary comparison to true

 > On Wed, May 06, 2026 at 10:42:52AM +0530, Ashwin Gundarapu wrote: 
 >  
 > <snip> 
 >  
 > For some reason you sent this only to me, which is a bit rude to 
 > everyone else on the mailing list.  I'll be glad to respond if you 
 > resend it to everyone. 
 >  
 > thanks, 
 >  
 > greg k-h 
 > 

Re: [PATCH v3] staging: rtl8723bs: remove unnecessary comparison to true

[gregkh]

On Wed, May 06, 2026 at 11:51:37AM +0530, Ashwin Gundarapu wrote:
> On Wed, May 06, 2026 at 10:33:02AM +0530, Ashwin Gundarapu wrote:
> > Remove explicit comparison to true in check_fwstate() call and
> > add spacing around the bitwise OR operator to improve code style.
> >
> > Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> > ---
> > v3: Fixed double --- line and corrected whitespace formatting as
> > requested by Greg KH.
> 
> Changes from v1:
> - v2: Resent with corrected whitespace via Thunderbird plain text mode
> - v3: Fixed double --- line and corrected whitespace formatting
> 
> The original v1 was sent from Gmail web client which corrupted tabs
> to spaces. v2 attempted Thunderbird plain text. v3 fixes the double
> --- separator and uses Zoho webmail plain text which preserved tabs.

This all needs to go below the --- line.

Please add it to v4 when you resend that in a day or so.

Also realize you did not run your patch through checkpatch to verify
that you did not add any issues with your change :(

thanks,

greg k-h