[PATCH] rust: dma: drop placeholder TODO comment

[PATCH] rust: dma: drop placeholder TODO comment

[Melih Emik]

The comment above Coherent already describes the outstanding design

considerations around device resource lifetime.

Drop the standalone placeholder TODO marker and keep the explanatory

text, including a minor wording fix.

No functional change intended.

Signed-off-by: Melih Emik <melihemik@noirlang.tr>
---
 rust/kernel/dma.rs | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs
index 4995ee5dc689..60c458adba0c 100644
--- a/rust/kernel/dma.rs
+++ b/rust/kernel/dma.rs
@@ -580,9 +580,7 @@ fn from(value: CoherentBox<T>) -> Self {
 ///   to an allocated region of coherent memory and `dma_handle` is the DMA address base of the
 ///   region.
 /// - The size in bytes of the allocation is equal to size information via pointer.
-// TODO
-//
-// DMA allocations potentially carry device resources (e.g.IOMMU mappings), hence for soundness
+// DMA allocations potentially carry device resources (e.g. IOMMU mappings), hence for soundness
 // reasons DMA allocation would need to be embedded in a `Devres` container, in order to ensure
 // that device resources can never survive device unbind.
 //
-- 
2.54.0

Re: [PATCH] rust: dma: drop placeholder TODO comment

[Gary Guo]

On Wed May 6, 2026 at 6:46 PM BST, Melih Emik wrote:
> The comment above Coherent already describes the outstanding design
>
> considerations around device resource lifetime.
>
> Drop the standalone placeholder TODO marker and keep the explanatory
>
> text, including a minor wording fix.
>
> No functional change intended.
>
> Signed-off-by: Melih Emik <melihemik@noirlang.tr>
> ---
>  rust/kernel/dma.rs | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs
> index 4995ee5dc689..60c458adba0c 100644
> --- a/rust/kernel/dma.rs
> +++ b/rust/kernel/dma.rs
> @@ -580,9 +580,7 @@ fn from(value: CoherentBox<T>) -> Self {
>  ///   to an allocated region of coherent memory and `dma_handle` is the DMA address base of the
>  ///   region.
>  /// - The size in bytes of the allocation is equal to size information via pointer.
> -// TODO
> -//
> -// DMA allocations potentially carry device resources (e.g.IOMMU mappings), hence for soundness
> +// DMA allocations potentially carry device resources (e.g. IOMMU mappings), hence for soundness
>  // reasons DMA allocation would need to be embedded in a `Devres` container, in order to ensure
>  // that device resources can never survive device unbind.
>  //

The TODO here is supposed to be the heading of the next paragraph.

Best,
Gary

Re: [PATCH] rust: dma: drop placeholder TODO comment

[Onur Özkan]

On Wed, 06 May 2026 20:46:37 +0300
Melih Emik <melihemik@noirlang.tr> wrote:

> The comment above Coherent already describes the outstanding design
> 
> considerations around device resource lifetime.
> 
> Drop the standalone placeholder TODO marker and keep the explanatory
> 
> text, including a minor wording fix.

This formatting is a bit off. Please consider tightening the paragraph and drop
the unnecessary empty lines.

-Onur

> 
> No functional change intended.
> 
> Signed-off-by: Melih Emik <melihemik@noirlang.tr>
> ---
>  rust/kernel/dma.rs | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs
> index 4995ee5dc689..60c458adba0c 100644
> --- a/rust/kernel/dma.rs
> +++ b/rust/kernel/dma.rs
> @@ -580,9 +580,7 @@ fn from(value: CoherentBox<T>) -> Self {
>  ///   to an allocated region of coherent memory and `dma_handle` is the DMA address base of the
>  ///   region.
>  /// - The size in bytes of the allocation is equal to size information via pointer.
> -// TODO
> -//
> -// DMA allocations potentially carry device resources (e.g.IOMMU mappings), hence for soundness
> +// DMA allocations potentially carry device resources (e.g. IOMMU mappings), hence for soundness
>  // reasons DMA allocation would need to be embedded in a `Devres` container, in order to ensure
>  // that device resources can never survive device unbind.
>  //
> -- 
> 2.54.0
>