* [PATCH] crypto: atmel-ecc - replace min_t with min
@ 2026-05-07 13:55 Thorsten Blum
2026-05-07 14:50 ` David Laight
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2026-05-07 13:55 UTC (permalink / raw)
To: Thorsten Blum, Herbert Xu, David S. Miller, Nicolas Ferre,
Alexandre Belloni, Claudiu Beznea
Cc: linux-crypto, linux-arm-kernel, linux-kernel
Use the simpler min() macro since the values are all unsigned and
compatible.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/crypto/atmel-ecc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
index b6a77c8d439c..2cf53f0b6742 100644
--- a/drivers/crypto/atmel-ecc.c
+++ b/drivers/crypto/atmel-ecc.c
@@ -56,7 +56,7 @@ static void atmel_ecdh_done(struct atmel_i2c_work_data *work_data, void *areq,
goto free_work_data;
/* might want less than we've got */
- n_sz = min_t(size_t, ATMEL_ECC_NIST_P256_N_SIZE, req->dst_len);
+ n_sz = min(ATMEL_ECC_NIST_P256_N_SIZE, req->dst_len);
/* copy the shared secret */
copied = sg_copy_from_buffer(req->dst, sg_nents_for_len(req->dst, n_sz),
@@ -150,7 +150,7 @@ static int atmel_ecdh_generate_public_key(struct kpp_request *req)
return -EINVAL;
/* might want less than we've got */
- nbytes = min_t(size_t, ATMEL_ECC_PUBKEY_SIZE, req->dst_len);
+ nbytes = min(ATMEL_ECC_PUBKEY_SIZE, req->dst_len);
/* public key was saved at private key generation */
copied = sg_copy_from_buffer(req->dst,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: atmel-ecc - replace min_t with min
2026-05-07 13:55 [PATCH] crypto: atmel-ecc - replace min_t with min Thorsten Blum
@ 2026-05-07 14:50 ` David Laight
0 siblings, 0 replies; 2+ messages in thread
From: David Laight @ 2026-05-07 14:50 UTC (permalink / raw)
To: Thorsten Blum
Cc: Herbert Xu, David S. Miller, Nicolas Ferre, Alexandre Belloni,
Claudiu Beznea, linux-crypto, linux-arm-kernel, linux-kernel
On Thu, 7 May 2026 15:55:27 +0200
Thorsten Blum <thorsten.blum@linux.dev> wrote:
> Use the simpler min() macro since the values are all unsigned and
> compatible.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
I'm all for nuking min_t(), so:
Reviewed-by: David Laight <david.laght.linux@gmail.com>
> ---
> drivers/crypto/atmel-ecc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
> index b6a77c8d439c..2cf53f0b6742 100644
> --- a/drivers/crypto/atmel-ecc.c
> +++ b/drivers/crypto/atmel-ecc.c
> @@ -56,7 +56,7 @@ static void atmel_ecdh_done(struct atmel_i2c_work_data *work_data, void *areq,
> goto free_work_data;
>
> /* might want less than we've got */
> - n_sz = min_t(size_t, ATMEL_ECC_NIST_P256_N_SIZE, req->dst_len);
> + n_sz = min(ATMEL_ECC_NIST_P256_N_SIZE, req->dst_len);
Not entirely related, but (to me) the arguments are in the wrong order.
>
> /* copy the shared secret */
> copied = sg_copy_from_buffer(req->dst, sg_nents_for_len(req->dst, n_sz),
> @@ -150,7 +150,7 @@ static int atmel_ecdh_generate_public_key(struct kpp_request *req)
> return -EINVAL;
>
> /* might want less than we've got */
> - nbytes = min_t(size_t, ATMEL_ECC_PUBKEY_SIZE, req->dst_len);
> + nbytes = min(ATMEL_ECC_PUBKEY_SIZE, req->dst_len);
>
> /* public key was saved at private key generation */
> copied = sg_copy_from_buffer(req->dst,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-07 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-07 13:55 [PATCH] crypto: atmel-ecc - replace min_t with min Thorsten Blum
2026-05-07 14:50 ` David Laight
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox