* [PATCH] staging: rtl8723bs: fix open parenthesis at end of line
@ 2026-05-06 2:26 David Cardenas
2026-05-06 5:01 ` gregkh
0 siblings, 1 reply; 4+ messages in thread
From: David Cardenas @ 2026-05-06 2:26 UTC (permalink / raw)
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Function declarations and conditional statements should not end
with an opening parenthesis. Reformat affected functions and
if statements to place the opening condition or first parameter
on the same line as the function name or keyword
Signed-off-by: David <ldcc@proton.me>
---
.../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 179 +++++++-----------
1 file changed, 64 insertions(+), 115 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
index 6ab65e9e8..59b8f7e99 100644
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
@@ -30,6 +30,7 @@ static u8 DeltaSwingTableIdx_2GA_N_8188E[] = {
0, 0, 0, 2, 2, 3, 3, 4, 4, 4, 4, 5, 5, 6, 6,
7, 7, 7, 7, 8, 8, 9, 9, 10, 10, 10, 11, 11, 11, 11
};
+
static u8 DeltaSwingTableIdx_2GA_P_8188E[] = {
0, 0, 0, 0, 1, 1, 2, 2, 3, 3, 4, 4, 4, 4, 4,
4, 4, 4, 5, 5, 7, 7, 8, 8, 8, 9, 9, 9, 9, 9
@@ -39,14 +40,11 @@ static u8 DeltaSwingTableIdx_2GA_P_8188E[] = {
/* 3 Tx Power Tracking */
/* 3 ============================================================ */
-
-static void setIqkMatrix_8723B(
- struct dm_odm_t *pDM_Odm,
- u8 OFDM_index,
- u8 RFPath,
- s32 IqkResult_X,
- s32 IqkResult_Y
-)
+static void setIqkMatrix_8723B(struct dm_odm_t *pDM_Odm,
+ u8 OFDM_index,
+ u8 RFPath,
+ s32 IqkResult_X,
+ s32 IqkResult_Y)
{
s32 ele_A = 0, ele_D, ele_C = 0, value32;
@@ -149,12 +147,10 @@ static void setCCKFilterCoefficient(struct dm_odm_t *pDM_Odm, u8 CCKSwingIndex)
*04/23/2012 MHC Create Version 0.
*
*---------------------------------------------------------------------------*/
-void ODM_TxPwrTrackSetPwr_8723B(
- struct dm_odm_t *pDM_Odm,
- enum pwrtrack_method Method,
- u8 RFPath,
- u8 ChannelMappedIndex
-)
+void ODM_TxPwrTrackSetPwr_8723B(struct dm_odm_t *pDM_Odm,
+ enum pwrtrack_method Method,
+ u8 RFPath,
+ u8 ChannelMappedIndex)
{
struct adapter *Adapter = pDM_Odm->Adapter;
struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
@@ -287,13 +283,11 @@ void ODM_TxPwrTrackSetPwr_8723B(
return; /* This method is not supported. */
}
-static void GetDeltaSwingTable_8723B(
- struct dm_odm_t *pDM_Odm,
- u8 **TemperatureUP_A,
- u8 **TemperatureDOWN_A,
- u8 **TemperatureUP_B,
- u8 **TemperatureDOWN_B
-)
+static void GetDeltaSwingTable_8723B(struct dm_odm_t *pDM_Odm,
+ u8 **TemperatureUP_A,
+ u8 **TemperatureDOWN_A,
+ u8 **TemperatureUP_B,
+ u8 **TemperatureDOWN_B)
{
struct adapter *Adapter = pDM_Odm->Adapter;
struct odm_rf_cal_t *pRFCalibrateInfo = &pDM_Odm->RFCalibrateInfo;
@@ -340,9 +334,7 @@ void ConfigureTxpowerTrack_8723B(struct txpwrtrack_cfg *pConfig)
#define MAX_TOLERANCE 5
/* bit0 = 1 => Tx OK, bit1 = 1 => Rx OK */
-static u8 phy_PathA_IQK_8723B(
- struct adapter *padapter, bool configPathB, u8 RF_Path
-)
+static u8 phy_PathA_IQK_8723B(struct adapter *padapter, bool configPathB, u8 RF_Path)
{
u32 regEAC, regE94, regE9C, tmp, Path_SEL_BB /*, regEA4*/;
u8 result = 0x00;
@@ -425,14 +417,12 @@ static u8 phy_PathA_IQK_8723B(
if ((tmp & 0x200) > 0)
tmp = 0x400 - tmp;
- if (
- !(regEAC & BIT28) &&
+ if (!(regEAC & BIT28) &&
(((regE94 & 0x03FF0000)>>16) != 0x142) &&
(((regE9C & 0x03FF0000)>>16) != 0x42) &&
(((regE94 & 0x03FF0000)>>16) < 0x110) &&
(((regE94 & 0x03FF0000)>>16) > 0xf0) &&
- (tmp < 0xf)
- )
+ (tmp < 0xf))
result |= 0x01;
else /* if Tx not OK, ignore Rx */
return result;
@@ -441,9 +431,7 @@ static u8 phy_PathA_IQK_8723B(
}
/* bit0 = 1 => Tx OK, bit1 = 1 => Rx OK */
-static u8 phy_PathA_RxIQK8723B(
- struct adapter *padapter, bool configPathB, u8 RF_Path
-)
+static u8 phy_PathA_RxIQK8723B(struct adapter *padapter, bool configPathB, u8 RF_Path)
{
u32 regEAC, regE94, regE9C, regEA4, u4tmp, tmp, Path_SEL_BB;
u8 result = 0x00;
@@ -524,14 +512,12 @@ static u8 phy_PathA_RxIQK8723B(
if ((tmp & 0x200) > 0)
tmp = 0x400 - tmp;
- if (
- !(regEAC & BIT28) &&
+ if (!(regEAC & BIT28) &&
(((regE94 & 0x03FF0000)>>16) != 0x142) &&
(((regE9C & 0x03FF0000)>>16) != 0x42) &&
(((regE94 & 0x03FF0000)>>16) < 0x110) &&
(((regE94 & 0x03FF0000)>>16) > 0xf0) &&
- (tmp < 0xf)
- )
+ (tmp < 0xf))
result |= 0x01;
else /* if Tx not OK, ignore Rx */
return result;
@@ -615,14 +601,12 @@ static u8 phy_PathA_RxIQK8723B(
if ((tmp & 0x200) > 0)
tmp = 0x400 - tmp;
- if (
- !(regEAC & BIT27) && /* if Tx is OK, check whether Rx is OK */
+ if (!(regEAC & BIT27) && /* if Tx is OK, check whether Rx is OK */
(((regEA4 & 0x03FF0000)>>16) != 0x132) &&
(((regEAC & 0x03FF0000)>>16) != 0x36) &&
(((regEA4 & 0x03FF0000)>>16) < 0x110) &&
(((regEA4 & 0x03FF0000)>>16) > 0xf0) &&
- (tmp < 0xf)
- )
+ (tmp < 0xf))
result |= 0x02;
return result;
@@ -708,14 +692,12 @@ static u8 phy_PathB_IQK_8723B(struct adapter *padapter)
if ((tmp & 0x200) > 0)
tmp = 0x400 - tmp;
- if (
- !(regEAC & BIT28) &&
+ if (!(regEAC & BIT28) &&
(((regE94 & 0x03FF0000)>>16) != 0x142) &&
(((regE9C & 0x03FF0000)>>16) != 0x42) &&
(((regE94 & 0x03FF0000)>>16) < 0x110) &&
(((regE94 & 0x03FF0000)>>16) > 0xf0) &&
- (tmp < 0xf)
- )
+ (tmp < 0xf))
result |= 0x01;
return result;
@@ -803,14 +785,12 @@ static u8 phy_PathB_RxIQK8723B(struct adapter *padapter, bool configPathB)
if ((tmp & 0x200) > 0)
tmp = 0x400 - tmp;
- if (
- !(regEAC & BIT28) &&
+ if (!(regEAC & BIT28) &&
(((regE94 & 0x03FF0000)>>16) != 0x142) &&
(((regE9C & 0x03FF0000)>>16) != 0x42) &&
(((regE94 & 0x03FF0000)>>16) < 0x110) &&
(((regE94 & 0x03FF0000)>>16) > 0xf0) &&
- (tmp < 0xf)
- )
+ (tmp < 0xf))
result |= 0x01;
else /* if Tx not OK, ignore Rx */
return result;
@@ -895,26 +875,22 @@ static u8 phy_PathB_RxIQK8723B(struct adapter *padapter, bool configPathB)
if ((tmp & 0x200) > 0)
tmp = 0x400 - tmp;
- if (
- !(regEAC & BIT27) && /* if Tx is OK, check whether Rx is OK */
+ if (!(regEAC & BIT27) && /* if Tx is OK, check whether Rx is OK */
(((regEA4 & 0x03FF0000)>>16) != 0x132) &&
(((regEAC & 0x03FF0000)>>16) != 0x36) &&
(((regEA4 & 0x03FF0000)>>16) < 0x110) &&
(((regEA4 & 0x03FF0000)>>16) > 0xf0) &&
- (tmp < 0xf)
- )
+ (tmp < 0xf))
result |= 0x02;
return result;
}
-static void _PHY_PathAFillIQKMatrix8723B(
- struct adapter *padapter,
- bool bIQKOK,
- s32 result[][8],
- u8 final_candidate,
- bool bTxOnly
-)
+static void _PHY_PathAFillIQKMatrix8723B(struct adapter *padapter,
+ bool bIQKOK,
+ s32 result[][8],
+ u8 final_candidate,
+ bool bTxOnly)
{
u32 Oldval_0, X, TX0_A, reg;
s32 Y, TX0_C;
@@ -982,13 +958,11 @@ static void _PHY_PathAFillIQKMatrix8723B(
}
}
-static void _PHY_PathBFillIQKMatrix8723B(
- struct adapter *padapter,
- bool bIQKOK,
- s32 result[][8],
- u8 final_candidate,
- bool bTxOnly /* do Tx only */
-)
+static void _PHY_PathBFillIQKMatrix8723B(struct adapter *padapter,
+ bool bIQKOK,
+ s32 result[][8],
+ u8 final_candidate,
+ bool bTxOnly /* do Tx only */)
{
u32 Oldval_1, X, TX1_A, reg;
s32 Y, TX1_C;
@@ -1068,12 +1042,10 @@ void ODM_SetIQCbyRFpath(struct dm_odm_t *pDM_Odm, u32 RFpath)
struct odm_rf_cal_t *pRFCalibrateInfo = &pDM_Odm->RFCalibrateInfo;
u8 path;
- if (
- (pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC80][VAL] != 0x0) &&
+ if ((pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC80][VAL] != 0x0) &&
(pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xC14][VAL] != 0x0) &&
(pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC80][VAL] != 0x0) &&
- (pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xC14][VAL] != 0x0)
- ) {
+ (pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xC14][VAL] != 0x0)) {
if (RFpath)
path = PATH_S0;
else
@@ -1094,12 +1066,10 @@ static bool ODM_CheckPowerStatus(struct adapter *Adapter)
return true;
}
-static void _PHY_SaveADDARegisters8723B(
- struct adapter *padapter,
- u32 *ADDAReg,
- u32 *ADDABackup,
- u32 RegisterNum
-)
+static void _PHY_SaveADDARegisters8723B(struct adapter *padapter,
+ u32 *ADDAReg,
+ u32 *ADDABackup,
+ u32 RegisterNum)
{
u32 i;
struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
@@ -1114,9 +1084,7 @@ static void _PHY_SaveADDARegisters8723B(
}
-static void _PHY_SaveMACRegisters8723B(
- struct adapter *padapter, u32 *MACReg, u32 *MACBackup
-)
+static void _PHY_SaveMACRegisters8723B(struct adapter *padapter, u32 *MACReg, u32 *MACBackup)
{
u32 i;
struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
@@ -1130,12 +1098,10 @@ static void _PHY_SaveMACRegisters8723B(
}
-static void _PHY_ReloadADDARegisters8723B(
- struct adapter *padapter,
- u32 *ADDAReg,
- u32 *ADDABackup,
- u32 RegiesterNum
-)
+static void _PHY_ReloadADDARegisters8723B(struct adapter *padapter,
+ u32 *ADDAReg,
+ u32 *ADDABackup,
+ u32 RegiesterNum)
{
u32 i;
struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
@@ -1146,9 +1112,7 @@ static void _PHY_ReloadADDARegisters8723B(
}
}
-static void _PHY_ReloadMACRegisters8723B(
- struct adapter *padapter, u32 *MACReg, u32 *MACBackup
-)
+static void _PHY_ReloadMACRegisters8723B(struct adapter *padapter, u32 *MACReg, u32 *MACBackup)
{
u32 i;
@@ -1159,11 +1123,7 @@ static void _PHY_ReloadMACRegisters8723B(
}
-static void _PHY_PathADDAOn8723B(
- struct adapter *padapter,
- u32 *ADDAReg,
- bool is2T
-)
+static void _PHY_PathADDAOn8723B(struct adapter *padapter, u32 *ADDAReg, bool is2T)
{
u32 pathOn;
u32 i;
@@ -1184,9 +1144,7 @@ static void _PHY_PathADDAOn8723B(
}
-static void _PHY_MACSettingCalibration8723B(
- struct adapter *padapter, u32 *MACReg, u32 *MACBackup
-)
+static void _PHY_MACSettingCalibration8723B(struct adapter *padapter, u32 *MACReg, u32 *MACBackup)
{
u32 i = 0;
struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
@@ -1201,12 +1159,7 @@ static void _PHY_MACSettingCalibration8723B(
}
-static bool phy_SimularityCompare_8723B(
- struct adapter *padapter,
- s32 result[][8],
- u8 c1,
- u8 c2
-)
+static bool phy_SimularityCompare_8723B(struct adapter *padapter, s32 result[][8], u8 c1, u8 c2)
{
u32 i, j, diff, SimularityBitMap, bound = 0;
u8 final_candidate[2] = {0xFF, 0xFF}; /* for path A and path B */
@@ -1284,13 +1237,11 @@ static bool phy_SimularityCompare_8723B(
-static void phy_IQCalibrate_8723B(
- struct adapter *padapter,
- s32 result[][8],
- u8 t,
- bool is2T,
- u8 RF_Path
-)
+static void phy_IQCalibrate_8723B(struct adapter *padapter,
+ s32 result[][8],
+ u8 t,
+ bool is2T,
+ u8 RF_Path)
{
struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
struct dm_odm_t *pDM_Odm = &pHalData->odmpriv;
@@ -1544,13 +1495,11 @@ static void phy_LCCalibrate_8723B(struct dm_odm_t *pDM_Odm, bool is2T)
/* IQK version:V2.5 20140123 */
/* IQK is controlled by Is2ant, RF path */
-void PHY_IQCalibrate_8723B(
- struct adapter *padapter,
- bool bReCovery,
- bool bRestore,
- bool Is2ant, /* false:1ant, true:2-ant */
- u8 RF_Path /* 0:S1, 1:S0 */
-)
+void PHY_IQCalibrate_8723B(struct adapter *padapter,
+ bool bReCovery,
+ bool bRestore,
+ bool Is2ant, /* false:1ant, true:2-ant */
+ u8 RF_Path /* 0:S1, 1:S0 */)
{
struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: rtl8723bs: fix open parenthesis at end of line
2026-05-06 2:26 [PATCH] staging: rtl8723bs: fix open parenthesis at end of line David Cardenas
@ 2026-05-06 5:01 ` gregkh
[not found] ` <1XxaPkNOP-p-F8PW1lsqdkdN9K2o6TS3kphmVpxm6gXIMn9Ygk7UPsiOosb9eybCDX_1lCU4PwdUKlPmFdTuAhAAg_aS65tADEe2YeAisek=@proton.me>
0 siblings, 1 reply; 4+ messages in thread
From: gregkh @ 2026-05-06 5:01 UTC (permalink / raw)
To: David Cardenas
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
On Wed, May 06, 2026 at 02:26:02AM +0000, David Cardenas wrote:
> Function declarations and conditional statements should not end
> with an opening parenthesis. Reformat affected functions and
> if statements to place the opening condition or first parameter
> on the same line as the function name or keyword
>
> Signed-off-by: David <ldcc@proton.me>
> ---
> .../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 179 +++++++-----------
> 1 file changed, 64 insertions(+), 115 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> index 6ab65e9e8..59b8f7e99 100644
> --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> @@ -30,6 +30,7 @@ static u8 DeltaSwingTableIdx_2GA_N_8188E[] = {
> 0, 0, 0, 2, 2, 3, 3, 4, 4, 4, 4, 5, 5, 6, 6,
> 7, 7, 7, 7, 8, 8, 9, 9, 10, 10, 10, 11, 11, 11, 11
> };
> +
This change is not described in your changelog :(
Also, the From: line does not match your Signed-off-by: line.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-05-08 5:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-06 2:26 [PATCH] staging: rtl8723bs: fix open parenthesis at end of line David Cardenas
2026-05-06 5:01 ` gregkh
[not found] ` <1XxaPkNOP-p-F8PW1lsqdkdN9K2o6TS3kphmVpxm6gXIMn9Ygk7UPsiOosb9eybCDX_1lCU4PwdUKlPmFdTuAhAAg_aS65tADEe2YeAisek=@proton.me>
2026-05-08 2:48 ` [PATCH v2] " David Cardenas
2026-05-08 5:25 ` gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox