* [PATCH] staging: sm750fb: Fix const pointer declaration
@ 2026-05-04 22:36 Denis Arzubov
2026-05-11 7:57 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Denis Arzubov @ 2026-05-04 22:36 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Denis Arzubov
Make g_fbmode array pointer const to follow kernel coding style.
This resolves the checkpatch warning:
WARNING: static const char * array should probably be static const char * const
Signed-off-by: Denis Arzubov <denisarzubov8@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index fadba95850be..8fc0d1c66991 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -33,7 +33,7 @@
static int g_hwcursor = 1;
static int g_noaccel;
static int g_nomtrr;
-static const char *g_fbmode[] = {NULL, NULL};
+static const char * const g_fbmode[] = {NULL, NULL};
static const char *g_def_fbmode = "1024x768-32@60";
static char *g_settings;
static int g_dualview;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: sm750fb: Fix const pointer declaration
2026-05-04 22:36 [PATCH] staging: sm750fb: Fix const pointer declaration Denis Arzubov
@ 2026-05-11 7:57 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-05-11 7:57 UTC (permalink / raw)
To: Denis Arzubov; +Cc: linux-staging, linux-kernel
On Tue, May 05, 2026 at 01:36:27AM +0300, Denis Arzubov wrote:
> Make g_fbmode array pointer const to follow kernel coding style.
> This resolves the checkpatch warning:
> WARNING: static const char * array should probably be static const char * const
>
> Signed-off-by: Denis Arzubov <denisarzubov8@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index fadba95850be..8fc0d1c66991 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -33,7 +33,7 @@
> static int g_hwcursor = 1;
> static int g_noaccel;
> static int g_nomtrr;
> -static const char *g_fbmode[] = {NULL, NULL};
> +static const char * const g_fbmode[] = {NULL, NULL};
> static const char *g_def_fbmode = "1024x768-32@60";
> static char *g_settings;
> static int g_dualview;
> --
> 2.43.0
>
Please always test-build your changes :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-11 7:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-04 22:36 [PATCH] staging: sm750fb: Fix const pointer declaration Denis Arzubov
2026-05-11 7:57 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox