From: Noah Techoueyres <noahtechoueyres@gmail.com>
To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev
Cc: nikolayof23@gmail.com, linux-kernel@vger.kernel.org,
Noah Techoueyres <noahtechoueyres@gmail.com>
Subject: [PATCH v2] staging: rtl8723bs: fix line length checks in rtw_cmd.c
Date: Mon, 11 May 2026 20:31:15 -0400 [thread overview]
Message-ID: <20260512003115.5570-1-noahtechoueyres@gmail.com> (raw)
Fix both block comments and assignment statements that exceed the
100-column limit to follow Linux guidelines for readability. Used
intermediate pointers to fix assignment statements.
Signed-off-by: Noah Techoueyres <noahtechoueyres@gmail.com>
---
Changes in v2:
- Replaced repeated struct access paths with an intermediate
pointer to traffic_stat to resolve the 100-column limit.
drivers/staging/rtl8723bs/core/rtw_cmd.c | 38 ++++++++++++++----------
1 file changed, 23 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index c1185c25ed36..5c6999ac17f6 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -1106,24 +1106,25 @@ static void collect_traffic_statistics(struct adapter *padapter)
{
struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter);
+ struct rtw_traffic_statistics *stat = &pdvobjpriv->traffic_stat;
+
/* Tx */
- pdvobjpriv->traffic_stat.tx_bytes = padapter->xmitpriv.tx_bytes;
- pdvobjpriv->traffic_stat.tx_pkts = padapter->xmitpriv.tx_pkts;
- pdvobjpriv->traffic_stat.tx_drop = padapter->xmitpriv.tx_drop;
+ stat->tx_bytes = padapter->xmitpriv.tx_bytes;
+ stat->tx_pkts = padapter->xmitpriv.tx_pkts;
+ stat->tx_drop = padapter->xmitpriv.tx_drop;
/* Rx */
- pdvobjpriv->traffic_stat.rx_bytes = padapter->recvpriv.rx_bytes;
- pdvobjpriv->traffic_stat.rx_pkts = padapter->recvpriv.rx_pkts;
- pdvobjpriv->traffic_stat.rx_drop = padapter->recvpriv.rx_drop;
+ stat->rx_bytes = padapter->recvpriv.rx_bytes;
+ stat->rx_pkts = padapter->recvpriv.rx_pkts;
+ stat->rx_drop = padapter->recvpriv.rx_drop;
/* Calculate throughput in last interval */
- pdvobjpriv->traffic_stat.cur_tx_bytes = pdvobjpriv->traffic_stat.tx_bytes - pdvobjpriv->traffic_stat.last_tx_bytes;
- pdvobjpriv->traffic_stat.cur_rx_bytes = pdvobjpriv->traffic_stat.rx_bytes - pdvobjpriv->traffic_stat.last_rx_bytes;
- pdvobjpriv->traffic_stat.last_tx_bytes = pdvobjpriv->traffic_stat.tx_bytes;
- pdvobjpriv->traffic_stat.last_rx_bytes = pdvobjpriv->traffic_stat.rx_bytes;
-
- pdvobjpriv->traffic_stat.cur_tx_tp = (u32)(pdvobjpriv->traffic_stat.cur_tx_bytes * 8 / 2 / 1024 / 1024);
- pdvobjpriv->traffic_stat.cur_rx_tp = (u32)(pdvobjpriv->traffic_stat.cur_rx_bytes * 8 / 2 / 1024 / 1024);
+ stat->cur_tx_bytes = stat->tx_bytes - stat->last_tx_bytes;
+ stat->cur_rx_bytes = stat->rx_bytes - stat->last_rx_bytes;
+ stat->last_tx_bytes = stat->tx_bytes;
+ stat->last_rx_bytes = stat->rx_bytes;
+ stat->cur_tx_tp = (u32)(stat->cur_tx_bytes * 8 / 2 / 1024 / 1024);
+ stat->cur_rx_tp = (u32)(stat->cur_rx_bytes * 8 / 2 / 1024 / 1024);
}
bool traffic_status_watchdog(struct adapter *padapter, bool from_timer)
@@ -1743,7 +1744,11 @@ u8 rtw_drvextra_cmd_hdl(struct adapter *padapter, unsigned char *pbuf)
pdrvextra_cmd = (struct drvextra_cmd_parm *)pbuf;
switch (pdrvextra_cmd->ec_id) {
- case DYNAMIC_CHK_WK_CID:/* only primary padapter go to this cmd, but execute dynamic_chk_wk_hdl() for two interfaces */
+ case DYNAMIC_CHK_WK_CID:
+ /*
+ * only primary padapter go to this cmd, but execute
+ * dynamic_chk_wk_hdl() for two interfaces
+ */
dynamic_chk_wk_hdl(padapter);
break;
case POWER_SAVING_CTRL_WK_CID:
@@ -1881,7 +1886,10 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
_clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING);
spin_unlock_bh(&pmlmepriv->scanned_queue.lock);
- /* we will set _FW_LINKED when there is one more sat to join us (rtw_stassoc_event_callback) */
+ /*
+ * we will set _FW_LINKED when there is one more sta
+ * to join us (rtw_stassoc_event_callback)
+ */
}
createbss_cmd_fail:
--
2.53.0
next reply other threads:[~2026-05-12 0:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 0:31 Noah Techoueyres [this message]
2026-05-12 7:27 ` [PATCH v2] staging: rtl8723bs: fix line length checks in rtw_cmd.c Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512003115.5570-1-noahtechoueyres@gmail.com \
--to=noahtechoueyres@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nikolayof23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox