From: Dan Carpenter <error27@gmail.com>
To: Noah Techoueyres <noahtechoueyres@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
nikolayof23@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: fix line length checks in rtw_cmd.c
Date: Tue, 12 May 2026 10:27:51 +0300 [thread overview]
Message-ID: <agLWd1tPaHQvmhBE@stanley.mountain> (raw)
In-Reply-To: <20260512003115.5570-1-noahtechoueyres@gmail.com>
On Mon, May 11, 2026 at 08:31:15PM -0400, Noah Techoueyres wrote:
> Fix both block comments and assignment statements that exceed the
> 100-column limit to follow Linux guidelines for readability. Used
> intermediate pointers to fix assignment statements.
>
These are unrelated. Do it in two patches.
> Signed-off-by: Noah Techoueyres <noahtechoueyres@gmail.com>
> ---
> Changes in v2:
> - Replaced repeated struct access paths with an intermediate
> pointer to traffic_stat to resolve the 100-column limit.
>
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 38 ++++++++++++++----------
> 1 file changed, 23 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index c1185c25ed36..5c6999ac17f6 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -1106,24 +1106,25 @@ static void collect_traffic_statistics(struct adapter *padapter)
> {
> struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter);
>
> + struct rtw_traffic_statistics *stat = &pdvobjpriv->traffic_stat;
Don't put a blank line in the middle of the declaration block.
regards,
dan carpenter
prev parent reply other threads:[~2026-05-12 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 0:31 [PATCH v2] staging: rtl8723bs: fix line length checks in rtw_cmd.c Noah Techoueyres
2026-05-12 7:27 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agLWd1tPaHQvmhBE@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nikolayof23@gmail.com \
--cc=noahtechoueyres@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox